D17494: Allow translation of the style plugin names in molecule viewer

2018-12-16 Thread Yuri Chornoivan
yurchor abandoned this revision. yurchor added a comment. Abandoned because the lack of needed knowledge from the author to satisfy the reviewer requirements. REPOSITORY R326 Kalzium REVISION DETAIL https://phabricator.kde.org/D17494 To: yurchor, #kde_edu, pino Cc: kde-doc-english,

D17494: Allow translation of the style plugin names in molecule viewer

2018-12-16 Thread Pino Toscano
pino requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R326 Kalzium REVISION DETAIL https://phabricator.kde.org/D17494 To: yurchor, #kde_edu, pino Cc: kde-doc-english, pino, kde-edu, skadinna, narvaez, apol

D17494: Allow translation of the style plugin names in molecule viewer

2018-12-16 Thread Pino Toscano
pino added a comment. In D17494#377824 , @yurchor wrote: > In D17494#377816 , @pino wrote: > > > The approach here should be changed: instead of hardcoding the names of plugins in the `styleCombo`,

D17494: Allow translation of the style plugin names in molecule viewer

2018-12-16 Thread Yuri Chornoivan
yurchor updated this revision to Diff 47657. yurchor added a comment. Commit the Avogadro page new URL and removal of the old instructions separately. REPOSITORY R326 Kalzium CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17494?vs=47654=47657 REVISION DETAIL

D17494: Allow translation of the style plugin names in molecule viewer

2018-12-16 Thread Yuri Chornoivan
yurchor marked 2 inline comments as done. REPOSITORY R326 Kalzium REVISION DETAIL https://phabricator.kde.org/D17494 To: yurchor, #kde_edu, pino Cc: kde-doc-english, pino, kde-edu, skadinna, narvaez, apol

D17494: Allow translation of the style plugin names in molecule viewer

2018-12-16 Thread Yuri Chornoivan
yurchor added a comment. In D17494#377816 , @pino wrote: > The approach here should be changed: instead of hardcoding the names of plugins in the `styleCombo`, they ought to be read directly from the `sceneModel()` of the GL widget. This way:

D17494: Allow translation of the style plugin names in molecule viewer

2018-12-16 Thread Pino Toscano
pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. The approach here should be changed: instead of hardcoding the names of plugins in the `styleCombo`, they ought to be read directly from the `sceneModel()` of the GL widget. This

D17494: Allow translation of the style plugin names in molecule viewer

2018-12-15 Thread Yuri Chornoivan
yurchor updated this revision to Diff 47654. yurchor marked 2 inline comments as done. yurchor added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. Sync the docs. REPOSITORY R326 Kalzium CHANGES SINCE LAST UPDATE