D13450: Add arrow keys to move and resize selection rectangle

2018-07-19 Thread Scott Harvey
sharvey added a comment. In D13450#294820 , @rkflx wrote: > It seems you forgot to merge stable into master, which I now have done with I was actually in the process of trying to figure that out... I got a lengthy list of warnings when I

D13450: Add arrow keys to move and resize selection rectangle

2018-07-19 Thread Henrik Fehlauer
rkflx added a comment. It seems you forgot to merge stable into master, which I now have done with git checkout master git pull git merge -Xours origin/Applications/18.08 git push Thanks again for the quick update so we could get the string changes in in time, and

[spectacle/Applications/18.08] /: Add arrow keys to move and resize selection rectangle

2018-07-19 Thread Scott Harvey
Git commit 48eacd1ba1495a9167dd9f9cd8097e86ae6ff6dd by Scott Harvey. Committed on 19/07/2018 at 10:38. Pushed by sharvey into branch 'Applications/18.08'. Add arrow keys to move and resize selection rectangle Summary: Add arrow keys to move and resize selection rectangle. {key Arrows} alone

D13450: Add arrow keys to move and resize selection rectangle

2018-07-19 Thread Scott Harvey
This revision was automatically updated to reflect the committed changes. Closed by commit R166:48eacd1ba149: Add arrow keys to move and resize selection rectangle (authored by sharvey). REPOSITORY R166 Spectacle CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13450?vs=38082=38083

D13450: Add arrow keys to move and resize selection rectangle

2018-07-19 Thread Scott Harvey
sharvey added a comment. In D13450#294808 , @rkflx wrote: > Thanks, looking much better now. > > Please make sure to commit to the stable branch, i.e. `Applications/18.08` (let me know if you are unsure what that means). Following

D13450: Add arrow keys to move and resize selection rectangle

2018-07-19 Thread Scott Harvey
sharvey updated this revision to Diff 38082. sharvey added a comment. - Minor whitespace cleanup REPOSITORY R166 Spectacle CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13450?vs=38080=38082 BRANCH arcpatch-D13450 REVISION DETAIL https://phabricator.kde.org/D13450 AFFECTED

D13450: Add arrow keys to move and resize selection rectangle

2018-07-19 Thread Henrik Fehlauer
rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. Thanks, looking much better now. Please make sure to commit to the stable branch, i.e. `Applications/18.08` (let me know if you are unsure what that means). REPOSITORY R166 Spectacle

D13450: Add arrow keys to move and resize selection rectangle

2018-07-19 Thread Scott Harvey
sharvey marked 2 inline comments as done. REPOSITORY R166 Spectacle REVISION DETAIL https://phabricator.kde.org/D13450 To: sharvey, rkflx, ngraham, #spectacle, yurchor Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

2018-07-19 Thread Scott Harvey
sharvey updated this revision to Diff 38080. sharvey added a comment. - Fix Alt + Down; Undo layout changes for help text; Reorder help text items REPOSITORY R166 Spectacle CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13450?vs=38014=38080 BRANCH arcpatch-D13450 REVISION