D15083: Use title case for the clipboard button

2018-08-25 Thread Nathaniel Graham
ngraham added a comment. OK, no problem. :) I just like to do my work in public. I'll take your comment to mean acceptance and land the patch! REPOSITORY R166 Spectacle REVISION DETAIL https://phabricator.kde.org/D15083 To: ngraham, #spectacle, #kde_applications, broulik, cfeck,

D15083: Use title case for the clipboard button

2018-08-25 Thread Nathaniel Graham
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R166:3d30e3d03ae0: Use title case for the clipboard button (authored by ngraham). REPOSITORY R166 Spectacle CHANGES

[spectacle] /: Use title case for the clipboard button

2018-08-25 Thread Nathaniel Graham
Git commit 3d30e3d03ae0fa616c18eff76632b9a1284a9f89 by Nathaniel Graham. Committed on 25/08/2018 at 17:22. Pushed by ngraham into branch 'master'. Use title case for the clipboard button Summary: Use Title Case for the {nav Copy to Clipboard} button. In this case, it means making the word "to"

D15083: Use title case for the clipboard button

2018-08-25 Thread Pino Toscano
pino added a comment. For the fix itself: you do not need a diff review for this kind of changes, especially for master branches that were recently opened again for development... REPOSITORY R166 Spectacle REVISION DETAIL https://phabricator.kde.org/D15083 To: ngraham, #spectacle,

D15083: Use title case for the clipboard button

2018-08-25 Thread Nathaniel Graham
ngraham updated this revision to Diff 40438. ngraham added a comment. Oops, do that correctly REPOSITORY R166 Spectacle CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15083?vs=40437=40438 BRANCH title-case (branched from master) REVISION DETAIL

D15083: Use title case for the clipboard button

2018-08-25 Thread Nathaniel Graham
ngraham updated this revision to Diff 40437. ngraham added a comment. Rebase on master, not the stable branch REPOSITORY R166 Spectacle CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15083?vs=40436=40437 BRANCH title-case (branched from Applications/18.08) REVISION DETAIL

D15083: Use title case for the clipboard button

2018-08-25 Thread Nathaniel Graham
ngraham planned changes to this revision. ngraham added a comment. OK, will change. Thanks guys! REPOSITORY R166 Spectacle REVISION DETAIL https://phabricator.kde.org/D15083 To: ngraham, #spectacle, #kde_applications, broulik, cfeck, #localization, lueck Cc: pino, yurchor,

D15083: Use title case for the clipboard button

2018-08-25 Thread Pino Toscano
pino added a comment. In D15083#315444 , @ngraham wrote: > In D15083#315441 , @pino wrote: > > > In D15083#315431 , @ngraham wrote: > > > > > Question

D15083: Use title case for the clipboard button

2018-08-25 Thread Nathaniel Graham
ngraham added a comment. In D15083#315441 , @pino wrote: > In D15083#315431 , @ngraham wrote: > > > Question for the localization folks: can I change this string in the stable branch? > > >

D15083: Use title case for the clipboard button

2018-08-25 Thread Pino Toscano
pino added a comment. In D15083#315431 , @ngraham wrote: > Question for the localization folks: can I change this string in the stable branch? There is the string freeze in stable branches. > It's just a capitalization change to one

D15083: Use title case for the clipboard button

2018-08-25 Thread Yuri Chornoivan
yurchor added a comment. In D15083#315431 , @ngraham wrote: > Question for the localization folks: can I change this string in the stable branch? It's just a capitalization change to one letter. Is the policy "no string changes on the stable

D15083: Use title case for the clipboard button

2018-08-25 Thread Nathaniel Graham
ngraham added reviewers: Localization, lueck. ngraham added a comment. Question for the localization folks: can I change this string in the stable branch? It's just a capitalization change to one letter. Is the policy "no string changes on the stable branch no matter what", or is there some

D15083: Use title case for the clipboard button

2018-08-25 Thread Nathaniel Graham
ngraham added reviewers: KDE Applications, broulik, cfeck. REPOSITORY R166 Spectacle REVISION DETAIL https://phabricator.kde.org/D15083 To: ngraham, #spectacle, #kde_applications, broulik, cfeck Cc: kde-doc-english, skadinna

D15083: Use title case for the clipboard button

2018-08-25 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: Spectacle. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. ngraham requested review of this revision. REVISION SUMMARY Use Title Case for the Copy to Clipboard button. In this case, it means making the