D23837: Rename action name to make it consistent with other applications

shubham closed this revision. REPOSITORY R7 Konversation REVISION DETAIL https://phabricator.kde.org/D23837 To: shubham, hein, ngraham Cc: ltoscano, kde-doc-english, gennad, fbampaloukas, skadinna

D23837: Rename action name to make it consistent with other applications

ngraham added a comment. You can land this now, @shubham. REPOSITORY R7 Konversation REVISION DETAIL https://phabricator.kde.org/D23837 To: shubham, hein, ngraham Cc: ltoscano, kde-doc-english, gennad, fbampaloukas, skadinna

D23837: Rename action name to make it consistent with other applications

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R7 Konversation REVISION DETAIL https://phabricator.kde.org/D23837 To: shubham, hein, ngraham Cc: ltoscano, kde-doc-english, gennad, fbampaloukas, skadinna

D23837: Rename action name to make it consistent with other applications

shubham added a comment. @hein @ngraham Ping? REPOSITORY R7 Konversation REVISION DETAIL https://phabricator.kde.org/D23837 To: shubham, hein, ngraham Cc: ltoscano, kde-doc-english, gennad, fbampaloukas, skadinna

D23837: Rename action name to make it consistent with other applications

shubham added a comment. @hein Ping? REPOSITORY R7 Konversation REVISION DETAIL https://phabricator.kde.org/D23837 To: shubham, hein, ngraham Cc: ltoscano, kde-doc-english, gennad, fbampaloukas, skadinna

D23837: Rename action name to make it consistent with other applications

ngraham added a comment. In D23837#529369 , @shubham wrote: > Sorry for inconvenience caused, I thought blocking reviewer means that person can not review any longer Heh, no' it's the opposite. :) It means, "Do not land this patch

D23837: Rename action name to make it consistent with other applications

shubham reopened this revision. shubham added a comment. Sorry for inconvenience caused, I thought blocking reviewer means that person can not review any longer. REPOSITORY R7 Konversation REVISION DETAIL https://phabricator.kde.org/D23837 To: shubham, hein, ngraham Cc: ltoscano,

D23837: Rename action name to make it consistent with other applications

ltoscano added a comment. After accepting, Nate added a blocking reviewer. If you check the logs in this review, the code landed without being accepted. Maybe in such scenarios the review should not be accepted immediately. I'd suggest reverting it and reopening the review. REPOSITORY

D23837: Rename action name to make it consistent with other applications

shubham added a comment. I saw green flag so went for it. You have any suggestions/queries? REPOSITORY R7 Konversation REVISION DETAIL https://phabricator.kde.org/D23837 To: shubham, hein, ngraham Cc: ltoscano, kde-doc-english, gennad, fbampaloukas, skadinna

D23837: Rename action name to make it consistent with other applications

ltoscano added a comment. Wasn't this landed a bit too early? REPOSITORY R7 Konversation REVISION DETAIL https://phabricator.kde.org/D23837 To: shubham, hein, ngraham Cc: ltoscano, kde-doc-english, gennad, fbampaloukas, skadinna

D23837: Rename action name to make it consistent with other applications

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R7:695028fca543: Rename action name to make it consistent with other applications (authored by shubham). REPOSITORY R7

D23837: Rename action name to make it consistent with other applications

ngraham added 1 blocking reviewer(s): hein. ngraham accepted this revision. REPOSITORY R7 Konversation REVISION DETAIL https://phabricator.kde.org/D23837 To: shubham, hein, ngraham Cc: kde-doc-english, gennad, fbampaloukas, skadinna

D23837: Rename action name to make it consistent with other applications

shubham retitled this revision from "Summary: Rename action name to make it consistent with other applications" to "Rename action name to make it consistent with other applications". shubham added reviewers: hein, ngraham. REPOSITORY R7 Konversation REVISION DETAIL