D13450: Add arrow keys to move and resize selection rectangle

ngraham added inline comments. INLINE COMMENTS > index.docbook:154 > + > +You can use the arrow keys to move and adjust > the rectangle. Pressing the arrow keys will slowly move the rectangle. Hold > down the Shift to move in larger increments.

D13450: Add arrow keys to move and resize selection rectangle

sharvey added a comment. In D13450#293854 , @ltoscano wrote: > About the date: that's not the release date, but the date where the document was last updated. Thanks. I corrected it to today's date. REPOSITORY R166 Spectacle REVISION

D13450: Add arrow keys to move and resize selection rectangle

ltoscano added a comment. In D13450#293846 , @sharvey wrote: > In D13450#293781 , @ngraham wrote: > > > There's only one remaining thing to do from my perspective: update the docbook to document

SV: Klondike

3rd try... Från: Kim el Diin Skickat: den 12 juli 2018 12:11 Till: kde-doc-english@kde.org Ämne: Klondike Hi there, When in klondike the arrows have stopped moving the curser , instead just highligting the cards , how do i get back the original setting ?

D13450: Add arrow keys to move and resize selection rectangle

sharvey updated this revision to Diff 37963. sharvey added a comment. Restricted Application added a project: Documentation. Restricted Application added a subscriber: kde-doc-english. - Edit docbook to include arrow key usage; update release number and date REPOSITORY R166 Spectacle

D13450: Add arrow keys to move and resize selection rectangle

sharvey added a comment. In D13450#293781 , @ngraham wrote: > There's only one remaining thing to do from my perspective: update the docbook to document this nice new feature! It would be great if you could do that in this patch. Keep in mind

D13450: Add arrow keys to move and resize selection rectangle

yurchor accepted this revision. REPOSITORY R166 Spectacle REVISION DETAIL https://phabricator.kde.org/D13450 To: sharvey, rkflx, ngraham, #spectacle, yurchor Cc: kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

ngraham added inline comments. INLINE COMMENTS > ngraham wrote in index.docbook:154 > Two sentences use the descriptive mood ("Pressing the arrow keys...", > "Holding the Alt key..."), while the middle one uses the imperative mood > ("Hold down the Shift key..."). We should pick one and be

D13450: Add arrow keys to move and resize selection rectangle

sharvey updated this revision to Diff 37964. sharvey added a comment. - Correct revision date in docbook REPOSITORY R166 Spectacle CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13450?vs=37963=37964 BRANCH arcpatch-D13450 REVISION DETAIL https://phabricator.kde.org/D13450

D13450: Add arrow keys to move and resize selection rectangle

sharvey marked 2 inline comments as done. REPOSITORY R166 Spectacle REVISION DETAIL https://phabricator.kde.org/D13450 To: sharvey, rkflx, ngraham, #spectacle, yurchor Cc: ltoscano, kde-doc-english, abalaji, #spectacle, skadinna

D13450: Add arrow keys to move and resize selection rectangle

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Excellent. @rkflx, any last comments or objections, or shall we push this to the 18.08 branch? REPOSITORY R166 Spectacle BRANCH arcpatch-D13450 REVISION DETAIL

D13450: Add arrow keys to move and resize selection rectangle

sharvey added a comment. In D13450#294047 , @rkflx wrote: > - Selecting with the mouse sets a minimum size, however resizing with the arrow keys allows to resize to 0x0px. Where should it stop? 1x1? REPOSITORY R166 Spectacle REVISION

D13450: Add arrow keys to move and resize selection rectangle

sharvey added a comment. I will attempt to get these completed early tomorrow morning (my time). It's already the end of the day here and I know (from unfortunate experience) that I don't do my best work "after hours". REPOSITORY R166 Spectacle REVISION DETAIL

D13450: Add arrow keys to move and resize selection rectangle

rkflx requested changes to this revision. rkflx added a comment. This revision now requires changes to proceed. @sharvey Thanks for the updates. As always, first I'd like to iterate to get the patch working properly, and then I'll look at the code in detail. As I'm now put under pressure