D23866: Port from KHTML to QtWebEngine

svuorela created this revision. svuorela added reviewers: vkrause, dfaure, carewolf, pino, ltoscano, lbeltrame, lueck, clauschristensen, cordlandwehr. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. svuorela requested review of this revision. REVISION SUMMARY

D23866: Port from KHTML to QtWebEngine

svuorela updated this revision to Diff 65825. svuorela added a comment. Forgot some removed files REPOSITORY R125 KHelpCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23866?vs=65824&id=65825 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23866 AFFECTED FIL

D23866: Port from KHTML to QtWebEngine

ltoscano added a comment. Thanks, you have been fast. Would it be possible to use the QWebEngine-based KPart currently in konqueror.git? REPOSITORY R125 KHelpCenter REVISION DETAIL https://phabricator.kde.org/D23866 To: svuorela, vkrause, dfaure, carewolf, pino, ltoscano, lbeltrame, lue

[konversation] /: Rename action name to make it consistent with other applications

Git commit 695028fca5439d55b959573871549aa6680eb39c by Shubham Jangra. Committed on 11/09/2019 at 09:13. Pushed by shubham into branch 'master'. Rename action name to make it consistent with other applications Reviewers: hein!, ngraham Reviewed By: ngraham Subscribers: kde-doc-english Tags: #d

D23837: Rename action name to make it consistent with other applications

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R7:695028fca543: Rename action name to make it consistent with other applications (authored by shubham). REPOSITORY R7 Ko

D23837: Rename action name to make it consistent with other applications

ltoscano added a comment. Wasn't this landed a bit too early? REPOSITORY R7 Konversation REVISION DETAIL https://phabricator.kde.org/D23837 To: shubham, hein, ngraham Cc: ltoscano, kde-doc-english, gennad, fbampaloukas, skadinna

D23866: Port from KHTML to QtWebEngine

svuorela added a reviewer: mlaurent. svuorela added a comment. Adding Montel because he has experience with locking QtWE down for e.g. mail usage. REPOSITORY R125 KHelpCenter REVISION DETAIL https://phabricator.kde.org/D23866 To: svuorela, vkrause, dfaure, carewolf, pino, ltoscano, lbel

D23866: Port from KHTML to QtWebEngine

svuorela added a comment. In D23866#529334 , @ltoscano wrote: > Thanks, you have been fast. Would it be possible to use the QWebEngine-based KPart currently in konqueror.git? I'm not sure it makes much sense - we aren't doing kpart loadin

D23837: Rename action name to make it consistent with other applications

shubham added a comment. I saw green flag so went for it. You have any suggestions/queries? REPOSITORY R7 Konversation REVISION DETAIL https://phabricator.kde.org/D23837 To: shubham, hein, ngraham Cc: ltoscano, kde-doc-english, gennad, fbampaloukas, skadinna

D23837: Rename action name to make it consistent with other applications

ltoscano added a comment. After accepting, Nate added a blocking reviewer. If you check the logs in this review, the code landed without being accepted. Maybe in such scenarios the review should not be accepted immediately. I'd suggest reverting it and reopening the review. REPOSITORY

[konversation] /: Revert "Rename action name to make it consistent with other applications"

Git commit ba083b9983c19b13999a9733f7c1ec64c5347c8f by Shubham Jangra. Committed on 11/09/2019 at 09:40. Pushed by shubham into branch 'master'. Revert "Rename action name to make it consistent with other applications" This reverts commit 695028fca5439d55b959573871549aa6680eb39c. M +1-1

D23837: Rename action name to make it consistent with other applications

shubham reopened this revision. shubham added a comment. Sorry for inconvenience caused, I thought blocking reviewer means that person can not review any longer. REPOSITORY R7 Konversation REVISION DETAIL https://phabricator.kde.org/D23837 To: shubham, hein, ngraham Cc: ltoscano, kde-do

D23866: Port from KHTML to QtWebEngine

dfaure added a comment. And a lot of the code in the webengine part is about cookies handling, wallet handling, SSL handling, all irrelevant for KHelpCenter. REPOSITORY R125 KHelpCenter REVISION DETAIL https://phabricator.kde.org/D23866 To: svuorela, vkrause, dfaure, carewolf, pino, lto

D23866: Port from KHTML to QtWebEngine

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > mainwindow.cpp:263 > -action->setIcon( QIcon::fromTheme( QStringLiteral("zoom-in") ) ); > -connect( action, &QAction::triggered, this, > &MainWind

D23866: Port from KHTML to QtWebEngine

mlaurent added a comment. You removed font settings dialog. But we can add default font as it: const QFontInfo font(QFontDatabase().systemFont(QFontDatabase::GeneralFont)); settings()->setFontFamily(QWebEngineSettings::StandardFont, font.family()); settings()->setFontSize(QWeb

D23866: Port from KHTML to QtWebEngine

anthonyfieroni added a comment. I think QTextBrowser fits better than WebEngine. REPOSITORY R125 KHelpCenter REVISION DETAIL https://phabricator.kde.org/D23866 To: svuorela, vkrause, dfaure, carewolf, pino, ltoscano, lbeltrame, lueck, clauschristensen, cordlandwehr, mlaurent Cc: anthony

Re: D22799: Adding new .docbook for KAddressBook, draft version

On Tuesday, September 10, 2019 12:38:04 PM CDT Laurent Montel wrote: > mlaurent added a comment. > > > first at all thanks a lot for this documentation. > > What is the problem with ldap server ? > It's not a problem, exactly. I understand that "LDAP" stands for Lightweight Directory Acc

D23837: Rename action name to make it consistent with other applications

ngraham added a comment. In D23837#529369 , @shubham wrote: > Sorry for inconvenience caused, I thought blocking reviewer means that person can not review any longer Heh, no' it's the opposite. :) It means, "Do not land this patch without

D23767: Remove UI options related to window tabbing

gladhorn abandoned this revision. gladhorn added a comment. Merged into parent change. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D23767 To: gladhorn, #kwin Cc: zzag, kwin, kde-doc-english, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, gennad, fbampaloukas, GB_

D23069: Remove disabled TabGroup feature

gladhorn updated this revision to Diff 65885. gladhorn added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. Merged in removal of UI REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23069?vs=65739&id=65885 BRANCH

D23309: Change the document about helping Krusader, add other ways

nmel requested changes to this revision. nmel added a comment. This revision now requires changes to proceed. This diff contains combined changes on two separate repositories. Phabricator will have a problem with this kind of change. Please split into two reviews. I'm ok with the content. RE