D10186: Added a feautre to execute the next task after the previous one finishes.

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R361:9472b36b52cd: Added a feature to execute the next task 
after the previous one finishes. (authored by fmiroslaw, committed by aacid).

REPOSITORY
  R361 KTimer

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10186?vs=26393&id=28643

REVISION DETAIL
  https://phabricator.kde.org/D10186

AFFECTED FILES
  ktimer.cpp
  ktimer.h
  prefwidget.ui

To: fmiroslaw, #kde_applications, kde-utils-devel, aacid
Cc: lueck, kde-doc-english, aacid, bcooksley, kde-utils-devel, alexeymin, 
genaxxx

D10186: Added a feautre to execute the next task after the previous one finishes.

[Albert Astals Cid]

aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  Ok, since noone seems to disagree with this i'll commit it in a minute. 
@fmiroslaw can you please review and comment in @lueck changeset?

REPOSITORY
  R361 KTimer

REVISION DETAIL
  https://phabricator.kde.org/D10186

To: fmiroslaw, #kde_applications, kde-utils-devel, aacid
Cc: lueck, kde-doc-english, aacid, bcooksley, kde-utils-devel, alexeymin, 
genaxxx

D10186: Added a feautre to execute the next task after the previous one finishes.

[Burkhard Lück]

lueck added a comment.


  docbook update https://phabricator.kde.org/D11032

REPOSITORY
  R361 KTimer

REVISION DETAIL
  https://phabricator.kde.org/D10186

To: fmiroslaw, #kde_applications, kde-utils-devel
Cc: lueck, kde-doc-english, aacid, bcooksley, kde-utils-devel, alexeymin, 
genaxxx

D10186: Added a feautre to execute the next task after the previous one finishes.

[Filip Mirosław]

fmiroslaw added a comment.


  In D10186#213921 , @lueck wrote:
  
  > In D10186#213789 , @fmiroslaw 
wrote:
  >
  > > Yes, task2 will start with delay of 1:40 after task1 finishes.
  > >  In second case, task3 will start after task2 finishes. The consecutive 
task is started with the given delay after the task visually above has finished.
  >
  >
  > Thanks for clarifying.
  >  But what if I have the non consecutive task1 and task2 with different 
delays and add a consecutive task3? 
  >  Does task3 start after task1 is finished or after task2 is finished or 
after the task with the longest delay is finished?
  
  
  Task3 will start after task2 finishes, assuming that task2 is the one above 
task3.

REPOSITORY
  R361 KTimer

REVISION DETAIL
  https://phabricator.kde.org/D10186

To: fmiroslaw, #kde_applications, kde-utils-devel
Cc: lueck, kde-doc-english, aacid, bcooksley, kde-utils-devel, alexeymin, 
genaxxx

D10186: Added a feautre to execute the next task after the previous one finishes.

[Burkhard Lück]

lueck added a comment.


  In D10186#213789 , @fmiroslaw 
wrote:
  
  > Yes, task2 will start with delay of 1:40 after task1 finishes.
  >  In second case, task3 will start after task2 finishes. The consecutive 
task is started with the given delay after the task visually above has finished.
  
  
  Thanks for clarifying.
  But what if I have the non consecutive task1 and task2 with different delays 
and add a consecutive task3? 
  Does task3 start after task1 is finished or after task2 is finished or after 
the task with the longest delay is finished?

REPOSITORY
  R361 KTimer

REVISION DETAIL
  https://phabricator.kde.org/D10186

To: fmiroslaw, #kde_applications, kde-utils-devel
Cc: lueck, kde-doc-english, aacid, bcooksley, kde-utils-devel, alexeymin, 
genaxxx

D10186: Added a feautre to execute the next task after the previous one finishes.

[Filip Mirosław]

fmiroslaw added a comment.


  Yes, task2 will start with delay of 1:40 after task1 finishes.

REPOSITORY
  R361 KTimer

REVISION DETAIL
  https://phabricator.kde.org/D10186

To: fmiroslaw, #kde_applications, kde-utils-devel
Cc: lueck, kde-doc-english, aacid, bcooksley, kde-utils-devel, alexeymin, 
genaxxx

D10186: Added a feautre to execute the next task after the previous one finishes.

[Burkhard Lück]

lueck added a comment.


  Some questions regarding the feature "Consecutive"
  
  - add task1 with default delay 1:40
  - add task2 and check "Consecutive task" and now the value in colunm "Delay" 
shows the value 1:40
  
  What is the meaning of the editable value 1:40 and why is this value editable?
  Does task2 start with a delay of 1:40 after task1 is finished?
  
  What if I have the non consecutive task1 and task2 with different delays and 
add a consecutive task3? 
  Does task3 start after task1 is finished or after task2 is finished?

REPOSITORY
  R361 KTimer

REVISION DETAIL
  https://phabricator.kde.org/D10186

To: fmiroslaw, #kde_applications, kde-utils-devel
Cc: lueck, kde-doc-english, aacid, bcooksley, kde-utils-devel, alexeymin, 
genaxxx

D10186: Added a feautre to execute the next task after the previous one finishes.

[Albert Astals Cid]

aacid added a subscriber: kde-doc-english.
aacid added a comment.


  @kde-doc-english Do you think we should update doc/index.docbook to include 
the new option and give it some more "in depth" explanation, like "if you have 
a loop and consecutive", the consective is not run until loop is removed?

REPOSITORY
  R361 KTimer

REVISION DETAIL
  https://phabricator.kde.org/D10186

To: fmiroslaw, #kde_applications, kde-utils-devel
Cc: kde-doc-english, aacid, bcooksley, kde-utils-devel, alexeymin, genaxxx