D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

2018-12-17 Thread Eike Hein 
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:cee5ea7819b2: [kcmkwin/desktop] KCM using new virtual 
desktops DBus interface (authored by hein).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14542?vs=47749=47750

REVISION DETAIL
  https://phabricator.kde.org/D14542

AFFECTED FILES
  kcmkwin/kwindesktop/CMakeLists.txt
  kcmkwin/kwindesktop/Messages.sh
  kcmkwin/kwindesktop/desktop.desktop
  kcmkwin/kwindesktop/desktopnameswidget.cpp
  kcmkwin/kwindesktop/desktopnameswidget.h
  kcmkwin/kwindesktop/desktopsmodel.cpp
  kcmkwin/kwindesktop/desktopsmodel.h
  kcmkwin/kwindesktop/kcm_kwin_virtualdesktops.desktop
  kcmkwin/kwindesktop/main.cpp
  kcmkwin/kwindesktop/main.h
  kcmkwin/kwindesktop/main.ui
  kcmkwin/kwindesktop/package/contents/ui/main.qml
  kcmkwin/kwindesktop/package/metadata.desktop
  kcmkwin/kwindesktop/virtualdesktops.cpp
  kcmkwin/kwindesktop/virtualdesktops.h

To: hein, mart, davidedmundson, ltoscano, zzag, ngraham, #documentation
Cc: yurchor, ngraham, davidedmundson, broulik, plasma-devel, kwin, GB_2, 
mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

2018-12-17 Thread Eike Hein 
hein added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kcm_kwin_virtualdesktops.desktop:6
> please make sure the docs people know about this

Told Luigi about it weeks ago, no worries :)

> yurchor wrote in main.qml:222
> Can this be just "ms"-symbol as in Wikipedia for milliseconds to avoid 
> confusion with plural forms? Thanks.

Sure, I just copied "msec" from the old KCM. Will adjust before pushing.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag, ngraham, #documentation
Cc: yurchor, ngraham, davidedmundson, broulik, plasma-devel, kwin, GB_2, 
mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

2018-12-17 Thread Yuri Chornoivan 
yurchor added inline comments.

INLINE COMMENTS

> main.qml:222
> +
> +textFromValue: function(value, locale) { return i18n("%1 
> msec", value)}
> +

Can this be just "ms"-symbol as in Wikipedia for milliseconds to avoid 
confusion with plural forms? Thanks.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag, ngraham, #documentation
Cc: yurchor, ngraham, davidedmundson, broulik, plasma-devel, kwin, GB_2, 
mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

2018-12-17 Thread Burkhard Lück 
lueck added a reviewer: Documentation.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag, ngraham, #documentation
Cc: ngraham, davidedmundson, broulik, plasma-devel, kwin, GB_2, mkulinski, 
ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart