D17687: Update screenshots of the handbook.

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R358:7c7d2c622573: Update screenshots of the handbook. 
(authored by ognarb).

REPOSITORY
  R358 KGpg

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17687?vs=47890=47892

REVISION DETAIL
  https://phabricator.kde.org/D17687

AFFECTED FILES
  doc/editor.png
  doc/keygen.png
  doc/keyprop.png
  doc/keys.png
  doc/keyserver-search.png
  doc/keyserver.png
  doc/options.png
  doc/select-secret-key.png
  doc/systray.png

To: ognarb, #documentation, yurchor
Cc: dakon, yurchor, kde-utils-devel

D17687: Update screenshots of the handbook.

[Carl Schwan]

ognarb updated this revision to Diff 47890.
ognarb added a comment.


  Display option in keys.png

REPOSITORY
  R358 KGpg

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17687?vs=47889=47890

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17687

AFFECTED FILES
  doc/editor.png
  doc/keygen.png
  doc/keyprop.png
  doc/keys.png
  doc/keyserver-search.png
  doc/keyserver.png
  doc/options.png
  doc/select-secret-key.png
  doc/systray.png

To: ognarb, #documentation, yurchor
Cc: dakon, yurchor, kde-utils-devel

D17687: Update screenshots of the handbook.

[Carl Schwan]

ognarb updated this revision to Diff 47889.
ognarb added a comment.


  Revert change for keymanage.png

REPOSITORY
  R358 KGpg

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17687?vs=47887=47889

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17687

AFFECTED FILES
  doc/editor.png
  doc/keygen.png
  doc/keyprop.png
  doc/keys.png
  doc/keyserver-search.png
  doc/keyserver.png
  doc/options.png
  doc/select-secret-key.png
  doc/systray.png

To: ognarb, #documentation, yurchor
Cc: dakon, yurchor, kde-utils-devel

D17687: Update screenshots of the handbook.

[Rolf Eike Beer]

dakon added inline comments.

INLINE COMMENTS

> ognarb wrote in keymanage.png:1
> @dakon I'm not a GPG expert and it will be a bit difficult for me, maybe I 
> could revert the change on this file and you could push an updated screenshot 
> later. That do you think?

No problem, I can do that.

REPOSITORY
  R358 KGpg

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17687

To: ognarb, #documentation, yurchor
Cc: dakon, yurchor, kde-utils-devel

D17687: Update screenshots of the handbook.

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> dakon wrote in keymanage.png:1
> I would welcome some more things showing up in the new screenshot as it was 
> in the old one: different key trust levels (that's why I had the CA keys in 
> there, which I had signed for that), subids/signatures, also ones without 
> associated key, and the context menu.

@dakon I'm not a GPG expert and it will be a bit difficult for me, maybe I 
could revert the change on this file and you could push an updated screenshot 
later. That do you think?

REPOSITORY
  R358 KGpg

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17687

To: ognarb, #documentation, yurchor
Cc: dakon, yurchor, kde-utils-devel

D17687: Update screenshots of the handbook.

[Rolf Eike Beer]

dakon added inline comments.

INLINE COMMENTS

> keymanage.png:1


I would welcome some more things showing up in the new screenshot as it was in 
the old one: different key trust levels (that's why I had the CA keys in there, 
which I had signed for that), subids/signatures, also ones without associated 
key, and the context menu.

REPOSITORY
  R358 KGpg

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17687

To: ognarb, #documentation, yurchor
Cc: dakon, yurchor, kde-utils-devel

D17687: Update screenshots of the handbook.

[Carl Schwan]

ognarb added a comment.


  If nobody found some other problems, I'm going to push in 2 hours.

REPOSITORY
  R358 KGpg

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17687

To: ognarb, #documentation, yurchor
Cc: dakon, yurchor, kde-utils-devel

D17687: Update screenshots of the handbook.

[Carl Schwan]

ognarb marked an inline comment as done.
ognarb added inline comments.

INLINE COMMENTS

> dakon wrote in keymanage.png:1
> I made sure to have permission from Pino before doing the screenshot. Please 
> make sure you have the permission of the key owners or use mine and Pinos key.

Thanks, didn't cross my mind then I took the screenshot.

REPOSITORY
  R358 KGpg

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17687

To: ognarb, #documentation, yurchor
Cc: dakon, yurchor, kde-utils-devel

D17687: Update screenshots of the handbook.

[Carl Schwan]

ognarb updated this revision to Diff 47887.
ognarb marked an inline comment as done.
ognarb added a comment.


  - Remove some name fron screenshot for keymanage.png
  - Create a smaller screenshot for editor.png

REPOSITORY
  R358 KGpg

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17687?vs=47851=47887

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17687

AFFECTED FILES
  doc/editor.png
  doc/keygen.png
  doc/keymanage.png
  doc/keyprop.png
  doc/keys.png
  doc/keyserver-search.png
  doc/keyserver.png
  doc/options.png
  doc/select-secret-key.png
  doc/systray.png

To: ognarb, #documentation, yurchor
Cc: dakon, yurchor, kde-utils-devel

D17687: Update screenshots of the handbook.

[Rolf Eike Beer]

dakon added inline comments.

INLINE COMMENTS

> editor.png:1


Please try if you can encrypt a shorter text so the vertical space in the 
handbook does not needlessly increase.

> keymanage.png:1


I made sure to have permission from Pino before doing the screenshot. Please 
make sure you have the permission of the key owners or use mine and Pinos key.

REPOSITORY
  R358 KGpg

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17687

To: ognarb, #documentation, yurchor
Cc: dakon, yurchor, kde-utils-devel

D17687: Update screenshots of the handbook.

[Carl Schwan]

ognarb updated this revision to Diff 47851.
ognarb added a comment.


  advpng -z4

REPOSITORY
  R358 KGpg

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17687?vs=47844=47851

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17687

AFFECTED FILES
  doc/editor.png
  doc/keygen.png
  doc/keymanage.png
  doc/keyprop.png
  doc/keys.png
  doc/keyserver-search.png
  doc/keyserver.png
  doc/options.png
  doc/select-secret-key.png
  doc/systray.png

To: ognarb, #documentation, yurchor
Cc: yurchor, kde-utils-devel

D17687: Update screenshots of the handbook.

[Yuri Chornoivan]

yurchor accepted this revision.
yurchor added a comment.


  In D17687#379521 , @ognarb wrote:
  
  > Just to be sure, should I wait for the group reviewer "documentation" to 
approve or directly push this patch.
  
  
  It is obvious that the screenshots were updated correctly. I see no reason 
for not pushing them now.
  
  Just some nitpicks:
  
  1. They can be pushed into Applications/18.12 branch as well.
  2. They can be compressed with advpng -z4 , but it is not a requirement.

REPOSITORY
  R358 KGpg

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17687

To: ognarb, #documentation, yurchor
Cc: yurchor, kde-utils-devel

D17687: Update screenshots of the handbook.

[Carl Schwan]

ognarb added a comment.


  Just to be sure, should I wait for the group reviewer "documentation" to 
approve or directly push this patch.

REPOSITORY
  R358 KGpg

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17687

To: ognarb, #documentation, yurchor
Cc: yurchor, kde-utils-devel

D17687: Update screenshots of the handbook.

[Yuri Chornoivan]

yurchor accepted this revision as: yurchor.
yurchor added a comment.
This revision is now accepted and ready to land.


  Many thanks.

REPOSITORY
  R358 KGpg

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17687

To: ognarb, #documentation, yurchor
Cc: yurchor, kde-utils-devel

D17687: Update screenshots of the handbook.

[Carl Schwan]

ognarb added a reviewer: Documentation.

REPOSITORY
  R358 KGpg

REVISION DETAIL
  https://phabricator.kde.org/D17687

To: ognarb, #documentation
Cc: kde-utils-devel