D23866: Port from KHTML to QtWebEngine

svuorela abandoned this revision. REPOSITORY R125 KHelpCenter REVISION DETAIL https://phabricator.kde.org/D23866 To: svuorela, vkrause, dfaure, carewolf, pino, ltoscano, lbeltrame, lueck, clauschristensen, cordlandwehr, mlaurent Cc: alex, meven, anthonyfieroni, kde-doc-english, gennad, fbam

D23866: Port from KHTML to QtWebEngine

ltoscano added a comment. Laurent kindly took over this, extended and updated this as part of https://invent.kde.org/system/khelpcenter/-/merge_requests/25 (see https://invent.kde.org/system/khelpcenter/-/merge_requests/25/diffs?commit_id=f6d308672a9f68c20585f5d05b6c6032355f850a ) and it was

D23866: Port from KHTML to QtWebEngine

alex added a comment. @meven Would you be interested in taking this over? :) REPOSITORY R125 KHelpCenter REVISION DETAIL https://phabricator.kde.org/D23866 To: svuorela, vkrause, dfaure, carewolf, pino, ltoscano, lbeltrame, lueck, clauschristensen, cordlandwehr, mlaurent Cc: alex, meven

D23866: Port from KHTML to QtWebEngine

meven added a comment. In D23866#557830 , @svuorela wrote: > In D23866#553108 , @mlaurent wrote: > > > Ping ? What is the status ?:) > > > I'll be happy if someone else takes over. I'm still a

D23866: Port from KHTML to QtWebEngine

svuorela added a comment. In D23866#553108 , @mlaurent wrote: > Ping ? What is the status ?:) I'll be happy if someone else takes over. I'm still a bit hung up on other stuff. Don't expect much from me on this before christmas. /Sune R

D23866: Port from KHTML to QtWebEngine

mlaurent added a comment. Ping ? What is the status ?:) REPOSITORY R125 KHelpCenter REVISION DETAIL https://phabricator.kde.org/D23866 To: svuorela, vkrause, dfaure, carewolf, pino, ltoscano, lbeltrame, lueck, clauschristensen, cordlandwehr, mlaurent Cc: anthonyfieroni, kde-doc-english,

D23866: Port from KHTML to QtWebEngine

ltoscano added a comment. Technically I think that an hard dependency on QtWebEngine is a mistake, and that both engines should be available (QTextBrowser too). Sune thinks that this would be not wise. Oh, well. As I don't want to block this right now (but it can be changed later) even if

D23866: Port from KHTML to QtWebEngine

anthonyfieroni added a comment. In D23866#535801 , @svuorela wrote: > I have played a bit around with QTextBrowser, but couldn't get a working result yet. I don't want to block the patch, it was a thinking not a real investigation in cod

D23866: Port from KHTML to QtWebEngine

svuorela added a comment. In D23866#535611 , @mlaurent wrote: > So what is the status of this patch ? I have played a bit around with QTextBrowser, but couldn't get a working result yet. And life kind of happened. REPOSITORY R125

D23866: Port from KHTML to QtWebEngine

mlaurent added a comment. So what is the status of this patch ? REPOSITORY R125 KHelpCenter REVISION DETAIL https://phabricator.kde.org/D23866 To: svuorela, vkrause, dfaure, carewolf, pino, ltoscano, lbeltrame, lueck, clauschristensen, cordlandwehr, mlaurent Cc: anthonyfieroni, kde-doc-

D23866: Port from KHTML to QtWebEngine

anthonyfieroni added a comment. I think QTextBrowser fits better than WebEngine. REPOSITORY R125 KHelpCenter REVISION DETAIL https://phabricator.kde.org/D23866 To: svuorela, vkrause, dfaure, carewolf, pino, ltoscano, lbeltrame, lueck, clauschristensen, cordlandwehr, mlaurent Cc: anthony

D23866: Port from KHTML to QtWebEngine

mlaurent added a comment. You removed font settings dialog. But we can add default font as it: const QFontInfo font(QFontDatabase().systemFont(QFontDatabase::GeneralFont)); settings()->setFontFamily(QWebEngineSettings::StandardFont, font.family()); settings()->setFontSize(QWeb

D23866: Port from KHTML to QtWebEngine

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > mainwindow.cpp:263 > -action->setIcon( QIcon::fromTheme( QStringLiteral("zoom-in") ) ); > -connect( action, &QAction::triggered, this, > &MainWind

D23866: Port from KHTML to QtWebEngine

dfaure added a comment. And a lot of the code in the webengine part is about cookies handling, wallet handling, SSL handling, all irrelevant for KHelpCenter. REPOSITORY R125 KHelpCenter REVISION DETAIL https://phabricator.kde.org/D23866 To: svuorela, vkrause, dfaure, carewolf, pino, lto

D23866: Port from KHTML to QtWebEngine

svuorela added a comment. In D23866#529334 , @ltoscano wrote: > Thanks, you have been fast. Would it be possible to use the QWebEngine-based KPart currently in konqueror.git? I'm not sure it makes much sense - we aren't doing kpart loadin

D23866: Port from KHTML to QtWebEngine

svuorela added a reviewer: mlaurent. svuorela added a comment. Adding Montel because he has experience with locking QtWE down for e.g. mail usage. REPOSITORY R125 KHelpCenter REVISION DETAIL https://phabricator.kde.org/D23866 To: svuorela, vkrause, dfaure, carewolf, pino, ltoscano, lbel

D23866: Port from KHTML to QtWebEngine

ltoscano added a comment. Thanks, you have been fast. Would it be possible to use the QWebEngine-based KPart currently in konqueror.git? REPOSITORY R125 KHelpCenter REVISION DETAIL https://phabricator.kde.org/D23866 To: svuorela, vkrause, dfaure, carewolf, pino, ltoscano, lbeltrame, lue

D23866: Port from KHTML to QtWebEngine

svuorela updated this revision to Diff 65825. svuorela added a comment. Forgot some removed files REPOSITORY R125 KHelpCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23866?vs=65824&id=65825 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23866 AFFECTED FIL

D23866: Port from KHTML to QtWebEngine

svuorela created this revision. svuorela added reviewers: vkrause, dfaure, carewolf, pino, ltoscano, lbeltrame, lueck, clauschristensen, cordlandwehr. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. svuorela requested review of this revision. REVISION SUMMARY