subject:"Re\: Review Request 128912\: Import kcontrol docbooks for code in kio from kde\-runtime master"

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

2016-11-12 Thread Burkhard Lück


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/
---

(Updated Nov. 12, 2016, 2:13 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks and Plasma.


Changes
---

Submitted with commit e0c3945a88fd041f36ff3873f6fe0ca5cfa00158 by Burkhard Lück 
to branch master.


Repository: kio


Description
---

doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
splitted from kde-runtime master using https://github.com/ajdruff/git-splits

Not included in build so far, the docbooks are imported as they were splitted

To be done next:
Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
rename ebrowsing to webshortcuts
reapply a few updates done in plasma-desktop
remove these imported kcontrol docbooks from plasma-desktop
adapt scripty to these changes


Diffs
-

  docs/CMakeLists.txt 350bce3 
  docs/kcontrol5/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/cache/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/cache/index.docbook PRE-CREATION 
  docs/kcontrol5/cookies/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/cookies/index.docbook PRE-CREATION 
  docs/kcontrol5/netpref/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/netpref/index.docbook PRE-CREATION 
  docs/kcontrol5/proxy/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/proxy/index.docbook PRE-CREATION 
  docs/kcontrol5/smb/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/smb/index.docbook PRE-CREATION 
  docs/kcontrol5/trash/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/trash/index.docbook PRE-CREATION 
  docs/kcontrol5/useragent/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/useragent/index.docbook PRE-CREATION 
  docs/kcontrol5/webshortcuts/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/webshortcuts/index.docbook PRE-CREATION 
  src/ioslaves/trash/kcmtrash.desktop c8ff4ac 
  src/kcms/kio/cache.desktop f0bd261 
  src/kcms/kio/cookies.desktop f91b5cd 
  src/kcms/kio/netpref.desktop 963ef3f 
  src/kcms/kio/proxy.desktop c11451d 
  src/kcms/kio/smb.desktop c323614 
  src/kcms/kio/useragent.desktop 856e9cc 
  src/kcms/webshortcuts/webshortcuts.desktop 24fbb2a 

Diff: https://git.reviewboard.kde.org/r/128912/diff/


Testing
---

history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
master


File Attachments


git-log-doc-kcontrol.output
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output
kio-log-docs.txt
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/11/911e5e67-3094-4d47-aa94-95129f5545fe__kio-log-docs.txt


Thanks,

Burkhard Lück

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

2016-11-11 Thread Burkhard Lück


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/
---

(Updated Nov. 11, 2016, 3:39 nachm.)


Review request for Documentation, KDE Frameworks and Plasma.


Repository: kio


Description
---

doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
splitted from kde-runtime master using https://github.com/ajdruff/git-splits

Not included in build so far, the docbooks are imported as they were splitted

To be done next:
Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
rename ebrowsing to webshortcuts
reapply a few updates done in plasma-desktop
remove these imported kcontrol docbooks from plasma-desktop
adapt scripty to these changes


Diffs
-

  docs/CMakeLists.txt 350bce3 
  docs/kcontrol5/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/cache/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/cache/index.docbook PRE-CREATION 
  docs/kcontrol5/cookies/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/cookies/index.docbook PRE-CREATION 
  docs/kcontrol5/netpref/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/netpref/index.docbook PRE-CREATION 
  docs/kcontrol5/proxy/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/proxy/index.docbook PRE-CREATION 
  docs/kcontrol5/smb/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/smb/index.docbook PRE-CREATION 
  docs/kcontrol5/trash/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/trash/index.docbook PRE-CREATION 
  docs/kcontrol5/useragent/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/useragent/index.docbook PRE-CREATION 
  docs/kcontrol5/webshortcuts/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/webshortcuts/index.docbook PRE-CREATION 
  src/ioslaves/trash/kcmtrash.desktop c8ff4ac 
  src/kcms/kio/cache.desktop f0bd261 
  src/kcms/kio/cookies.desktop f91b5cd 
  src/kcms/kio/netpref.desktop 963ef3f 
  src/kcms/kio/proxy.desktop c11451d 
  src/kcms/kio/smb.desktop c323614 
  src/kcms/kio/useragent.desktop 856e9cc 
  src/kcms/webshortcuts/webshortcuts.desktop 24fbb2a 

Diff: https://git.reviewboard.kde.org/r/128912/diff/


Testing
---

history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
master


File Attachments (updated)


git-log-doc-kcontrol.output
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output
kio-log-docs.txt
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/11/911e5e67-3094-4d47-aa94-95129f5545fe__kio-log-docs.txt


Thanks,

Burkhard Lück

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

2016-11-11 Thread Burkhard Lück



> On Nov. 11, 2016, 1:51 nachm., Luigi Toscano wrote:
> > If I understand it correctly, the review include two separate change 
> > (import + fixes), is it correct? Then it's fine by me (pending confirmation 
> > for the shipit), the changes are fine and we can refine it later (better 
> > than the current situation).

Thes are two separate changes, the import + update in one RR, see 
kio-log-docs.txt -> less trouble with scripty


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/#review100778
---


On Nov. 11, 2016, 9:31 vorm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128912/
> ---
> 
> (Updated Nov. 11, 2016, 9:31 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Plasma.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
> doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
> doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
> splitted from kde-runtime master using https://github.com/ajdruff/git-splits
> 
> Not included in build so far, the docbooks are imported as they were splitted
> 
> To be done next:
> Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
> rename ebrowsing to webshortcuts
> reapply a few updates done in plasma-desktop
> remove these imported kcontrol docbooks from plasma-desktop
> adapt scripty to these changes
> 
> 
> Diffs
> -
> 
>   docs/CMakeLists.txt 350bce3 
>   docs/kcontrol5/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/cache/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/cache/index.docbook PRE-CREATION 
>   docs/kcontrol5/cookies/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/cookies/index.docbook PRE-CREATION 
>   docs/kcontrol5/netpref/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/netpref/index.docbook PRE-CREATION 
>   docs/kcontrol5/proxy/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/proxy/index.docbook PRE-CREATION 
>   docs/kcontrol5/smb/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/smb/index.docbook PRE-CREATION 
>   docs/kcontrol5/trash/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/trash/index.docbook PRE-CREATION 
>   docs/kcontrol5/useragent/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/useragent/index.docbook PRE-CREATION 
>   docs/kcontrol5/webshortcuts/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/webshortcuts/index.docbook PRE-CREATION 
>   src/ioslaves/trash/kcmtrash.desktop c8ff4ac 
>   src/kcms/kio/cache.desktop f0bd261 
>   src/kcms/kio/cookies.desktop f91b5cd 
>   src/kcms/kio/netpref.desktop 963ef3f 
>   src/kcms/kio/proxy.desktop c11451d 
>   src/kcms/kio/smb.desktop c323614 
>   src/kcms/kio/useragent.desktop 856e9cc 
>   src/kcms/webshortcuts/webshortcuts.desktop 24fbb2a 
> 
> Diff: https://git.reviewboard.kde.org/r/128912/diff/
> 
> 
> Testing
> ---
> 
> history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
> master
> 
> 
> File Attachments
> 
> 
> git-log-doc-kcontrol.output
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

2016-11-11 Thread Burkhard Lück


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/
---

(Updated Nov. 11, 2016, 9:31 vorm.)


Review request for Documentation, KDE Frameworks and Plasma.


Changes
---

Update import because I misssed the trash kcm docbook
move into existing dir docs using subdir kcontrol5 to make make co-installable, 
adapt CMakeLists.txt, change dtd to kf5
rename ebrowsing to webshortcuts
reapply a few updates done in plasma-desktop
proofread, bump date + releaseinfo
adapt X-DocPath in desktop files


Repository: kio


Description
---

doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
splitted from kde-runtime master using https://github.com/ajdruff/git-splits

Not included in build so far, the docbooks are imported as they were splitted

To be done next:
Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
rename ebrowsing to webshortcuts
reapply a few updates done in plasma-desktop
remove these imported kcontrol docbooks from plasma-desktop
adapt scripty to these changes


Diffs (updated)
-

  docs/CMakeLists.txt 350bce3 
  docs/kcontrol5/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/cache/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/cache/index.docbook PRE-CREATION 
  docs/kcontrol5/cookies/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/cookies/index.docbook PRE-CREATION 
  docs/kcontrol5/netpref/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/netpref/index.docbook PRE-CREATION 
  docs/kcontrol5/proxy/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/proxy/index.docbook PRE-CREATION 
  docs/kcontrol5/smb/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/smb/index.docbook PRE-CREATION 
  docs/kcontrol5/trash/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/trash/index.docbook PRE-CREATION 
  docs/kcontrol5/useragent/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/useragent/index.docbook PRE-CREATION 
  docs/kcontrol5/webshortcuts/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/webshortcuts/index.docbook PRE-CREATION 
  src/ioslaves/trash/kcmtrash.desktop c8ff4ac 
  src/kcms/kio/cache.desktop f0bd261 
  src/kcms/kio/cookies.desktop f91b5cd 
  src/kcms/kio/netpref.desktop 963ef3f 
  src/kcms/kio/proxy.desktop c11451d 
  src/kcms/kio/smb.desktop c323614 
  src/kcms/kio/useragent.desktop 856e9cc 
  src/kcms/webshortcuts/webshortcuts.desktop 24fbb2a 

Diff: https://git.reviewboard.kde.org/r/128912/diff/


Testing
---

history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
master


File Attachments


git-log-doc-kcontrol.output
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output


Thanks,

Burkhard Lück

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

2016-10-17 Thread Luigi Toscano



> On Sept. 15, 2016, 9:28 a.m., Luigi Toscano wrote:
> > Can they be made co-installable with the ones with kde-runtime, as both 
> > modules can be available at the same time? This is the problem of the 
> > missing support for kcontrol5
> > 
> > It was already done some time ago and I had to revert it:
> > https://marc.info/?t=14207454037=1=1
> > https://marc.info/?l=kde-i18n-doc=142076318528227=1
> 
> Burkhard Lück wrote:
> Sure we can make them co-installable, we just need to decide how to do it
> so far in kf5 we install to ${HTML_INSTALL_DIR}/en SUBDIR kcontrol/ = 
> same subdir as kde4/kde-runtime
> all kcontrol docbooks have the same name in kf5 + kde4 except for 
> cddbretrieval (kde4) / cddbretrieval5 (kf5) and ebrowsing (kde4) / 
> webshortcuts (kf5)
> 
> Options for co-installable:
> 
> 1) append a "5" to every kcm docbook name
> 2) install every kcm docbook to SUBDIR kcontrol5
> 
> Both options require mass renaming X-DocPath, CMakeLists.txt, translation 
> catalogs etc.
> 
> For kioslave docbooks we already use SUBDIR kioslave5, so we should use 
> SUBDIR kcontrol5 to keep consistency
> 
> Burkhard Lück wrote:
> Regarding co-installable:
> 
> frameworks/kdelibs4support has docs/kcontrol/kcm_ssl/index.docbook since 
> 5.0.0
> debian testing (stretch) and ubuntu 16.10 (yakkety) install 
> kcm_ssl/index.docbook in
> /usr/share/doc/kde/HTML/en/kcontrol/ from package kde-runtime-data
> and
> /usr/share/doc/HTML/en/kcontrol/ from package libkf5kdelibs4support-data
> i.e. distinguished using an additional subdir "kde" in the install path 
> from package kde-runtime-data
> 
> So we have apparently no conflict in debian based distributions and 
> apparently no conflict in builds from sources (no one complained since 
> frameworks 5.0.0)
> 
> Is this really a conflict in rpm based systems e.g. SuSe, RedHat ?

Yes, it is. Other distributions used the default value, which is 
/usr/share/doc/HTML/.


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/#review99183
---


On Sept. 15, 2016, 11:09 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128912/
> ---
> 
> (Updated Sept. 15, 2016, 11:09 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Plasma.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
> doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
> doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
> splitted from kde-runtime master using https://github.com/ajdruff/git-splits
> 
> Not included in build so far, the docbooks are imported as they were splitted
> 
> To be done next:
> Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
> rename ebrowsing to webshortcuts
> reapply a few updates done in plasma-desktop
> remove these imported kcontrol docbooks from plasma-desktop
> adapt scripty to these changes
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/cache/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cache/index.docbook PRE-CREATION 
>   doc/kcontrol/cookies/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cookies/index.docbook PRE-CREATION 
>   doc/kcontrol/ebrowsing/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/ebrowsing/index.docbook PRE-CREATION 
>   doc/kcontrol/netpref/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/netpref/index.docbook PRE-CREATION 
>   doc/kcontrol/proxy/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/proxy/index.docbook PRE-CREATION 
>   doc/kcontrol/smb/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/smb/index.docbook PRE-CREATION 
>   doc/kcontrol/useragent/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/useragent/index.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128912/diff/
> 
> 
> Testing
> ---
> 
> history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
> master
> 
> 
> File Attachments
> 
> 
> git-log-doc-kcontrol.output
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

2016-10-17 Thread Marco Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/#review100078
---


Ship it!




Ship It!

- Marco Martin


On Sept. 15, 2016, 9:09 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128912/
> ---
> 
> (Updated Sept. 15, 2016, 9:09 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Plasma.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
> doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
> doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
> splitted from kde-runtime master using https://github.com/ajdruff/git-splits
> 
> Not included in build so far, the docbooks are imported as they were splitted
> 
> To be done next:
> Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
> rename ebrowsing to webshortcuts
> reapply a few updates done in plasma-desktop
> remove these imported kcontrol docbooks from plasma-desktop
> adapt scripty to these changes
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/cache/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cache/index.docbook PRE-CREATION 
>   doc/kcontrol/cookies/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cookies/index.docbook PRE-CREATION 
>   doc/kcontrol/ebrowsing/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/ebrowsing/index.docbook PRE-CREATION 
>   doc/kcontrol/netpref/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/netpref/index.docbook PRE-CREATION 
>   doc/kcontrol/proxy/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/proxy/index.docbook PRE-CREATION 
>   doc/kcontrol/smb/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/smb/index.docbook PRE-CREATION 
>   doc/kcontrol/useragent/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/useragent/index.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128912/diff/
> 
> 
> Testing
> ---
> 
> history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
> master
> 
> 
> File Attachments
> 
> 
> git-log-doc-kcontrol.output
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

2016-09-15 Thread Burkhard Lück



> On Sept. 15, 2016, 11:11 vorm., Marco Martin wrote:
> > doc/kcontrol/cache/index.docbook, line 19
> > 
> >
> > shouldn't it be updated as well?

see my description
the docbooks are imported as they were splitted from kde-runtime, any other 
necessary changes/updates will happen in a separate RRs/commits
That way we can distinguish what was imported from the source repo and what was 
changed in the target repo so we have a much clearer history


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/#review99205
---


On Sept. 15, 2016, 9:09 vorm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128912/
> ---
> 
> (Updated Sept. 15, 2016, 9:09 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Plasma.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
> doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
> doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
> splitted from kde-runtime master using https://github.com/ajdruff/git-splits
> 
> Not included in build so far, the docbooks are imported as they were splitted
> 
> To be done next:
> Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
> rename ebrowsing to webshortcuts
> reapply a few updates done in plasma-desktop
> remove these imported kcontrol docbooks from plasma-desktop
> adapt scripty to these changes
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/cache/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cache/index.docbook PRE-CREATION 
>   doc/kcontrol/cookies/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cookies/index.docbook PRE-CREATION 
>   doc/kcontrol/ebrowsing/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/ebrowsing/index.docbook PRE-CREATION 
>   doc/kcontrol/netpref/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/netpref/index.docbook PRE-CREATION 
>   doc/kcontrol/proxy/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/proxy/index.docbook PRE-CREATION 
>   doc/kcontrol/smb/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/smb/index.docbook PRE-CREATION 
>   doc/kcontrol/useragent/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/useragent/index.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128912/diff/
> 
> 
> Testing
> ---
> 
> history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
> master
> 
> 
> File Attachments
> 
> 
> git-log-doc-kcontrol.output
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

2016-09-15 Thread Marco Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/#review99205
---




doc/kcontrol/cache/index.docbook (line 19)


shouldn't it be updated as well?


- Marco Martin


On Sept. 15, 2016, 9:09 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128912/
> ---
> 
> (Updated Sept. 15, 2016, 9:09 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Plasma.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
> doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
> doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
> splitted from kde-runtime master using https://github.com/ajdruff/git-splits
> 
> Not included in build so far, the docbooks are imported as they were splitted
> 
> To be done next:
> Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
> rename ebrowsing to webshortcuts
> reapply a few updates done in plasma-desktop
> remove these imported kcontrol docbooks from plasma-desktop
> adapt scripty to these changes
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/cache/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cache/index.docbook PRE-CREATION 
>   doc/kcontrol/cookies/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cookies/index.docbook PRE-CREATION 
>   doc/kcontrol/ebrowsing/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/ebrowsing/index.docbook PRE-CREATION 
>   doc/kcontrol/netpref/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/netpref/index.docbook PRE-CREATION 
>   doc/kcontrol/proxy/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/proxy/index.docbook PRE-CREATION 
>   doc/kcontrol/smb/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/smb/index.docbook PRE-CREATION 
>   doc/kcontrol/useragent/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/useragent/index.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128912/diff/
> 
> 
> Testing
> ---
> 
> history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
> master
> 
> 
> File Attachments
> 
> 
> git-log-doc-kcontrol.output
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

8 matches

Site Navigation

Mail list logo

Footer information