Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

2016-09-26 Thread Ralf Habacker 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128969/
---

(Updated Sept. 27, 2016, 6:44 a.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks and Luigi Toscano.


Changes
---

Submitted with commit cbfaec415ea8fd3d0c6182de087763d6280f3aae by Ralf Habacker 
to branch master.


Repository: kdoctools


Description
---

Add cross compiling support for docbookl10nhelper.


Diffs
-

  CMakeLists.txt 3394d4a6091ae79ab1d81345318ba879cc15b909 
  KF5DocToolsConfig.cmake.in 9224fd2788aee5db4340cd0ac8115c1a06ca8ebe 
  src/CMakeLists.txt 48b61e95b0ec9f0b19dd312cc7bd805f9dd58fd2 

Diff: https://git.reviewboard.kde.org/r/128969/diff/


Testing
---

compiled at 
https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools


Thanks,

Ralf Habacker

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

2016-09-26 Thread Ralf Habacker 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128969/
---

(Updated Sept. 26, 2016, 4:16 nachm.)


Review request for Documentation, KDE Frameworks and Luigi Toscano.


Repository: kdoctools


Description
---

Add cross compiling support for docbookl10nhelper.


Diffs (updated)
-

  CMakeLists.txt 3394d4a6091ae79ab1d81345318ba879cc15b909 
  KF5DocToolsConfig.cmake.in 9224fd2788aee5db4340cd0ac8115c1a06ca8ebe 
  src/CMakeLists.txt 48b61e95b0ec9f0b19dd312cc7bd805f9dd58fd2 

Diff: https://git.reviewboard.kde.org/r/128969/diff/


Testing
---

compiled at 
https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools


Thanks,

Ralf Habacker

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

2016-09-26 Thread Luigi Toscano 


> On Sept. 21, 2016, 1:52 p.m., Luigi Toscano wrote:
> > src/CMakeLists.txt, line 173
> > 
> >
> > docbookl10nhelper is not meant to be installed
> 
> Ralf Habacker wrote:
> To cross compile kdoctools for windows on e.g. linux native running tools 
> like meinproc5, docbookl10nhelper and checkXML5 are required. On 
> bootstrapping cross compile these native tools are created and packaged 
> together in a packages named mingwXX-cross-kf5-tools like similar cross 
> helper tools for example mingw32-cross-gcc.
> 
> Luigi Toscano wrote:
> Uhm, but normally we don't need it - can't this installation be done 
> under some condition, so that the default is not changed?
> 
> Ralf Habacker wrote:
> Sonnet for example installs similar tools 'parsetrigrams' and  
> 'gentrigrams' also unconditional. On opensuse they are packaged as part of 
> the development package. see 
> https://build.opensuse.org/package/view_file/KDE:Frameworks5/sonnet/sonnet.spec?expand=1
>  line 134,135.
> 
> If this is an absolute nogo there would be still the choice to use a 
> specific configure time switch like INSTALL_ALL or similar ?
> 
> Luigi Toscano wrote:
> docbookl10nhelper only exists because I was unable to do the same tasks 
> with cmake (or maybe it's just not possible). So it's really part of the 
> compilation system.
> 
> My comment is not an "absolute no go" to this change, it's a "I'm fine if 
> it does not change the default behavior". For example mainproc5 can be 
> compiled without bz2 support *only* for internal usage on our server for 
> documentation, but it's not the default and it's clearly marked as such.
> 
> Ralf Habacker wrote:
> kdoctools is configured with MEINPROC_NO_KARCHIVE supporting this special 
> case, which like very meinproc specific. Because there are at least three kf5 
> related packages (kdoctools, ktexteditor and sonnet) which requires to 
> install internal tools I suggest to add 
> 
> option(INSTALL_INTERNAL_TOOLS ...) 
> 
> to the mentioned packages and to install internals tools only if set. I 
> would update this and create related review requests.

Yes, thank you. I was not suggesting to use MEINPROC_NO_ARCHIVE, it was only an 
example of special behavior tailored for a special case, which does not affect 
the default.


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128969/#review99351
---


On Sept. 21, 2016, 11:43 a.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128969/
> ---
> 
> (Updated Sept. 21, 2016, 11:43 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Add cross compiling support for docbookl10nhelper.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
> 
> Diff: https://git.reviewboard.kde.org/r/128969/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

2016-09-26 Thread Ralf Habacker 


> On Sept. 21, 2016, 1:52 nachm., Luigi Toscano wrote:
> > src/CMakeLists.txt, line 173
> > 
> >
> > docbookl10nhelper is not meant to be installed
> 
> Ralf Habacker wrote:
> To cross compile kdoctools for windows on e.g. linux native running tools 
> like meinproc5, docbookl10nhelper and checkXML5 are required. On 
> bootstrapping cross compile these native tools are created and packaged 
> together in a packages named mingwXX-cross-kf5-tools like similar cross 
> helper tools for example mingw32-cross-gcc.
> 
> Luigi Toscano wrote:
> Uhm, but normally we don't need it - can't this installation be done 
> under some condition, so that the default is not changed?
> 
> Ralf Habacker wrote:
> Sonnet for example installs similar tools 'parsetrigrams' and  
> 'gentrigrams' also unconditional. On opensuse they are packaged as part of 
> the development package. see 
> https://build.opensuse.org/package/view_file/KDE:Frameworks5/sonnet/sonnet.spec?expand=1
>  line 134,135.
> 
> If this is an absolute nogo there would be still the choice to use a 
> specific configure time switch like INSTALL_ALL or similar ?
> 
> Luigi Toscano wrote:
> docbookl10nhelper only exists because I was unable to do the same tasks 
> with cmake (or maybe it's just not possible). So it's really part of the 
> compilation system.
> 
> My comment is not an "absolute no go" to this change, it's a "I'm fine if 
> it does not change the default behavior". For example mainproc5 can be 
> compiled without bz2 support *only* for internal usage on our server for 
> documentation, but it's not the default and it's clearly marked as such.

kdoctools is configured with MEINPROC_NO_KARCHIVE supporting this special case, 
which like very meinproc specific. Because there are at least three kf5 related 
packages (kdoctools, ktexteditor and sonnet) which requires to install internal 
tools I suggest to add 

option(INSTALL_INTERNAL_TOOLS ...) 

to the mentioned packages and to install internals tools only if set. I would 
update this and create related review requests.


- Ralf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128969/#review99351
---


On Sept. 21, 2016, 11:43 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128969/
> ---
> 
> (Updated Sept. 21, 2016, 11:43 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Add cross compiling support for docbookl10nhelper.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
> 
> Diff: https://git.reviewboard.kde.org/r/128969/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

2016-09-21 Thread Luigi Toscano 


> On Sept. 21, 2016, 1:52 p.m., Luigi Toscano wrote:
> > src/CMakeLists.txt, line 173
> > 
> >
> > docbookl10nhelper is not meant to be installed
> 
> Ralf Habacker wrote:
> To cross compile kdoctools for windows on e.g. linux native running tools 
> like meinproc5, docbookl10nhelper and checkXML5 are required. On 
> bootstrapping cross compile these native tools are created and packaged 
> together in a packages named mingwXX-cross-kf5-tools like similar cross 
> helper tools for example mingw32-cross-gcc.
> 
> Luigi Toscano wrote:
> Uhm, but normally we don't need it - can't this installation be done 
> under some condition, so that the default is not changed?
> 
> Ralf Habacker wrote:
> Sonnet for example installs similar tools 'parsetrigrams' and  
> 'gentrigrams' also unconditional. On opensuse they are packaged as part of 
> the development package. see 
> https://build.opensuse.org/package/view_file/KDE:Frameworks5/sonnet/sonnet.spec?expand=1
>  line 134,135.
> 
> If this is an absolute nogo there would be still the choice to use a 
> specific configure time switch like INSTALL_ALL or similar ?

docbookl10nhelper only exists because I was unable to do the same tasks with 
cmake (or maybe it's just not possible). So it's really part of the compilation 
system.

My comment is not an "absolute no go" to this change, it's a "I'm fine if it 
does not change the default behavior". For example mainproc5 can be compiled 
without bz2 support *only* for internal usage on our server for documentation, 
but it's not the default and it's clearly marked as such.


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128969/#review99351
---


On Sept. 21, 2016, 11:43 a.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128969/
> ---
> 
> (Updated Sept. 21, 2016, 11:43 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Add cross compiling support for docbookl10nhelper.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
> 
> Diff: https://git.reviewboard.kde.org/r/128969/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

2016-09-21 Thread Ralf Habacker 


> On Sept. 21, 2016, 1:52 nachm., Luigi Toscano wrote:
> > src/CMakeLists.txt, line 173
> > 
> >
> > docbookl10nhelper is not meant to be installed
> 
> Ralf Habacker wrote:
> To cross compile kdoctools for windows on e.g. linux native running tools 
> like meinproc5, docbookl10nhelper and checkXML5 are required. On 
> bootstrapping cross compile these native tools are created and packaged 
> together in a packages named mingwXX-cross-kf5-tools like similar cross 
> helper tools for example mingw32-cross-gcc.
> 
> Luigi Toscano wrote:
> Uhm, but normally we don't need it - can't this installation be done 
> under some condition, so that the default is not changed?

Sonnet for example installs similar tools 'parsetrigrams' and  'gentrigrams' 
also unconditional. On opensuse they are packaged as part of the development 
package. see 
https://build.opensuse.org/package/view_file/KDE:Frameworks5/sonnet/sonnet.spec?expand=1
 line 134,135.

If this is an absolute nogo there would be still the choice to use a specific 
configure time switch like INSTALL_ALL or similar ?


- Ralf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128969/#review99351
---


On Sept. 21, 2016, 11:43 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128969/
> ---
> 
> (Updated Sept. 21, 2016, 11:43 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Add cross compiling support for docbookl10nhelper.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
> 
> Diff: https://git.reviewboard.kde.org/r/128969/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

2016-09-21 Thread Luigi Toscano 


> On Sept. 21, 2016, 1:52 p.m., Luigi Toscano wrote:
> > src/CMakeLists.txt, line 173
> > 
> >
> > docbookl10nhelper is not meant to be installed
> 
> Ralf Habacker wrote:
> To cross compile kdoctools for windows on e.g. linux native running tools 
> like meinproc5, docbookl10nhelper and checkXML5 are required. On 
> bootstrapping cross compile these native tools are created and packaged 
> together in a packages named mingwXX-cross-kf5-tools like similar cross 
> helper tools for example mingw32-cross-gcc.

Uhm, but normally we don't need it - can't this installation be done under some 
condition, so that the default is not changed?


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128969/#review99351
---


On Sept. 21, 2016, 11:43 a.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128969/
> ---
> 
> (Updated Sept. 21, 2016, 11:43 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Add cross compiling support for docbookl10nhelper.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
> 
> Diff: https://git.reviewboard.kde.org/r/128969/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

2016-09-21 Thread Ralf Habacker 


> On Sept. 21, 2016, 1:52 nachm., Luigi Toscano wrote:
> > src/CMakeLists.txt, line 173
> > 
> >
> > docbookl10nhelper is not meant to be installed

To cross compile kdoctools for windows on e.g. linux native running tools like 
meinproc5, docbookl10nhelper and checkXML5 are required. On bootstrapping cross 
compile these native tools are created and packaged together in a packages 
named mingwXX-cross-kf5-tools like similar cross helper tools for example 
mingw32-cross-gcc.


- Ralf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128969/#review99351
---


On Sept. 21, 2016, 11:43 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128969/
> ---
> 
> (Updated Sept. 21, 2016, 11:43 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Add cross compiling support for docbookl10nhelper.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
> 
> Diff: https://git.reviewboard.kde.org/r/128969/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

2016-09-21 Thread Luigi Toscano 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128969/#review99351
---




src/CMakeLists.txt (line 173)


docbookl10nhelper is not meant to be installed


- Luigi Toscano


On Sept. 21, 2016, 11:43 a.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128969/
> ---
> 
> (Updated Sept. 21, 2016, 11:43 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Add cross compiling support for docbookl10nhelper.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
> 
> Diff: https://git.reviewboard.kde.org/r/128969/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>