Re: Review Request 128936: Update Spectacle docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128936/
---

(Updated Sept. 18, 2016, 7:27 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Graphics and Boudhayan Gupta.


Changes
---

Submitted with commit 118bcd8a9a4c6c89445a589fa990d15ec9223099 by Burkhard Lück 
to branch master.


Repository: spectacle


Description
---

prefer folder over directory
fix some gui strings
fix delay increment
add applications options settings


Diffs
-

  doc/index.docbook 2954541 

Diff: https://git.reviewboard.kde.org/r/128936/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

Re: Review Request 128936: Update Spectacle docbook

[Boudhayan Gupta]

> On Sept. 19, 2016, 12:20 a.m., Boudhayan Gupta wrote:
> > Ship It!

Thank a ton for doing this, I've been procrastinating far too long. :-)


- Boudhayan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128936/#review99259
---


On Sept. 18, 2016, 10:12 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128936/
> ---
> 
> (Updated Sept. 18, 2016, 10:12 p.m.)
> 
> 
> Review request for Documentation, KDE Graphics and Boudhayan Gupta.
> 
> 
> Repository: spectacle
> 
> 
> Description
> ---
> 
> prefer folder over directory
> fix some gui strings
> fix delay increment
> add applications options settings
> 
> 
> Diffs
> -
> 
>   doc/index.docbook 2954541 
> 
> Diff: https://git.reviewboard.kde.org/r/128936/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128936: Update Spectacle docbook

[Boudhayan Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128936/#review99259
---


Ship it!




Ship It!

- Boudhayan Gupta


On Sept. 18, 2016, 10:12 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128936/
> ---
> 
> (Updated Sept. 18, 2016, 10:12 p.m.)
> 
> 
> Review request for Documentation, KDE Graphics and Boudhayan Gupta.
> 
> 
> Repository: spectacle
> 
> 
> Description
> ---
> 
> prefer folder over directory
> fix some gui strings
> fix delay increment
> add applications options settings
> 
> 
> Diffs
> -
> 
>   doc/index.docbook 2954541 
> 
> Diff: https://git.reviewboard.kde.org/r/128936/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128936: Update Spectacle docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128936/
---

(Updated Sept. 18, 2016, 4:42 nachm.)


Review request for Documentation, KDE Graphics and Boudhayan Gupta.


Changes
---

fix issues spotted by Yuri and Boudhayan


Repository: spectacle


Description
---

prefer folder over directory
fix some gui strings
fix delay increment
add applications options settings


Diffs (updated)
-

  doc/index.docbook 2954541 

Diff: https://git.reviewboard.kde.org/r/128936/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

Re: Review Request 128936: Update Spectacle docbook

[Boudhayan Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128936/#review99254
---




doc/index.docbook (line 150)


It can be set in increments of 0.1 seconds, but you have to type it in. The 
buttons only increment/decrement by a whole second.


- Boudhayan Gupta


On Sept. 18, 2016, 6:54 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128936/
> ---
> 
> (Updated Sept. 18, 2016, 6:54 p.m.)
> 
> 
> Review request for Documentation, KDE Graphics and Boudhayan Gupta.
> 
> 
> Repository: spectacle
> 
> 
> Description
> ---
> 
> prefer folder over directory
> fix some gui strings
> fix delay increment
> add applications options settings
> 
> 
> Diffs
> -
> 
>   doc/index.docbook 2954541 
> 
> Diff: https://git.reviewboard.kde.org/r/128936/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128936: Update Spectacle docbook

[Yuri Chornoivan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128936/#review99253
---




doc/index.docbook (line 222)


Typo: Option -> Options


- Yuri Chornoivan


On Вер. 18, 2016, 1:24 після полудня, Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128936/
> ---
> 
> (Updated Вер. 18, 2016, 1:24 після полудня)
> 
> 
> Review request for Documentation, KDE Graphics and Boudhayan Gupta.
> 
> 
> Repository: spectacle
> 
> 
> Description
> ---
> 
> prefer folder over directory
> fix some gui strings
> fix delay increment
> add applications options settings
> 
> 
> Diffs
> -
> 
>   doc/index.docbook 2954541 
> 
> Diff: https://git.reviewboard.kde.org/r/128936/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Review Request 128936: Update Spectacle docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128936/
---

Review request for Documentation, KDE Graphics and Boudhayan Gupta.


Repository: spectacle


Description
---

prefer folder over directory
fix some gui strings
fix delay increment
add applications options settings


Diffs
-

  doc/index.docbook 2954541 

Diff: https://git.reviewboard.kde.org/r/128936/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück