Re: Review Request: libinqt5 - Windows fixes

2012-08-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105867/#review16877 --- Thanks for looking at the Windows build of KDE Frameworks!

Re: Review Request: KF5 - Q_OS_* not defined

2012-08-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105868/#review16878 --- Ship it! Ah, yes, this is a porting error. KDE4 cmake stuff

Re: Review Request: Don't lose the original CMAKE_MODULE_PATH

2012-08-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105863/#review16879 --- tier2/kconfig/CMakeLists.txt

Re: More work available

2012-08-05 Thread David Faure
On Saturday 04 August 2012 09:41:28 Kevin Ottens wrote: On Saturday 04 August 2012 00:52:16 David Faure wrote: On Friday 03 August 2012 13:57:54 Jeremy Whiting wrote: Hey David, I started taking a stab at the KApplication - QApplication fix/conversions, then pulled and can't build

Re: Review Request: Make kcodecs framework build standalone

2012-08-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105860/ --- (Updated Aug. 5, 2012, 9:22 a.m.) Review request for KDE Frameworks and

Re: Review Request: Don't lose the original CMAKE_MODULE_PATH

2012-08-05 Thread Patrick Spendrin
On Aug. 5, 2012, 9:12 a.m., David Faure wrote: tier2/kconfig/CMakeLists.txt, line 7 http://git.reviewboard.kde.org/r/105863/diff/1/?file=76038#file76038line7 Ah, damn, there are conflicting goals here. We removed ${CMAKE_MODULE_PATH} on purpose so that each framework

Re: Review Request: remove FindLibLZMA.cmake from karchive framework

2012-08-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105866/ --- (Updated Aug. 5, 2012, 9:43 a.m.) Review request for KDE Frameworks,

Re: More work available

2012-08-05 Thread Jeremy Whiting
I think I mistakenly started building master branch somehow which put a bunch of generated files in my source tree. I think what he meant to document in the wiki was the way to find out if /usr/include headers were mistakenly being found (make VERBOSE=1) but since that's not supposed to happen,

Re: Review Request: Don't lose the original CMAKE_MODULE_PATH

2012-08-05 Thread Alexander Neundorf
On Aug. 5, 2012, 9:12 a.m., David Faure wrote: tier2/kconfig/CMakeLists.txt, line 7 http://git.reviewboard.kde.org/r/105863/diff/1/?file=76038#file76038line7 Ah, damn, there are conflicting goals here. We removed ${CMAKE_MODULE_PATH} on purpose so that each framework

Re: Review Request: remove FindLibLZMA.cmake from karchive framework

2012-08-05 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105866/#review16896 --- Where have you seen this ? CMake 2.8.8 does not, and 2.8.9 has

ECM and FindFoo.cmake files

2012-08-05 Thread George Goldberg
Hi, What is the policy on moving FindFoo.cmake files from frameworks to ECM or upstream. In particular, I have found the following ones still existing in the various tier1 and tier2 migrated frameworks: kcoreaddons --FindFAM.cmake kidletime --FindX11.cmake --FindX11XCB.cmake --FindXCB.cmake