Re: Review Request 107973: Cleanup : Move all gesture facilities of KAction in KGestureMap

2013-01-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107973/#review25562 --- Ship it! Looks good! You can commit, thanks. - Kevin Ottens

Re: Review Request 107973: Cleanup : Move all gesture facilities of KAction in KGestureMap

2013-01-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107973/#review25561 --- Ship it! Looks good! You can commit, thanks. - Kevin Ottens

Re: Review Request 107973: Cleanup : Move all gesture facilities of KAction in KGestureMap

2013-01-14 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107973/ --- (Updated Jan. 14, 2013, 11:18 p.m.) Review request for KDE Frameworks and

Re: Review Request 107973: Cleanup : Move all gesture facilities of KAction in KGestureMap

2013-01-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107973/#review25523 --- It's really getting close now. Mostly comments on the coding st

Re: Qt 5 (Re: [kdelibs/frameworks] kdeui/tests: Remove QEXPECT_FAIL for MR 43915)

2013-01-14 Thread Albert Astals Cid
El Dilluns, 14 de gener de 2013, a les 14:37:49, David Faure va escriure: > On Sunday 13 January 2013 14:21:05 Jon Severinsson wrote: > > I was under the impression that dropping Qt4 support was in favour of Qt5 > > released tarballs, eg that we would support both latest 5.0.x and 5.1-git > > (curr

Re: Review Request 108385: Reduce risk of timeout and race condition in KPtyProcessTest

2013-01-14 Thread Oswald Buddenhagen
> On Jan. 13, 2013, 6:45 p.m., Oswald Buddenhagen wrote: > > and why exactly do you sleep instead of looping with waitforreadyread? > > Jon Severinsson wrote: > Because that would be an (almost) busy-loop (there are already *some* > data, so waitForReadyRead could return before the timeout)

Re: Review Request 108385: Reduce risk of timeout and race condition in KPtyProcessTest

2013-01-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108385/#review25500 --- This review has been submitted with commit 21cd5afbbaac2737742

Re: Review Request 108385: Reduce risk of timeout and race condition in KPtyProcessTest

2013-01-14 Thread Jon Severinsson
> On Jan. 13, 2013, 6:45 p.m., Oswald Buddenhagen wrote: > > and why exactly do you sleep instead of looping with waitforreadyread? > > Jon Severinsson wrote: > Because that would be an (almost) busy-loop (there are already *some* > data, so waitForReadyRead could return before the timeout)

Re: Review Request 108389: Respect the HOME environment variable

2013-01-14 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/ --- (Updated Jan. 14, 2013, 3:59 p.m.) Review request for KDE Frameworks. Ch

Qt 5 (Re: [kdelibs/frameworks] kdeui/tests: Remove QEXPECT_FAIL for MR 43915)

2013-01-14 Thread David Faure
On Sunday 13 January 2013 14:21:05 Jon Severinsson wrote: > I was under the impression that dropping Qt4 support was in favour of Qt5 > released tarballs, eg that we would support both latest 5.0.x and 5.1-git > (currently dev, eventually stable) for a while (ie until 5.1.0-rc1). I'm > currently ru

Re: Review Request 108389: Respect the HOME environment variable

2013-01-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/#review25459 --- Eek, that's 5 duplicates of the same 4 lines of code. Can't thi