Re: CMake usage requirements in KDE Frameworks

2013-03-24 Thread Stephen Kelly
Alexander Neundorf wrote: currently this breaks the stand-alone build of the libraries in tier1/ and tier2/. http://quickgit.kde.org/?p=kdelibs.gita=commitdiffh=56d571a223e00ffed4cb682eb098c5b1e347fa70 E.g. due to removing include_directories(${kdeqt5staging_INCLUDE_DIRS}) from

Re: Review Request 109551: port KPtyProcess to QProcess

2013-03-24 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/#review29802 --- after extensive deliberation of the code i found that ... i

Re: CMake usage requirements in KDE Frameworks

2013-03-24 Thread Stephen Kelly
Alexander Neundorf wrote: That superbuild directory doesn't seem to work for me. Although I run cmake on it with cmake master, it seems to try to use cmake 2.8.9 from my distro when building the subprojects. Hmm, for me it works as expected. What exactly did you do ? The problem was that

Re: Review Request 109517: Port away from KListWidget to QListWidget

2013-03-24 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109517/#review29819 --- Given that autoselect is disabled by default I'd say it's ok