Re: Review Request 110974: Move KToolBarLabelAction to KWidgetsAddons

2013-06-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110974/#review34332 --- Ship it! Ship It! - Kevin Ottens On June 12, 2013, 1:06

Re: Review Request 111002: Move kviewstatemainteiner to KConfigWidgets

2013-06-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111002/#review34334 --- Indeed kviewstatesaver.h should go in KDE4Support instead of

Re: Review Request 110995: move jobs from kdeui to kjobswidgets framework

2013-06-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110995/#review34335 --- OK, this one is way too big. Could you please upload that as

Re: Review Request 110997: Move KPageWidgets and KPageDialog to KWidgets

2013-06-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110997/#review34336 --- I agree with the previous comment. It would have been better

Re: Review Request 110997: Move KPageWidgets and KPageDialog to KWidgets

2013-06-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110997/ --- (Updated June 14, 2013, 10:27 a.m.) Review request for KDE Frameworks.

Re: Review Request 110974: Move KToolBarLabelAction to KWidgetsAddons

2013-06-14 Thread Benjamin Port
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110974/ --- (Updated June 14, 2013, 11:16 a.m.) Status -- This change has been

Re: Review Request 110876: Port time_t to QDateTime in Loader, KHTMLPart and DocumentImpl (KHTML)

2013-06-14 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110876/ --- (Updated June 14, 2013, 11:38 a.m.) Review request for KDE Frameworks.

Re: Review Request 110876: Port time_t to QDateTime in Loader, KHTMLPart and DocumentImpl (KHTML)

2013-06-14 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110876/ --- (Updated June 14, 2013, 11:51 a.m.) Status -- This change has been

Re: Review Request 110983: Move KToolBarPopupAction to KWidgetsAddons

2013-06-14 Thread Benjamin Port
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110983/ --- (Updated June 14, 2013, 11:55 a.m.) Status -- This change has been

Re: Review Request 110995: move jobs from kdeui to kjobswidgets framework

2013-06-14 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110995/ --- (Updated June 14, 2013, 2:11 p.m.) Review request for KDE Frameworks,

kxerrorhandler duplicate

2013-06-14 Thread Benjamin Port
In the kdeui crumble I'm currently on: KWindowsSystem, there is a task for ./util/kxerrorhandler.h but KWindowsSystem have already one kxerrorhandler. So I don't know what I need to do. The 2 files are really similar only one deprecated constructor is present in the file present in kdeui. And

Re: kxerrorhandler duplicate

2013-06-14 Thread Fredrik Höglund
On Friday 14 June 2013, Benjamin Port wrote: In the kdeui crumble I'm currently on: KWindowsSystem, there is a task for ./util/kxerrorhandler.h but KWindowsSystem have already one kxerrorhandler. So I don't know what I need to do. The 2 files are really similar only one deprecated constructor

Review Request 111028: Move kkeyserver* to KWindowsSystem

2013-06-14 Thread Benjamin Port
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111028/ --- Review request for KDE Frameworks. Description --- Move kkeyserver*

Re: Review Request 111028: Move kkeyserver* to KWindowsSystem

2013-06-14 Thread Benjamin Port
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111028/ --- (Updated June 14, 2013, 7:30 p.m.) Review request for KDE Frameworks.