Re: KGlobalSettings move to kde4support

2013-06-20 Thread Kevin Ottens
On Thursday 20 June 2013 07:50:04 Martin Gräßlin wrote: On Wednesday 19 June 2013 15:04:57 Matthew Woehlke wrote: On 2013-06-18 11:54, Aleix Pol wrote: On Tue, Jun 18, 2013 at 5:40 PM, Matthew Woehlke wrote: On 2013-06-18 03:10, Dominik Haumann wrote: On Tuesday, June 18, 2013 08:14:50

Re: Review Request 111105: Create KWallet framework and move kwallet.h and others

2013-06-20 Thread Kevin Ottens
On June 19, 2013, 1:26 a.m., Wojciech Kapuscinski wrote: hmmm strange. kwallettest is unit test but was in manual tests (CMakeLists.txt in kdeui). Not sure what to do because kwallettest requires kwalletd Valentin Rusu wrote: Perhaps we could use this kdeui splitting opportunity

Re: Review Request 111081: KIO::Job: more core/gui splitup.

2013-06-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111081/ --- (Updated June 20, 2013, 8:16 a.m.) Review request for KDE Frameworks.

Re: Review Request 110988: Port kio-file to QFile

2013-06-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review34671 --- kioslave/file/file.cpp

Re: Review Request 111105: Create KWallet framework and move kwallet.h and others

2013-06-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/05/#review34734 --- This review has been submitted with commit

Re: Review Request 111105: Create KWallet framework and move kwallet.h and others

2013-06-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/05/ --- (Updated June 20, 2013, 8:33 a.m.) Status -- This change has been

Build failed in Jenkins: kdelibs_frameworks_qt5 #739

2013-06-20 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/739/changes Changes: [wojtask9.kde] Create KWallet framework and move kwallet.h and others -- [...truncated 6769 lines...] In file included from

Re: Review Request 110988: Port kio-file to QFile

2013-06-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review34736 --- kioslave/file/file.cpp

Re: Review Request 111081: KIO::Job: more core/gui splitup.

2013-06-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111081/ --- (Updated June 20, 2013, 10:22 a.m.) Review request for KDE Frameworks.

Re: Review Request 110907: Move kdeprintdialog.h and kcups* to kde4support

2013-06-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110907/ --- (Updated June 20, 2013, 10:29 a.m.) Status -- This change has been

Re: Review Request 111090: Deprecate kdeui/widgets/kstringvalidator.* and kio/kfile/kfilemetainfowidget.*

2013-06-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111090/ --- (Updated June 20, 2013, 10:29 a.m.) Status -- This change has been

Re: Review Request 111106: Fix export marco in kde4support

2013-06-20 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/06/ --- (Updated June 20, 2013, 10:30 a.m.) Status -- This change has been

Re: Review Request 111086: Move KXErrorHandler

2013-06-20 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111086/ --- (Updated June 20, 2013, 10:30 a.m.) Status -- This change has been

Re: Review Request 111081: KIO::Job: more core/gui splitup.

2013-06-20 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111081/#review34747 --- Ship it! Ship It! - Kevin Ottens On June 20, 2013, 10:22

Re: Review Request 111081: KIO::Job: more core/gui splitup.

2013-06-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111081/ --- (Updated June 20, 2013, 10:35 a.m.) Status -- This change has been

Re: Review Request 111081: KIO::Job: more core/gui splitup.

2013-06-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111081/#review34748 --- This review has been submitted with commit

Re: KF5 Update Meeting Minutes 2013-w25

2013-06-20 Thread Kevin Ottens
Hello, On Wednesday 19 June 2013 15:50:54 Kevin Ottens wrote: On Tuesday 18 June 2013 17:23:15 Kevin Ottens wrote: Announcements: * Tomorrow no new patch should be started, instead we get all the pending ones integrated so that dfaure can do a merge on thursday morning; Due to

Re: Review Request 111106: Fix export marco in kde4support

2013-06-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/06/#review34745 --- This review has been submitted with commit

Re: Review Request 111090: Deprecate kdeui/widgets/kstringvalidator.* and kio/kfile/kfilemetainfowidget.*

2013-06-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111090/#review34746 --- This review has been submitted with commit

Jenkins build became unstable: kdelibs_frameworks_qt5 #742

2013-06-20 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/742/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kdelibs_frameworks_qt5 #743

2013-06-20 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/743/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #744

2013-06-20 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/744/changes Changes: [grossard] fixed entity [frank78ac] Use the Fisher-Yates algorithm to randomize lists [grossard] update docbook entities in fr [grossard] update docbook entities in fr [b.buschinski] khtml: now that we are using

Re: KF5 Update Meeting Minutes 2013-w25

2013-06-20 Thread David Faure
Le jeudi 20 juin 2013 12:39:35 Kevin Ottens a écrit : Hello, On Wednesday 19 June 2013 15:50:54 Kevin Ottens wrote: On Tuesday 18 June 2013 17:23:15 Kevin Ottens wrote: Announcements: * Tomorrow no new patch should be started, instead we get all the pending ones integrated

Jenkins build is back to normal : kdelibs_frameworks_qt5 #746

2013-06-20 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/746/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

ECM dependency

2013-06-20 Thread David Faure
Please update extra-cmake-modules, otherwise KF5 won't compile. I changed QT_NO_KEYWORDS to QT_NO_SIGNALS_SLOTS_KEYWORDS so that we can keep using emit and foreach in .cpp files, these don't hurt. But that means I cleaned stuff up, so you need an up-to-date ECM, otherwise things will break. --

Re: ECM dependency

2013-06-20 Thread Alexander Neundorf
On Thursday 20 June 2013, David Faure wrote: Please update extra-cmake-modules, otherwise KF5 won't compile. I changed QT_NO_KEYWORDS to QT_NO_SIGNALS_SLOTS_KEYWORDS so that we can keep using emit and foreach in .cpp files, these don't hurt. I'm quite busy currently with other stuff, but

Re: ECM dependency

2013-06-20 Thread David Faure
Le jeudi 20 juin 2013 19:49:44 Benjamin Port a écrit : On Thursday, June 20, 2013 06:10:01 PM David Faure wrote: Please update extra-cmake-modules, otherwise KF5 won't compile. I changed QT_NO_KEYWORDS to QT_NO_SIGNALS_SLOTS_KEYWORDS so that we can keep using emit and foreach in .cpp

Build failed in Jenkins: plasma-framework_master_qt5 #481

2013-06-20 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/481/changes Changes: [sebas] clean up include [sebas] kguiaddons and KDE4_DEFINITIONS are not needed anymore [sebas] Port libplasma unit tests to ECM macros [sebas] Port and enable unit tests for core bindings [sebas] use ecm macros