Hello,
On Saturday 20 July 2013 03:12:25 Vishesh Handa wrote:
I've been looking at the frameworks branch and I cannot help but
notice that there is an 'include' folder which contains all the fancy
headers. Is there any policy on what needs to be done about it?
Some of the fancy headers,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111424/
---
(Updated July 23, 2013, 9:54 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111424/#review36340
---
Ship it!
Ship It!
- David Faure
On July 23, 2013, 7:54
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111424/#review36341
---
This review has been submitted with commit
On Tuesday, July 23, 2013 08:49:48 AM Kevin Ottens wrote:
Hello,
On Saturday 20 July 2013 03:12:25 Vishesh Handa wrote:
I've been looking at the frameworks branch and I cannot help but
notice that there is an 'include' folder which contains all the fancy
headers. Is there any policy on
See http://build.kde.org/job/kdelibs_frameworks_qt5/898/changes
Changes:
[scarpino] Macro*.cmake ECM SourceIncompatChanges
[scarpino] Move KRichTextWidget and KRichTextEdit to KTextWidgets
--
[...truncated 3775 lines...]
[ 22%] Building CXX object
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111651/
---
Review request for KDE Frameworks.
Description
---
= subj
Diffs
On 23/07/13 09:05, Benjamin Port wrote:
IMO we need to have subdirectory because we can't be sure that we don't have
2
headers with the same name in 2 differents frameworks.
Except that if we did, that would suggest we had a class name duplicated
across two frameworks, which would cause
See http://build.kde.org/job/plasma-framework_master_qt5/521/changes
Changes:
[ervin] Revert Revert Enabling C++11 flags for clang and gcc
--
[...truncated 449 lines...]
Generating moc_containmentinterface.cpp
Generating declarativeappletscript.moc
On Tuesday 23 July 2013 10:05:59 Benjamin Port wrote:
On Tuesday, July 23, 2013 08:49:48 AM Kevin Ottens wrote:
The ideal situation would be to get them generated, but I don't think
anyone put the work in yet.
Yes, I think we need to find a way to generate fancy header. But we probably
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111599/#review36348
---
Ship it!
Ship It!
- Kevin Ottens
On July 19, 2013, 12:15
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111409/#review36349
---
Ship it!
Ship It!
- Kevin Ottens
On July 8, 2013, 4:09
On July 23, 2013, 11:35 a.m., Kevin Ottens wrote:
tier1/sonnet/src/ui/configdialog.h, line 25
http://git.reviewboard.kde.org/r/111584/diff/1/?file=172213#file172213line25
Are you sure about this one and the followings? It's odd if you need
them as it just change the priority
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111636/#review36350
---
It would be nice if your test program could be turned into an
On July 22, 2013, 8:42 p.m., David Faure wrote:
Trivial enough. If it builds, it's correct.
That said, it needs 111636 to be in first.
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111649/#review36353
---
cmake/modules/FindDBusMenuQt.cmake
On Tuesday, July 23, 2013 11:15:52 AM Kevin Ottens wrote:
On Tuesday 23 July 2013 10:05:59 Benjamin Port wrote:
On Tuesday, July 23, 2013 08:49:48 AM Kevin Ottens wrote:
The ideal situation would be to get them generated, but I don't think
anyone put the work in yet.
Yes, I think we
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111650/#review36354
---
Probably worth adding a typedef for
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111651/#review36355
---
Ship it!
Ship It!
- Kevin Ottens
On July 23, 2013, 8:48
See http://build.kde.org/job/kdelibs_frameworks_qt5/899/changes
Changes:
[arichardson.kde] fix compilation of WeaverImplState.cpp
[scarpino] Port away from MacroPushRequiredVars
--
[...truncated 15800 lines...]
from
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111584/
---
(Updated July 23, 2013, 12:38 p.m.)
Review request for KDE Frameworks.
On July 23, 2013, 11:45 a.m., Kevin Ottens wrote:
cmake/modules/FindDBusMenuQt.cmake, line 45
http://git.reviewboard.kde.org/r/111649/diff/1/?file=172963#file172963line45
We probably want to bump the required minimum version to 0.9 instead of
removing that block.
Not sure if my
On July 23, 2013, 11:19 a.m., David Faure wrote:
staging/kio/src/core/authinfo.cpp, line 324
http://git.reviewboard.kde.org/r/111636/diff/1/?file=172718#file172718line324
For some reason Qt has a Q_FOREVER() macro for this. I admit that I'm
not sure what it difference it makes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111653/
---
(Updated July 23, 2013, 4:15 p.m.)
Review request for KDE Frameworks.
Hello everyone,
This is the minutes of the Week 30 KF5 meeting. As usual it has been held on
#kde-devel at 4pm Paris time.
Were present: ben2367, dfaure, miroslav, sandsmark, scarpino, sebas, steveire,
wojtask9 and myself.
Announcements:
* Everyone update your qt5.git, we'll soon start to
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111653/#review36385
---
staging/kguiaddons/tests/CMakeLists.txt
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111653/#review36387
---
staging/kguiaddons/CMakeLists.txt
On Monday 22 July 2013, David Faure wrote:
On Sunday 14 July 2013 21:44:38 Alexander Neundorf wrote:
On Sunday 14 July 2013, David Faure wrote:
On Sunday 14 July 2013 11:42:26 Alexander Neundorf wrote:
A good step forward to improve the experience for the user is to
follow those
On Tuesday 23 July 2013, Kevin Ottens wrote:
On Saturday 20 July 2013 03:12:25 Vishesh Handa wrote:
...
Also, under what folder name should there includes be installed?
Currently the fancy includes are installed in a KDE folder
(/include/KDE/fancyHeaders). Do we want to continue with that?
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111653/
---
(Updated July 23, 2013, 6:41 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111653/#review36389
---
Ship it!
Ship It!
- David Faure
On July 23, 2013, 4:41
See http://build.kde.org/job/kdelibs_frameworks_qt5/902/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111599/#review36405
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111649/#review36406
---
What's the current state of dbusmenuqt ?
Can it be built
On July 23, 2013, 8:52 p.m., Alexander Neundorf wrote:
By replacing the LIBRARIES variables with the target names this broke the
standalone build of kconfigwidgets.
I can replace it again, but I saw others modules do that. This should be fixed
everywhere then, or I'm wrong?
-
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111530/
---
(Updated July 23, 2013, 7:03 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111530/#review36410
---
This review has been submitted with commit
See http://build.kde.org/job/kdelibs_frameworks_qt5/903/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On July 23, 2013, 8:47 p.m., Alexander Neundorf wrote:
What's the current state of dbusmenuqt ?
Can it be built against both Qt4 and Qt5 ?
If so, do they have different version numbers then ?
I don't like that an old version of FindDBusMenuQt.cmake will find the Qt4
version, while a
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111605/#review36197
---
staging/kde4support/src/CMakeLists.txt
[: Albert Astals Cid :]
Chusslove, now that we're discussing this, the current kde4 code allows
.mo files to be under ~/.kde/ (thanks to the multiple possible paths of
kstandarddirs) while the new one only finds them on
QStandardPaths::GenericDataLocation, I know some teams (and even lokalize
See http://build.kde.org/job/kdelibs_frameworks_qt5/905/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On July 23, 2013, 11:19 a.m., David Faure wrote:
staging/kio/src/core/authinfo.cpp, line 324
http://git.reviewboard.kde.org/r/111636/diff/1/?file=172718#file172718line324
For some reason Qt has a Q_FOREVER() macro for this. I admit that I'm
not sure what it difference it makes
On July 23, 2013, 9:42 a.m., Kevin Ottens wrote:
It would be nice if your test program could be turned into an automated
test and added to this review.
Ok, I'll try.
On July 23, 2013, 9:42 a.m., Kevin Ottens wrote:
staging/kio/src/core/authinfo.h, line 375
On July 22, 2013, 8:42 p.m., David Faure wrote:
Trivial enough. If it builds, it's correct.
Kevin Ottens wrote:
That said, it needs 111636 to be in first.
Kevin, I'm surprised, I don't see the connection with #111636. I have written
this patch because I wanted to clean up the task
Hi,
I'm getting the following two errors when trying to build plasma-framework:
macro_ensure_version doesn't exist anymore, but is used in
KDELibs4Config.cmake. Is there a replacement for it?
Then:
CMake Error at CMakeLists.txt:70 (find_package):
Found package configuration file:
On July 23, 2013, 9:42 a.m., Kevin Ottens wrote:
staging/kio/src/core/authinfo.h, line 375
http://git.reviewboard.kde.org/r/111636/diff/1/?file=172717#file172717line375
Should be const QString
David Gil Oliva wrote:
I think you didn't notice something important: the
On July 22, 2013, 8:42 p.m., David Faure wrote:
Trivial enough. If it builds, it's correct.
Kevin Ottens wrote:
That said, it needs 111636 to be in first.
David Gil Oliva wrote:
Kevin, I'm surprised, I don't see the connection with #111636. I have
written this patch because
48 matches
Mail list logo