Build failed in Jenkins: plasma-framework_master_qt5 #660

2013-08-31 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/660/ -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspace http://build.kde.org/job/plasma-framework_master_qt5/ws/ Running

Re: Review Request 112325: Complete the migration to Q_GLOBAL_STATIC

2013-08-31 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112325/ --- (Updated Aug. 31, 2013, 8:57 a.m.) Status -- This change has been

Re: Review Request 112325: Complete the migration to Q_GLOBAL_STATIC

2013-08-31 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112325/#review38981 --- commit 03ff75f2ad70bf2bccf3003209371da1a602c250 - Andrea

Build failed in Jenkins: plasma-framework_master_qt5 #661

2013-08-31 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/661/changes Changes: [heena393] revert back merge changes -- [...truncated 482 lines...] Generating moc_iconitem.cpp Generating moc_runnermodel.cpp Generating moc_serviceoperationstatus.cpp

Re: Review Request 112331: Splitting KUnitConversion

2013-08-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112331/#review38983 --- Solid seems like a big dependency just to know if we're

Re: Review Request 112363: Make it possible for QToolBar to use Other toolbar settings

2013-08-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112363/#review38984 --- Looks good, just minor things found KDE5PORTING.html

Jenkins build became unstable: kdelibs_frameworks_qt5 #1113

2013-08-31 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1113/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112331: Splitting KUnitConversion

2013-08-31 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112331/#review38987 --- staging/kunitconversion/src/kunitconversion/CMakeLists.txt

Re: DBusMenuQt5 cmake foo

2013-08-31 Thread David Faure
On Saturday 31 August 2013 02:51:09 Sebastian Kügler wrote: So I've tried both alternative, changing both calls to either DBusMenuQt or DBusMenuQt5, but neither of them works, both break over the package not being found, but required. I've looked for a *Config.cmake file (as suggested), none

Re: kconfig build fails with recent qt5

2013-08-31 Thread David Faure
On Friday 30 August 2013 10:02:06 Treeve Jelbert wrote: -DQT_NO_CAST_FROM_ASCII That's the issue. It is unset by the toplevel CMakeLists.txt currently, which breaks when building things standalone. Thanks for testing that. I'll fix it for good everywhere. -- David Faure, fa...@kde.org,

Re: K_PLUGIN_FACTORY changes explained

2013-08-31 Thread David Faure
On Friday 30 August 2013 17:36:20 Boudewijn Rempt wrote: I'm also not sure whether this still works with current e-c-m, but first we set the plugin_install_dir: find_package(KF5 REQUIRED MODULE COMPONENTS CMake Compiler InstallDirs) set(kdelibs_SOURCE_DIR TRUE) # override the kf5 plugin

Re: K_PLUGIN_FACTORY changes explained

2013-08-31 Thread Boudewijn Rempt
On Sat, 31 Aug 2013, David Faure wrote: On Friday 30 August 2013 17:36:20 Boudewijn Rempt wrote: I'm also not sure whether this still works with current e-c-m, but first we set the plugin_install_dir: find_package(KF5 REQUIRED MODULE COMPONENTS CMake Compiler InstallDirs)

Re: DBusMenuQt5 cmake foo

2013-08-31 Thread Sebastian Kügler
On Saturday, August 31, 2013 09:45:13 David Faure wrote: * The library naming is also messed up, not working here. What to do? What's messed up? The _LIBRARIES var is unset, that's what I meant with messed up -- not working. :) I'll talk to Aurelien to see how we can get the cmake file in.

Review Request 112401: Let ki18n report the list of available translations of the application

2013-08-31 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112401/ --- Review request for KDE Frameworks, Albert Astals Cid and Aleix Pol

Re: Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

2013-08-31 Thread Chusslove Illich
On Aug. 27, 2013, 1:47 p.m., Albert Astals Cid wrote: Question is, why should it go into this function and not say into others that also accept a language string? Maybe this should go there somewhere as a static helper function? I mean yes, we are using this function from somewhere

Re: Review Request 112177: Split URL drop functionality from KLineEdit

2013-08-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112177/#review39004 --- This review has been submitted with commit

Re: Review Request 112177: Split URL drop functionality from KLineEdit

2013-08-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112177/ --- (Updated Aug. 31, 2013, 11:55 a.m.) Status -- This change has been

Re: Review Request 112401: Let ki18n report the list of available translations of the application

2013-08-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112401/#review39006 --- staging/ki18n/src/klocalizedstring.cpp

Force push to plasma-framework

2013-08-31 Thread Ben Cooksley
Hi everyone, Due to an unfortunate accident involving git merge, several branches of the plasma-framework repository were rendered unusable. To correct this, two branches have been forcibly rewound. They are: - master: now at ea1b637 - ivan/shell-switching: now at f8c2ff5. The following commits

Build failed in Jenkins: plasma-framework_master_qt5 #662

2013-08-31 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/662/ -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace http://build.kde.org/job/plasma-framework_master_qt5/ws/ Running

Build failed in Jenkins: plasma-framework_master_qt5 #663

2013-08-31 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/663/changes Changes: [notmart] re-add the calendar qml component -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Is this task done?

2013-08-31 Thread Albert Astals Cid
Hi guys, been browsing http://community.kde.org/Frameworks/Epics/kdelibs_cleanups and seen Update QCommandLineParser from the version that landed in qtbase dev and fix compilation (including plasma-framework). At least one thing changed, positionalArguments() and addHelpOption(str) is now

Re: Review Request 112363: Make it possible for QToolBar to use Other toolbar settings

2013-08-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112363/#review39022 --- This review has been submitted with commit

Re: Review Request 112363: Make it possible for QToolBar to use Other toolbar settings

2013-08-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112363/ --- (Updated Aug. 31, 2013, 2:41 p.m.) Status -- This change has been

Re: Review Request 112331: Splitting KUnitConversion

2013-08-31 Thread Aleix Pol Gonzalez
On Aug. 31, 2013, 7:20 a.m., Chusslove Illich wrote: staging/kunitconversion/src/kunitconversion/CMakeLists.txt, line 10 http://git.reviewboard.kde.org/r/112331/diff/1/?file=185481#file185481line10 Also the translation domain is configured in config-kunitconversion.h. This

Re: Review Request 112331: Splitting KUnitConversion

2013-08-31 Thread Aleix Pol Gonzalez
On Aug. 31, 2013, 7:01 a.m., David Faure wrote: Solid seems like a big dependency just to know if we're online. I would either 1) keep the ifdefs for solid, so that someone can easily compile it without solid for his own purposes, or 2) port it to QNetworkInterface (I didn't know

Re: Review Request 112331: Splitting KUnitConversion

2013-08-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112331/ --- (Updated Aug. 31, 2013, 4:12 p.m.) Review request for KDE Frameworks.

Re: DBusMenuQt5 cmake foo

2013-08-31 Thread Alexander Neundorf
On Saturday 31 August 2013, David Faure wrote: On Saturday 31 August 2013 02:51:09 Sebastian Kügler wrote: So I've tried both alternative, changing both calls to either DBusMenuQt or DBusMenuQt5, but neither of them works, both break over the package not being found, but required. I've

Review Request 112407: Port KJob to QEventLoopLocker

2013-08-31 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112407/ --- Review request for KDE Frameworks. Description --- Port KJob to

What to do with KScanDialog

2013-08-31 Thread Àlex Fiestas
KScanDialog is currently being used by two apps: kolourpaint and kooka-git according to lxr. This makes me wonder if we should move it to a tier (forcing us to maintain it) or just move it to kde4support and deprecated it. In my opinion if none of the users of this class wants to maintain it

Re: What to do with KScanDialog

2013-08-31 Thread Àlex Fiestas
On Saturday 31 August 2013 19:42:02 Gilles Caulier wrote: Hi, libksane in kdegraphics/libs is the right alternative, very well maintained : https://projects.kde.org/projects/kde/kdegraphics/libs/libksane It work under Linux and OSX using libsane. Under Windows it use Twain interface.

Review Request 112418: replace KSharedPtr with QExplicitlySharedDataPointer

2013-08-31 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112418/ --- Review request for KDE Frameworks. Description --- replace

Re: Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

2013-08-31 Thread Vishesh Handa
On Aug. 27, 2013, 1:47 p.m., Albert Astals Cid wrote: Question is, why should it go into this function and not say into others that also accept a language string? Maybe this should go there somewhere as a static helper function? I mean yes, we are using this function from somewhere

Re: Review Request 112331: Splitting KUnitConversion

2013-08-31 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112331/#review39040 --- staging/kunitconversion/src/kunitconversion/CMakeLists.txt