---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112557/#review39557
---
Ship it!
Ship It!
- David Faure
On Sept. 6, 2013, 1:54
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112545/#review39558
---
Patch missing.
- David Faure
On Sept. 5, 2013, 5:23 p.m.,
On Thursday 05 September 2013 19:34:36 Aleix Pol wrote:
Hi,
KCompletion now depends on KNotification, I'd suggest to remove that
dependency (I can do it myself).
At the moment it's generating quite a bit of DBus noise even though it's
not being consumed anywhere I could find.
It's used
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112547/#review39560
---
Thanks for the investigation.
This check would have to be
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112527/#review39561
---
one last issue
On Sept. 3, 2013, 12:34 p.m., David Faure wrote:
staging/kbookmarks/tests/CMakeLists.txt, line 9
http://git.reviewboard.kde.org/r/112479/diff/1/?file=186788#file186788line9
Isn't that only for unittests?
David Edmundson wrote:
If this is wrong kconfigwidgets and ktextwidgets
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112281/
---
(Updated Sept. 8, 2013, 8:54 a.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112571/#review39571
---
Ship it!
Ship It!
- David Faure
On Sept. 6, 2013, 7:01
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112574/#review39572
---
Ship it!
knewstuff/knewstuff3/ui/entrydetailsdialog.h
On Sunday 08 September 2013, David Faure wrote:
On Thursday 05 September 2013 01:04:52 Sebastian Kügler wrote:
Reading just $PLUGINS/kf5, 52 plugins
21893.0 microsec (KServiceTypeTrader)
95835.0 microsec (Metadata)
-- Reading metadata is 4-5 slower, ~100ms
Reading $PLUGINS
On Sun, 8 Sep 2013, David Faure wrote:
On Thursday 05 September 2013 01:04:52 Sebastian Kügler wrote:
Reading just $PLUGINS/kf5, 52 plugins
21893.0 microsec (KServiceTypeTrader)
95835.0 microsec (Metadata)
-- Reading metadata is 4-5 slower, ~100ms
Reading $PLUGINS recursively, 127 plugins
On Sun, 8 Sep 2013, Boudewijn Rempt wrote:
I like the directoryname idea, and actually, I'd go for a hierarchy:
calligra/filter
calligra/parts
calligra/words
calligra/krita/paintop
calligra/krita/filter
calligra/krita/extensions
etcetera. that should limit the number of plugins per directory
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112547/#review39581
---
Please test https://codereview.qt-project.org/64926, it should
On Sept. 8, 2013, 8:45 a.m., David Faure wrote:
staging/kemoticons/src/core/kemoticonsprovider.h, line 85
http://git.reviewboard.kde.org/r/112527/diff/4/?file=188118#file188118line85
absolute path, or relative path?
All of them are absolute. Should I specify it in the docs? Or
On Sept. 8, 2013, 8:45 a.m., David Faure wrote:
staging/kemoticons/src/core/kemoticonsprovider.cpp, line 146
http://git.reviewboard.kde.org/r/112527/diff/4/?file=188119#file188119line146
file.fileName() is the same as emo. Yes, the name of the methods in
QFile are a bit
On Aug. 30, 2013, 11:01 p.m., David Faure wrote:
kio/kio/kmimetypechooser.cpp, line 231
http://git.reviewboard.kde.org/r/112311/diff/1/?file=185108#file185108line231
QStringLiteral()
Ping?
- Vishesh
---
This is an
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112527/
---
(Updated Sept. 9, 2013, 12:05 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112151/
---
(Updated Sept. 9, 2013, 4:13 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112500/
---
(Updated Sept. 9, 2013, 4:14 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112500/#review39617
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112532/#review39619
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112537/#review39620
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112532/
---
(Updated Sept. 9, 2013, 4:29 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112537/
---
(Updated Sept. 9, 2013, 4:29 a.m.)
Status
--
This change has been
See http://build.kde.org/job/plasma-framework_master_qt5/698/changes
Changes:
[mgraesslin] Rework finding of XCB
--
[...truncated 436 lines...]
http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/iconitem.cpp:0:
Note: No
See http://build.kde.org/job/kdelibs_frameworks_qt5/1164/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
26 matches
Mail list logo