---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112545/#review39690
---
Looks good to me. About whether it's worth keeping the option:
On Monday 09 September 2013 16:03:38 Jeremy Whiting wrote:
Hello,
Apparently my commit to knewstuff broke the build. The problem is that
knewstuff/src/knewstuffbutton.h includes knewstuff3/entry.h which
hasn't been installed yet when building kdelibs. I looked around and
saw some other
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112571/
---
(Updated Sept. 10, 2013, 8:02 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112557/
---
(Updated Sept. 10, 2013, 8:02 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112571/#review39694
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112557/#review39693
---
This review has been submitted with commit
See http://build.kde.org/job/plasma-framework_master_qt5/699/changes
Changes:
[wojtask9.kde] remove all links to kdeqt5staging
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 in workspace
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112633/
---
Review request for KDE Frameworks.
Description
---
Adds dependencies
See http://build.kde.org/job/plasma-framework_master_qt5/700/changes
Changes:
[notmart] documentation++
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 2 in workspace
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112633/#review39708
---
Ship it!
Ship It!
- Stephen Kelly
On Sept. 10, 2013, 9:35
On Sept. 8, 2013, 9:24 a.m., David Faure wrote:
kinit/CMakeLists.txt, line 44
http://git.reviewboard.kde.org/r/112570/diff/1/?file=187699#file187699line44
This could also be moved out of the if, by using the proper arguments
for ecm_mark_nongui_executable, so that it doesn't
See http://build.kde.org/job/plasma-framework_master_qt5/701/changes
Changes:
[notmart] remove unused method
[notmart] more documentation
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 in
See http://build.kde.org/job/plasma-framework_master_qt5/702/changes
Changes:
[notmart] add kdeqt5staging dependency
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 in workspace
See http://build.kde.org/job/plasma-framework_master_qt5/703/changes
Changes:
[notmart] documentation in ContainmentInterface
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 2 in workspace
See http://build.kde.org/job/plasma-framework_master_qt5/704/changes
Changes:
[notmart] propagate drawWallpaperChanged
[notmart] propagate containmentTypeChanged
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112556/
---
(Updated Sept. 10, 2013, 12:45 p.m.)
Review request for KDE Frameworks.
See http://build.kde.org/job/plasma-framework_master_qt5/705/changes
Changes:
[notmart] Revert add kdeqt5staging dependency
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 2 in workspace
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112281/#review39719
---
Ship it!
Looks good to me. Thanks for taking care of adding
See http://build.kde.org/job/plasma-framework_master_qt5/706/changes
Changes:
[notmart] support for wallpaper actions
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 2 in workspace
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112559/
---
(Updated Sept. 10, 2013, 1:56 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112559/#review39721
---
Ship it!
khtml/html/html_formimpl.cpp
See http://build.kde.org/job/plasma-framework_master_qt5/707/changes
Changes:
[notmart] use a dynamic property
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 2 in workspace
Hi there
These are the minutes of the Week 37 KF5 meeting. As usual it has been held on
#kde-devel at 4pm Barcelona (CEST / UTC+2) time.
Present on the meeting: agateau, apol_, dfaure, jpwhiting, markg85, mck182,
mgraesslin, scarpino, sebas, Sho_, steveire, svuorela, teo-, vHanda, afiestas
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112570/#review39734
---
Ship it!
Ship It!
- Stephen Kelly
On Sept. 10, 2013, 3:49
See http://build.kde.org/job/plasma-framework_master_qt5/708/changes
Changes:
[notmart] support for setting a wallpaper trough drag and drop
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 2
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112545/#review39743
---
staging/kdoctools/src/meinproc.cpp
On Sept. 10, 2013, 6:46 a.m., David Faure wrote:
staging/kdoctools/src/meinproc.cpp, line 112
http://git.reviewboard.kde.org/r/112545/diff/1/?file=188443#file188443line112
isn't it better to not define the option, so that the user gets
unknown option --cache?
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112545/
---
(Updated Sept. 10, 2013, 4:52 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112545/
---
(Updated Sept. 10, 2013, 5:39 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112643/
---
Review request for KDE Frameworks and Stephen Kelly.
Description
---
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112560/
---
(Updated Sept. 10, 2013, 5:50 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112560/#review39748
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112556/#review39773
---
Ship it!
Ship It!
- David Faure
On Sept. 10, 2013, 10:45
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112643/#review39778
---
Ship it!
Though I would put the remove_definitions changes in
See http://build.kde.org/job/plasma-framework_master_qt5/709/
--
[...truncated 537 lines...]
Generating applet.moc
http://build.kde.org/job/plasma-framework_master_qt5/ws/src/shell/scripting/applet.cpp:0:
Note: No relevant classes found. No output
See http://build.kde.org/job/kdelibs_frameworks_qt5/1174/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Sept. 10, 2013, 9:06 p.m., David Faure wrote:
Ship It!
So what about renaming itemmodels/itemviews to kitemmodels/kitemviews, or is it
too late for that? Do we plan to have a proper/final let's look at what we
did API review after everything has settled?
- Christoph
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112660/
---
Review request for KDE Frameworks and David Faure.
Description
---
On Sept. 9, 2013, 2:39 p.m., Aurélien Gâteau wrote:
Instead of adding methods to get buttons and combo boxes from
KSelectAction, which is an implementation detail to me, what about this:
- Add KSelectAction::insertAction(QAction* before, QAction*) (because what
39 matches
Mail list logo
