Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-21 Thread David Faure
On Oct. 16, 2013, 12:15 p.m., John Layt wrote: Wow, there sure is a lot of code in there catering for all the possible corner cases :-) QTimeZone has a lot less places it checks, so I'll need to do an in-depth comparison, but given Qt5 will only support modern distros I think most

Re: CMake, KF5_INCLUDE_DIRS empty?

2013-10-21 Thread Stephen Kelly
Mark wrote: On Sun, Oct 20, 2013 at 11:42 AM, David Faure fa...@kde.org wrote: On Sunday 13 October 2013 17:18:28 Mark wrote: Hi, I used to rely on KF5_INCLUDE_DIRS but since a few days that variable seems to be empty. Did i do something wrong? My CMake file for the relevant parts:

Re: Can someone verify this? Massive folders only show about 1000 entries in KF/Qt 5.2.

2013-10-21 Thread Stephen Kelly
Mark wrote: Step 2: Create a Qt 5.2 project. CMake or QMake, doesn't matter. it needs kdelibs, kio and qt widgets and whatever the extra dependencies are at this moment. You can use this cmake file for reference http://pastebin.kde.org/ptq5kgkqx. Change the absolute paths. The code for you

Config files naming policy

2013-10-21 Thread Ivan Čukić
Hi all, Since we are now sharing the locations of our configs with non-kde software, we can potentially get collisions with those. I'm proposing changing the names of the config files to org.kde.something (or some other alternative). Cheerio, Ivan -- Acting is merely the art of keeping a

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-21 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113148/ --- (Updated Oct. 21, 2013, 10:22 a.m.) Review request for KDE Frameworks.

Re: Review Request 113302: Static KEncodingFileDialog in staging/kio

2013-10-21 Thread Kevin Ottens
On Oct. 20, 2013, 9:32 a.m., David Faure wrote: OK, I'm just wondering if it still makes sense to make it static-methods-only. It can still very well work the other way, which can allow extra flexibility if needed (e.g. for kate to add another widget into it, or use it non-modal,

Re: Review Request 112032: Convert tier1/kwidgetaddons to the new Qt5 signal/slot syntax

2013-10-21 Thread Kevin Ottens
On Sept. 23, 2013, 9:10 a.m., Kevin Ottens wrote: Any news about that patch? Hasn't seen activity in a while, it probably doesn't apply cleanly anymore. Still no news? If I don't see activity by next monday I'll close it as discarded. - Kevin

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

2013-10-21 Thread Kevin Ottens
On Sept. 23, 2013, 9:12 a.m., Kevin Ottens wrote: Any reason why this patch isn't committed yet? Please do so ASAP. Any news? I'll close it as discarded if I don't see any activity by next monday. - Kevin --- This is an

Re: Review Request 112367: Include the icon's theme in the cache key

2013-10-21 Thread Kevin Ottens
On Aug. 31, 2013, 7:11 a.m., David Faure wrote: I disagree. Making things slow to cover a really really corner case (mixing kde4 and kde5), while the solution already exists (clearing the cache when switching icon themes), doesn't seem very sensible to me. The point is really that

kactivities master becomes Qt5/KF5-based

2013-10-21 Thread Ivan Čukić
Hi all, Following kde-workspace (and stealing a few sentences from that announcement), we're planning to merge the frameworks-scratch branch of kactivities into master later today. That means if you're building 4.x branch of Plasma yourself from Git, you should switch to the KDE/4.11 branch.

Re: Review Request 112896: Rework NETWM classes

2013-10-21 Thread Kevin Ottens
On Sept. 26, 2013, 2:27 a.m., Fredrik Höglund wrote: I'm just going to point out something I know you already know since we've discussed it many times; that an xcb port of the NETWM classes already exists in a branch. Martin Gräßlin wrote: my aim was to write the unit test and

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-10-21 Thread Kevin Ottens
On Sept. 23, 2013, 10:07 a.m., Kevin Ottens wrote: Tested the patch in my tree, works for caps lock too. Now it highlights a dependency problem... We don't want a dependency on QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your proposed KX11Extras?

Re: Review Request 113155: Port all kde4_add_unit_test uses

2013-10-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113155/#review42070 --- Any chance to see Alexander comments addressed? - Kevin

Re: Review Request 112985: Adjust API in KEmoticons framework: map and index methods

2013-10-21 Thread Kevin Ottens
On Oct. 11, 2013, 4:28 p.m., Kevin Ottens wrote: Ship It! Any reason why this patch is not pushed yet? - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112985/#review41567

Re: Review Request 113302: Static KEncodingFileDialog in staging/kio

2013-10-21 Thread Teo Mrnjavac
On Oct. 20, 2013, 9:32 a.m., David Faure wrote: OK, I'm just wondering if it still makes sense to make it static-methods-only. It can still very well work the other way, which can allow extra flexibility if needed (e.g. for kate to add another widget into it, or use it non-modal,

Re: Review Request 113266: introduce KMessageBoxNotifyInterface to support notifications

2013-10-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113266/#review42074 --- Ship it! Ship It! - Kevin Ottens On Oct. 16, 2013, 1:35

Re: Review Request 113297: Remove 'override' from ThreadWeaver::IdDecorator destructor.

2013-10-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113297/#review42076 --- Ship it! Ship It! - Kevin Ottens On Oct. 17, 2013, 12:08

Re: Review Request 113181: Add KDebug porting notes to KDE5PORTING.html

2013-10-21 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113181/ --- (Updated Oct. 21, 2013, 11:30 a.m.) Status -- This change has been

Re: Review Request 113181: Add KDebug porting notes to KDE5PORTING.html

2013-10-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113181/#review42075 --- This review has been submitted with commit

Re: Review Request 113299: KDirWatch code style: braces for one-liner conditionals

2013-10-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113299/#review42077 --- I would leave them alone for now. I think we'll revisit the

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/#review42078 --- Ship it! Ship It! - Kevin Ottens On Oct. 17, 2013, 7:53

Re: Review Request 113329: Adapt KSystemTimeZones to new KTimeZoned signal

2013-10-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113329/#review42079 --- Ship it! Preemptively giving this one a ship it. Can go in

Re: Review Request 113258: Fix compilation with C++11 enabled.

2013-10-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113258/#review42081 --- Ship it! Ship It! - Kevin Ottens On Oct. 15, 2013, 6:43

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/#review42080 --- tier2/kdoctools/CMakeLists.txt

Re: Review Request 113302: Static KEncodingFileDialog in staging/kio

2013-10-21 Thread Kevin Ottens
On Oct. 20, 2013, 9:32 a.m., David Faure wrote: OK, I'm just wondering if it still makes sense to make it static-methods-only. It can still very well work the other way, which can allow extra flexibility if needed (e.g. for kate to add another widget into it, or use it non-modal,

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113148/#review42083 --- Ship it! Ship It! - Kevin Ottens On Oct. 21, 2013, 10:22

Re: kactivities master becomes Qt5/KF5-based

2013-10-21 Thread Ivan Čukić
Please no. We have a 4.12 release to make in 2 weeks and back when we did the 4.12 planning the only agreed repo to be freezed for 4.11 was kde-workspace. What about doing an early KDE/4.12 branch from master so that the release can continue as planned, while not slowing us down for further

Re: Review Request 113302: Static KEncodingFileDialog in staging/kio

2013-10-21 Thread Kevin Ottens
On Oct. 20, 2013, 9:32 a.m., David Faure wrote: OK, I'm just wondering if it still makes sense to make it static-methods-only. It can still very well work the other way, which can allow extra flexibility if needed (e.g. for kate to add another widget into it, or use it non-modal,

Re: Review Request 113302: Static KEncodingFileDialog in staging/kio

2013-10-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113302/#review42085 --- Ship it! I think it's OK to keep it based only on statics. As

Re: Review Request 113302: Static KEncodingFileDialog in staging/kio

2013-10-21 Thread David Faure
On Oct. 21, 2013, 12:05 p.m., Kevin Ottens wrote: I think it's OK to keep it based only on statics. As such we can go for it. OK, let's go for static methods only then. - David --- This is an automatically generated e-mail. To

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-21 Thread John Layt
On Oct. 16, 2013, 12:15 p.m., John Layt wrote: Wow, there sure is a lot of code in there catering for all the possible corner cases :-) QTimeZone has a lot less places it checks, so I'll need to do an in-depth comparison, but given Qt5 will only support modern distros I think most

Review Request 113365: Fix #include kdesu_export.h

2013-10-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113365/ --- Review request for KDE Frameworks and Martin Klapetek. Repository:

Re: Review Request 113302: Static KEncodingFileDialog in staging/kio

2013-10-21 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113302/ --- (Updated Oct. 21, 2013, 12:40 p.m.) Status -- This change has been

[kdelibs/frameworks] staging/kio/src/core: Add include/KDE to users of KIOCore.

2013-10-21 Thread Stephen Kelly
Git commit 5e9404239fb974973e8a253444131884954ede77 by Stephen Kelly. Committed on 21/10/2013 at 12:49. Pushed by skelly into branch 'frameworks'. Add include/KDE to users of KIOCore. Note that this really only hides the problem. There are several problems with the KF5 includes, and several

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-21 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/ --- (Updated Oct. 21, 2013, 3:32 p.m.) Review request for KDE Frameworks.

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-21 Thread Aurélien Gâteau
On Oct. 21, 2013, 1:43 p.m., Kevin Ottens wrote: tier2/kdoctools/CMakeLists.txt, line 18 http://git.reviewboard.kde.org/r/113328/diff/2/?file=203416#file203416line18 FOOBAR really? :-) In fact ecm_setup_version might not even be needed for that one, it has no lib,

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-21 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113148/ --- (Updated Oct. 21, 2013, 2:09 p.m.) Status -- This change has been

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113148/#review42095 --- This review has been submitted with commit

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-10-21 Thread Martin Gräßlin
On Oct. 9, 2013, 6:39 p.m., Kevin Ottens wrote: Any news about that patch? It hasn't seen activity lately. Kevin Ottens wrote: Anybody home? FYI I'll close it as discarded if it doesn't have any activity by next monday. hey, I'm going to pick it up again! Just had been

Re: Fwd: Failing Tests in Kross

2013-10-21 Thread Vishesh Handa
Hey everyone I managed to contact Sebastian through his kdab email account. I've attached the response below. On Fri, Oct 18, 2013 at 3:13 AM, Sebastian Sauer sebastian.sa...@kdab.com wrote: On 10/16/2013 03:15 PM, Vishesh Handa wrote: Hey Sebastian Aloha Vishesh :) If you get some free

Re: Fwd: Failing Tests in Kross

2013-10-21 Thread Vishesh Handa
Aloha Sebastian :D On Fri, Oct 18, 2013 at 3:13 AM, Sebastian Sauer sebastian.sa...@kdab.com wrote: Aloha Vishesh :) Unfortunately I don't have a working kf5 setup, there are no packages for my distribution and keeping up with kf5 development is near impossible for me having a fulltime-job

cyclic dependency kinit - kservice

2013-10-21 Thread Treeve Jelbert
kinit needs kservice and installs KInitMacros.cmake which defines kf5_add_kdeinit_executable which is needed by kservice/kbuildsycoca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

2013-10-21 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108845/ --- (Updated Oct. 21, 2013, 3:23 p.m.) Status -- This change has been

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

2013-10-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108845/#review42107 --- This review has been submitted with commit

Re: cyclic dependency kinit - kservice

2013-10-21 Thread Kevin Ottens
On Monday 21 October 2013 17:01:44 Treeve Jelbert wrote: kinit needs kservice and installs KInitMacros.cmake which defines kf5_add_kdeinit_executable which is needed by kservice/kbuildsycoca Well, spotted, missed that one in the review. Alex could you look into solving this cycle? Thanks in

Re: kactivities master becomes Qt5/KF5-based

2013-10-21 Thread Albert Astals Cid
Hi all, Following kde-workspace (and stealing a few sentences from that announcement), we're planning to merge the frameworks-scratch branch of kactivities into master later today. That means if you're building 4.x branch of Plasma yourself from Git, you should switch to the KDE/4.11

Re: kactivities master becomes Qt5/KF5-based

2013-10-21 Thread Albert Astals Cid
El Dilluns, 21 d'octubre de 2013, a les 14:02:42, Ivan Čukić va escriure: Please no. We have a 4.12 release to make in 2 weeks and back when we did the 4.12 planning the only agreed repo to be freezed for 4.11 was kde-workspace. What about doing an early KDE/4.12 branch from master so

Re: kactivities master becomes Qt5/KF5-based

2013-10-21 Thread Ivan Čukić
I was planning to branch master into KDE/4.12 after October 30 and before November 6. Forget about it. Decided not to create problems - I'll use the same name for the branch as kdelibs do for the time being - frameworks :) Also it means that you don't want a 4.13.x for kactivities, right?

Re: kactivities master becomes Qt5/KF5-based

2013-10-21 Thread Albert Astals Cid
El Dilluns, 21 d'octubre de 2013, a les 18:43:20, Ivan Čukić va escriure: I was planning to branch master into KDE/4.12 after October 30 and before November 6. Forget about it. Decided not to create problems - I'll use the same name for the branch as kdelibs do for the time being -

Re: kactivities master becomes Qt5/KF5-based

2013-10-21 Thread Ivan Čukić
Well, to be honest, if you don't want a 4.13 release i'd prefer you actually use master for KF5. Otherwise people might random-commit fixes to master and then wonder why they never got into a release, so the two situations i think make sense are: People don't really contribute to

Re: Review Request 113365: Fix #include kdesu_export.h

2013-10-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113365/#review42119 --- Ship it! Looks sane, and builds fine even when I remove the

Re: Config files naming policy

2013-10-21 Thread Alexander Neundorf
On Monday 21 October 2013, Ivan Čukić wrote: Hi all, Since we are now sharing the locations of our configs with non-kde software, we can potentially get collisions with those. I'm proposing changing the names of the config files to org.kde.something (or some other alternative). do you

Re: Review Request 113258: Fix compilation with C++11 enabled.

2013-10-21 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113258/ --- (Updated Oct. 21, 2013, 6:25 p.m.) Status -- This change has been

Re: Review Request 113258: Fix compilation with C++11 enabled.

2013-10-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113258/#review42122 --- This review has been submitted with commit

Re: [kdelibs/frameworks] staging/kio/src/core: Add include/KDE to users of KIOCore.

2013-10-21 Thread Aleix Pol
On Mon, Oct 21, 2013 at 2:54 PM, Stephen Kelly steve...@gmail.com wrote: Git commit 5e9404239fb974973e8a253444131884954ede77 by Stephen Kelly. Committed on 21/10/2013 at 12:49. Pushed by skelly into branch 'frameworks'. Add include/KDE to users of KIOCore. Note that this really only hides

Re: Config files naming policy

2013-10-21 Thread Ivan Čukić
do you mean the Config.cmake files or application configuration files ? The application configuration files. Ivan -- When the pupil is ready to learn, a teacher will appear. -- Basho ___ Kde-frameworks-devel mailing list

Review Request 113373: Enable C++11 support by default.

2013-10-21 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113373/ --- Review request for Extra Cmake Modules, KDE Frameworks and Stephen Kelly.

Re: Review Request 113373: Enable C++11 support by default.

2013-10-21 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113373/#review42126 --- As the next CMake release will have a better solution which

Re: Review Request 113373: Enable C++11 support by default.

2013-10-21 Thread Ivan Čukić
On Oct. 21, 2013, 7:18 p.m., Stephen Kelly wrote: As the next CMake release will have a better solution which works for all compilers: set(CMAKE_CXX_STANDARD 11) I'm not in favor of adding and having to support this flag. I don't consider it my decision though. Are we

Re: Review Request 113373: Enable C++11 support by default.

2013-10-21 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113373/#review42130 --- As far as I know, only threadweaver and karchive will be

Build failed in Jenkins: plasma-framework_master_qt5 #825

2013-10-21 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/825/changes Changes: [notmart] get rid of WidgetExplorerView -- [...truncated 326 lines...] Generating moc_storagetest.cpp Generating mouseeventlistener.moc

Build failed in Jenkins: plasma-framework_master_qt5 #826

2013-10-21 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/826/changes Changes: [notmart] use the ctivity class and Kactivities [notmart] make activity switching work [notmart] link to KF5::KActivities [notmart] activity switching animation [notmart] a toggleActivityManager action

Build failed in Jenkins: plasma-framework_master_qt5 #827

2013-10-21 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/827/changes Changes: [aleixpol] Stop using Qt5Transitional in Plasma Frameworks -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-21 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/ --- (Updated Oct. 21, 2013, 10:30 p.m.) Status -- This change has been

Re: Review Request 113299: KDirWatch code style: braces for one-liner conditionals

2013-10-21 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113299/ --- (Updated Oct. 21, 2013, 7:31 p.m.) Status -- This change has been

Re: Review Request 113297: Remove 'override' from ThreadWeaver::IdDecorator destructor.

2013-10-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113297/#review42139 --- This review has been submitted with commit

Re: Review Request 113297: Remove 'override' from ThreadWeaver::IdDecorator destructor.

2013-10-21 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113297/ --- (Updated Oct. 21, 2013, 11:02 p.m.) Status -- This change has been

Review Request 113377: Add KDeclarative to known KF5 tier3 modules

2013-10-21 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113377/ --- Review request for KDE Frameworks and Stephen Kelly. Repository:

Re: Review Request 113377: Add KDeclarative to known KF5 tier3 modules

2013-10-21 Thread Nicolás Alvarez
2013/10/21 Sebastian Kügler se...@kde.org This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113377/ Review request for KDE Frameworks and Stephen Kelly. By Sebastian Kügler. Repository: extra-cmake-modules Description Add KDeclarative to known

Review Request 113378: Trivial warning fixes

2013-10-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113378/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Review Request 113376: KDirWatch: don't check for symlinks on Windows.

2013-10-21 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113376/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-21 Thread David Gil Oliva
On Oct. 11, 2013, 4:28 p.m., Kevin Ottens wrote: Ship It! Kevin Ottens wrote: Any reason why this patch isn't pushed yet? Yes. There are some personal reasons and, besides, I've been trying for days to compile Qt5.2 with no luck till today. I think I'll have both patches pushed

Projects adding dependencies without clear indication of requirements

2013-10-21 Thread Ben Cooksley
Hi all, It seems that plasma-framework (a dependency of kde-workspace master) has now added a dependency on kactivities. However kactivities itself depends on nepomuk-core and soprano - and there is no frameworks / Qt 5 branch for either of those. How do we proceed here? I'd appreciate it if