Google Code-In

2013-10-25 Thread Kevin Ottens
Hello all, I got contacted by Lydia because the Google Code-In will soon start and we could maybe give out tasks to people. I think that's a good idea, and one area is port kdeexamples to KF5. If we split it per example in the repo, it makes for nice small tasks, is easy to have them in

Re: Review Request 113402: Fix KI18n standalone build

2013-10-25 Thread Kevin Ottens
On Oct. 23, 2013, 2:40 p.m., Chusslove Illich wrote: I can only say that whatever is the proper fix here, it is fine with me. Since non-installed headers are being used, maybe ki18n is using KJS in a way which became deprecated somewhere along the way? If so, I've nothing against fixing

Re: extra-cmake-modules: remove ECMPrintVariables.cmake

2013-10-25 Thread Kevin Ottens
On Thursday 24 October 2013 22:29:51 Alexander Neundorf wrote: If somebody feels like it, I think it would be a good idea to remove ECMPrintVariables.cmake, now that there is a replacement in cmake. Makes sense IMO. Thanks for pointing it out. Regards. -- Kévin Ottens,

Re: KDirWatch vs QFileSystemWatcher

2013-10-25 Thread Kevin Ottens
On Thursday 24 October 2013 21:54:42 Sune Vuorela wrote: Hi If your KDirWatch backend is QFileSystemWatcher, one of the testcases fails. The last QVERIFY in testMoveTo never receives the signal dirty-signal it is looking for. Apparantly, the watch.removeFile apparantly somehow turns

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-10-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review42333 --- Ship it!

Re: Review Request 113395: Enable KConfig on Windows

2013-10-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/#review42335 --- Looks good to me (don't know about the ownerId() stuff. Maybe

Re: Review Request 113371: Kross: Remove the KJs backened

2013-10-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113371/#review42338 --- Ship it! If he says so :) - David Faure On Oct. 21, 2013,

Re: Review Request 113391: Remove unnecessary #includes for moc files

2013-10-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113391/#review42337 --- Ship it! Ship It! - David Faure On Oct. 22, 2013, 4:23

Re: Google Code-In

2013-10-25 Thread Kevin Ottens
On Friday 25 October 2013 08:59:27 Sune Vuorela wrote: On 2013-10-25, Kevin Ottens er...@kde.org wrote: I got contacted by Lydia because the Google Code-In will soon start and= we=20 could maybe give out tasks to people. I think that's a good idea, and o= ne area=20 is port

Re: Review Request 113373: Enable C++11 support by default.

2013-10-25 Thread Stephen Kelly
Kevin Ottens wrote: Stephen Kelly wrote: It's not my decision either. It's just a recommendation. Aleix Pol Gonzalez wrote: I object. What's the big impediment of releasing ECM? If there's an impediment, let's fix it. I agree with Aleix here. I think it's important that the first frameworks

Re: Review Request 113373: Enable C++11 support by default.

2013-10-25 Thread Kevin Ottens
On Friday 25 October 2013 11:22:26 Stephen Kelly wrote: Kevin Ottens wrote: Stephen Kelly wrote: It's not my decision either. It's just a recommendation. Aleix Pol Gonzalez wrote: I object. What's the big impediment of releasing ECM? If there's an impediment, let's fix it. I agree

Re: Review Request 113373: Enable C++11 support by default.

2013-10-25 Thread Stephen Kelly
Kevin Ottens wrote: That could obsolete ecm_mark_as_test etc. Sure, I don't see how that's different from classes or methods we have in our libraries at the moment which will get obsoleted by some later Qt version. With that line of thinking we'd never release. Just mark modules which

Re: Review Request 113373: Enable C++11 support by default.

2013-10-25 Thread Kevin Ottens
On Friday 25 October 2013 11:38:40 Stephen Kelly wrote: Kevin Ottens wrote: That could obsolete ecm_mark_as_test etc. Sure, I don't see how that's different from classes or methods we have in our libraries at the moment which will get obsoleted by some later Qt version. With that line

Re: Review Request 113391: Remove unnecessary #includes for moc files

2013-10-25 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113391/ --- (Updated Oct. 25, 2013, 10:05 a.m.) Status -- This change has been

Re: Review Request 113378: Trivial warning fixes

2013-10-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113378/#review42343 --- This review has been submitted with commit

Re: Review Request 113391: Remove unnecessary #includes for moc files

2013-10-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113391/#review42344 --- This review has been submitted with commit

Re: Review Request 113395: Enable KConfig on Windows

2013-10-25 Thread Andrius da Costa Ribas
On Oct. 23, 2013, 1:25 a.m., Andrius da Costa Ribas wrote: tier1/kconfig/src/core/kconfigini.cpp, line 425 http://git.reviewboard.kde.org/r/113395/diff/1/?file=204894#file204894line425 Files have no owner on Windows. QFileInfo::ownerId() always returns -2 on Windows and so would

Dirty CMake master content in install directory

2013-10-25 Thread Stephen Kelly
Hello, If you use CMake master, then you may have unused stuff in your install directory versioned by commit sha: http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/8433 The issue is resolved in the CMake next branch, and will be merged to master next week probably. Thanks,

Review Request 113430: More warnings fixes

2013-10-25 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113430/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Review Request 113432: Install FindDBusMenuQt5.cmake

2013-10-25 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113432/ --- Review request for KDE Frameworks, Sebastian Kügler and Stephen Kelly.

Re: Review Request 113432: Install FindDBusMenuQt5.cmake

2013-10-25 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113432/#review42361 --- Why does that library not install a Config.cmake file? -

Re: Review Request 113432: Install FindDBusMenuQt5.cmake

2013-10-25 Thread Aurélien Gâteau
On Oct. 25, 2013, 5:40 p.m., Stephen Kelly wrote: Why does that library not install a Config.cmake file? Sebas put together a patch to do so, but it needs to be refined because it currently does not work for Qt4 (dbusmenu-qt is Qt4 and Qt5). Furthermore, the upstream project needs to

Re: Use of the WIN32 executable property

2013-10-25 Thread Nicolás Alvarez
2013/10/25 David Faure fa...@kde.org: On Wednesday 02 October 2013 23:52:08 Nicolás Alvarez wrote: In fact, I wonder if we should make all tests console applications by default (in ecm_mark_as_test?)... All unittests, yes. But interactive test apps are really just normal test apps, there's

Re: cyclic dependency kinit - kservice

2013-10-25 Thread Kevin Ottens
On Friday 25 October 2013 12:21:28 David Narvaez wrote: On Fri, Oct 25, 2013 at 11:37 AM, Kevin Ottens er...@kde.org wrote: Not that I know of, Alex never replied to that I think... What would be a proper fix for this? Separating kbuildsycoca and putting it on top of kinit? I'd lean more

Jenkins build is back to stable : kdelibs_stable #867

2013-10-25 Thread KDE CI System
See http://build.kde.org/job/kdelibs_stable/867/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kdelibs_stable #868

2013-10-25 Thread KDE CI System
See http://build.kde.org/job/kdelibs_stable/868/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113436: Deprecate KEmoticonsTheme methods

2013-10-25 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113436/ --- Review request for KDE Frameworks. Repository: kdelibs Description