Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 26, 2013, 10:56 a.m.) Review request for Build System, KDE F

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-26 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/#review42396 --- The install dir is still in the documentation and in the cmake

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 26, 2013, 9:35 a.m.) Review request for Build System, KDE Fr

Re: cyclic dependency kinit - kservice

2013-10-26 Thread David Narvaez
On Fri, Oct 25, 2013 at 11:37 AM, Kevin Ottens wrote: > Not that I know of, Alex never replied to that I think... What would be a proper fix for this? Separating kbuildsycoca and putting it on top of kinit? David E. Narvaez ___ Kde-frameworks-devel mai

Re: cyclic dependency kinit - kservice

2013-10-26 Thread David Narvaez
On Mon, Oct 21, 2013 at 12:08 PM, Kevin Ottens wrote: > On Monday 21 October 2013 17:01:44 Treeve Jelbert wrote: >> kinit needs kservice and installs KInitMacros.cmake which defines >> kf5_add_kdeinit_executable which is needed by kservice/kbuildsycoca > > Well, spotted, missed that one in the rev

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-26 Thread Aleix Pol Gonzalez
> On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: > > modules/ECMGenerateHeaders.cmake, line 29 > > > > > > This variable shouldn't be needed at all. > > Aleix Pol Gonzalez wrote: > Variable? Or argument? Wh