Re: Review Request 113670: Only link to Qt5::X11Extras and ${X11_LIBRARIES} if X11 was found

2013-11-09 Thread Martin Gräßlin
On Nov. 8, 2013, 5:25 p.m., Andrius da Costa Ribas wrote: Please use X11 stuff conditionally (Q_WS_X11). Alex Merry wrote: There's no need to put conditionals in the file (since the whole thing is conditionally compiled), but the linking should be done conditionally.

Re: the kspeech interface

2013-11-09 Thread David Faure
On Friday 08 November 2013 22:45:33 Jeremy Whiting wrote: Oops, that link was just users of soPlainText. It seems http://lxr.kde.org/ident?i=KSpeech the class itself is used in quite a few places, and is how any application uses speech capabilities. I guess kdbusaddons is as good a place as

Review Request 113730: Fix kpty standalone build

2013-11-09 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113730/ --- Review request for KDE Frameworks. Repository: kdelibs Description

kdesrc-build build failures

2013-11-09 Thread Stefanie Dargel
Hi, when building kf5 in a clean directory with kdesrc-build plasma-framework fails to build. it depends on kde-kactivities, which is scheduled to be compiled after plasma-framework. thus plasma-framework builds fine the second time. kde-workspace fails, because it requires QImageBlitz, which

Re: kdesrc-build build failures

2013-11-09 Thread Ivan Čukić
On Friday 08 November 2013 18:04:08 Stefanie Dargel wrote: Hi, when building kf5 in a clean directory with kdesrc-build plasma-framework fails to build. it depends on kde-kactivities, which is scheduled to be compiled after plasma-framework. thus plasma-framework builds fine the second

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

2013-11-09 Thread Àlex Fiestas
On Nov. 9, 2013, 12:47 a.m., David Faure wrote: staging/kio/CMakeLists.txt, line 34 http://git.reviewboard.kde.org/r/113723/diff/1/?file=212052#file212052line34 Why? KDED doesn't provide a library. It provides a DBus interface (.xml) that is installed and later on used in

Re: kdelibs/interfaces/khexedit

2013-11-09 Thread Friedrich W. H. Kossebau
Hi David, Am Samstag, 9. November 2013, 00:39:27 schrieb David Faure: Hi Friedrich, I'm looking at interfaces/khexedit in kdelibs-frameworks, and wondering what to do with it. Are you still happy with it? Should we bring it into the KF5 world? If so, we need to find a place for it.