On Nov. 28, 2013, 3:43 p.m., Kevin Ottens wrote:
Looks fine to me. Makes me wonder if we want to drop the K for the target
name KF5::ConfigCore? Just like Qt5Widgets becomes Qt5::Widgets...
Martin Klapetek wrote:
Can do. Imho it makes sense but I'll wait for some other opinions so
On Nov. 28, 2013, 3:43 p.m., Kevin Ottens wrote:
Looks fine to me. Makes me wonder if we want to drop the K for the target
name KF5::ConfigCore? Just like Qt5Widgets becomes Qt5::Widgets...
Martin Klapetek wrote:
Can do. Imho it makes sense but I'll wait for some other opinions so
See http://build.kde.org/job/kdelibs_frameworks_qt5/1801/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Friday 29 November 2013 08:53:06 Kevin Ottens wrote:
KColorDialog and KFontDialog are out of the picture. We contributed
to the upstream QColorDialog and QFontDialog so that they have the
features we needed out of the box. We only need to do something
for the file dialog.
Not sure if we
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114195/#review44794
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114200/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114200/#review44796
---
No, in KDE4 times, you got KLocalizedString though
On Nov. 29, 2013, 1:28 p.m., Albert Astals Cid wrote:
No, in KDE4 times, you got KLocalizedString though klocalizedstring.h, if
people is including KLocale just for KLocalizedString that's wrong and i
think adding this include is doing people a dis-service by maing think they
depend
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114182/
---
(Updated Nov. 29, 2013, 1:04 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114184/
---
(Updated Nov. 29, 2013, 1:28 p.m.)
Review request for KDE Frameworks.
On Nov. 29, 2013, 8:52 a.m., Kevin Ottens wrote:
tier4/frameworkintegration/src/kstyle/kstyle.h, line 1518
http://git.reviewboard.kde.org/r/114184/diff/2/?file=220988#file220988line1518
If you use Q_DECL_OVERRIDE, no need to repeat the virtual (applies to
most of the methods in
On Friday 29 November 2013 12:45:42 Hugo Pereira Da Costa wrote:
On 11/29/2013 12:22 PM, Kevin Ottens wrote:
On Friday 29 November 2013 12:00:38 Christoph Feck wrote:
- allows limiting to only change family, style, or size
To upstream if that's used (IIRC almost no user again).
If I
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114050/
---
(Updated Nov. 29, 2013, 2:42 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114050/#review44803
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114184/#review44804
---
Looks good to me !
I'll try the patch some time this week-end,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114208/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114208/
---
(Updated Nov. 29, 2013, 4:37 p.m.)
Review request for KDE Frameworks.
El Divendres, 29 de novembre de 2013, a les 12:22:48, Kevin Ottens va
escriure:
On Friday 29 November 2013 12:00:38 Christoph Feck wrote:
On Friday 29 November 2013 08:53:06 Kevin Ottens wrote:
KColorDialog and KFontDialog are out of the picture. We contributed
to the upstream
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114184/#review44847
---
Sorry, a couple more things...
19 matches
Mail list logo
