reviewboard repository

2013-12-24 Thread Michal Humpula
Hi there, I was trying to post a patch for kparts today, but failed to find a kparts repository in reviewboard. So, what is the current way of submitting patch to any of frameworks libs? Cheers Michal ___ Kde-frameworks-devel mailing list

Re: What are the plans with CamelCase includes?

2013-12-24 Thread Alex Merry
On 24/12/13 07:38, Friedrich W. H. Kossebau wrote: Hi, what are the plans with offering CamelCase includes in KF5 (e.g. #include KLocale)? On a quick search could not find anything mentioned somewhere. If I saw correctly, then currently CamelCase includes (for existing classes) are only

Re: reviewboard repository

2013-12-24 Thread Alex Merry
On 24/12/13 09:57, Michal Humpula wrote: Hi there, I was trying to post a patch for kparts today, but failed to find a kparts repository in reviewboard. So, what is the current way of submitting patch to any of frameworks libs? Patch attached to an email to this list. However, we're

[KParts] patch: don't emit urlChanged, when url is the same

2013-12-24 Thread Michal Humpula
Hi there, as suggested without fully functional reviewboard, here is the little patch for discussion. Emit urlChanged only when actually changing url trough setUrl. The drawback of this is that now the fast assignment is replaced by possibly expensive string comparison. On the other hand,

Re: [KParts] patch: don't emit urlChanged, when url is the same

2013-12-24 Thread David Faure
On Tuesday 24 December 2013 12:30:56 Michal Humpula wrote: Hi there, as suggested without fully functional reviewboard, here is the little patch for discussion. Emit urlChanged only when actually changing url trough setUrl. The drawback of this is that now the fast assignment is replaced

Re: What are the plans with CamelCase includes?

2013-12-24 Thread Aleix Pol
On Tue, Dec 24, 2013 at 12:14 PM, Alex Merry k...@randomguy3.me.uk wrote: On 24/12/13 07:38, Friedrich W. H. Kossebau wrote: Hi, what are the plans with offering CamelCase includes in KF5 (e.g. #include KLocale)? On a quick search could not find anything mentioned somewhere. If I

Re: What are the plans with CamelCase includes?

2013-12-24 Thread Bhushan Shah
Hello, On Tue, Dec 24, 2013 at 5:59 PM, Aleix Pol aleix...@kde.org wrote: I'll try to take some time after the 26th to do it. If somebody wants to do it meanwhile, please do and I'll review it. I have some spare time and want to do it.. If I want to check one example for it.. the code in

Re: [KParts] patch: don't emit urlChanged, when url is the same

2013-12-24 Thread David Faure
On Tuesday 24 December 2013 13:50:29 Michal Humpula wrote: On Tuesday 24 of December 2013 13:22:05 David Faure wrote: On Tuesday 24 December 2013 12:30:56 Michal Humpula wrote: Hi there, as suggested without fully functional reviewboard, here is the little patch for discussion.

Re: [KParts] patch: don't emit urlChanged, when url is the same

2013-12-24 Thread Michal Humpula
On Tuesday 24 of December 2013 14:05:36 David Faure wrote: On Tuesday 24 December 2013 13:50:29 Michal Humpula wrote: On Tuesday 24 of December 2013 13:22:05 David Faure wrote: On Tuesday 24 December 2013 12:30:56 Michal Humpula wrote: Hi there, as suggested without fully

XDG_APPS_INSTALL_DIR and KStandardDirs

2013-12-24 Thread Alex Merry
This got a bit lost in the other thread on the kde4support tests... I want to advocate setting XDG_APPS_INSTALL_DIR to be $CMAKE_INSTALL_PREFIX/share/applications instead of $CMAKE_INSTALL_PREFIX/share/applications/kde5. I think we should be putting our application desktop files directory in