---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115137/
---
Review request for KDE Frameworks, kdewin and kwin.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115140/
---
Review request for kde-workspace and KDE Frameworks.
Repository:
On Jan. 19, 2014, 8:07 p.m., David Faure wrote:
src/imageformats/CMakeLists.txt, line 53
https://git.reviewboard.kde.org/r/115120/diff/1/?file=234669#file234669line53
Remind me, who uses these desktop files?
Only the kde4support code, right?
Yep. I must get round to
On Jan. 7, 2014, 9:43 p.m., Alexander Neundorf wrote:
The motivation was that if somebody had set up carefully his install dirs
for kdelibs, he simply wanted to point a following project to the same
CMAKE_INSTALL_PREFIX, and have all the other install dirs automatically use
the same
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114904/#review47759
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114904/
---
(Updated Jan. 20, 2014, 10:34 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115141/
---
Review request for KDE Frameworks.
Repository: kcoreaddons
Description
On Jan. 19, 2014, 8:07 p.m., David Faure wrote:
src/imageformats/CMakeLists.txt, line 53
https://git.reviewboard.kde.org/r/115120/diff/1/?file=234669#file234669line53
Remind me, who uses these desktop files?
Only the kde4support code, right?
Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115137/#review47760
---
src/kwindowsystem.h
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115142/
---
Review request for KDE Frameworks, Aurélien Gâteau and Gregor Mi.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115142/#review47765
---
Ship it!
Ship It!
- Alex Merry
On Jan. 20, 2014, 11:07
On Sunday 19 January 2014 23:02:09 Valentin Rusu wrote:
Hello,
kwallet-framework tests now (correctly) work when launched from a KF5
session. kwalletd pop-ups password dialogs using KF5/Qt5 (yes!).
I also added SKIP for the case where there's no graphical session, thinking
that the CI
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115142/
---
(Updated Jan. 20, 2014, 11:32 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115142/#review47766
---
This review has been submitted with commit
On Monday 20 January 2014 14:00:28 Michal Humpula wrote:
Hi there,
does anyone know, what are the ./configure params the Qt is compiled on
Jenkins machine with? There is some failing test in kate due to assertion in
Qt and I'm failing to reproduce the error locally.
You can check the build
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115137/
---
(Updated Jan. 20, 2014, 2:14 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115137/#review4
---
s/screen/output
A screen is a virtual surface that may cover
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115147/
---
(Updated Jan. 20, 2014, 2:03 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115147/
---
Review request for KDE Frameworks.
Repository: knotifications
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115147/#review47781
---
src/kpassivepopup.cpp
On Jan. 20, 2014, 2:17 p.m., Martin Gräßlin wrote:
src/kpassivepopup.cpp, line 37
https://git.reviewboard.kde.org/r/115147/diff/1/?file=234805#file234805line37
why is the QScreen include needed? Looks like the changes don't use it
The line window-screen()-availableGeometry(); (477)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115147/
---
(Updated Jan. 20, 2014, 2:22 p.m.)
Review request for KDE Frameworks.
On Jan. 20, 2014, 3:17 p.m., Martin Gräßlin wrote:
src/kpassivepopup.cpp, lines 471-473
https://git.reviewboard.kde.org/r/115147/diff/1/?file=234805#file234805line471
is this comment still valid? QXcbWindow knows the concept of foreign
windows. So maybe the code could just be
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115101/#review47785
---
src/kmessagewidget.h
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115140/#review47786
---
kde-workspace doesn't explicitly need attica anymore, you
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115140/
---
(Updated Jan. 20, 2014, 3:25 p.m.)
Review request for kde-workspace and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115140/#review47802
---
Ship it!
Ship It!
- Christophe Giboudeaux
On Jan. 20,
On Jan. 20, 2014, 3:30 p.m., Christophe Giboudeaux wrote:
Ship It!
I do not have commit rights. Could you please commit the patch? The patch has
been formatted with git-format-patch. Thanks!
- Stefano
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115153/
---
Review request for KDE Frameworks.
Repository: knotifications
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115140/#review47807
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115140/
---
(Updated Jan. 20, 2014, 3:49 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115153/#review47808
---
Ship it!
Ship It!
- Martin Klapetek
On Jan. 20, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115153/
---
(Updated Jan. 20, 2014, 3:56 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115153/#review47809
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115101/
---
(Updated Jan. 20, 2014, 4:12 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115101/#review47816
---
Ship it!
Ship It!
- Aurélien Gâteau
On Jan. 20, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115101/#review47817
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115063/#review47818
---
Ship it!
No need for another diff
thanks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115093/#review47820
---
FWIW it works well for me.
- Michael Palimaka
On Jan. 17,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115063/#review47823
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115063/
---
(Updated Jan. 20, 2014, 4:59 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115137/#review47824
---
given the ratio by this property is set (often) and read
See http://build.kde.org/job/ktexteditor_master_qt5/81/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Jan. 20, 2014, 2:17 p.m., Martin Gräßlin wrote:
src/kpassivepopup.cpp, lines 471-473
https://git.reviewboard.kde.org/r/115147/diff/1/?file=234805#file234805line471
is this comment still valid? QXcbWindow knows the concept of foreign
windows. So maybe the code could just be
See http://build.kde.org/job/ktexteditor_master_qt5/82/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Monday, January 20, 2014 12:32:04 PM David Faure wrote:
On Sunday 19 January 2014 23:02:09 Valentin Rusu wrote:
Hello,
kwallet-framework tests now (correctly) work when launched from a KF5
session. kwalletd pop-ups password dialogs using KF5/Qt5 (yes!).
I also added SKIP for the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115093/#review47840
---
Ship it!
Looks good, thanks a lot!
- Aurélien Gâteau
On
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115093/
---
(Updated Jan. 20, 2014, 10:10 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115093/#review47846
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115093/#review47843
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115093/#review47844
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115093/#review47845
---
This review has been submitted with commit
On Tue, Jan 21, 2014 at 2:00 AM, Michal Humpula
michal.hump...@seznam.cz wrote:
Hi there,
does anyone know, what are the ./configure params the Qt is compiled on
Jenkins machine with? There is some failing test in kate due to assertion in
Qt and I'm failing to reproduce the error locally.
El Dilluns, 20 de gener de 2014, a les 23:39:32, Valentin Rusu va escriure:
On Monday, January 20, 2014 01:44:37 AM šumski wrote:
On Saturday 11 of January 2014 11:15:47 Michael Palimaka wrote:
...
Any news on renaming the remaining binaries?
Just to follow up on this - Jonathan
On Tue, Jan 21, 2014 at 12:26 AM, David Gil Oliva
davidgilol...@gmail.comwrote:
Hi!
*kcompletionuitest.cpp*
In kcompletionuitest.cpp I have found many uses of QStringLiteral that
perhaps aren't necessary, but I'm not sure:
Form1::Form1(QWidget *parent)
: QWidget(parent)
{
Hello!
On Tue, Jan 21, 2014 at 1:19 AM, Àlex Fiestas afies...@kde.org wrote:
In the plasma sprint we have done a session to plan what we are going to do
with kde-workspace/kde-runtime repositories, here is the proposal we came
with.
We are going to create 2 new repos called plasma-desktop
On Jan. 20, 2014, 3:17 p.m., Martin Gräßlin wrote:
src/kpassivepopup.cpp, lines 471-473
https://git.reviewboard.kde.org/r/115147/diff/1/?file=234805#file234805line471
is this comment still valid? QXcbWindow knows the concept of foreign
windows. So maybe the code could just be
57 matches
Mail list logo
