Review Request 115209: Fix KDoctools build on Windows

2014-01-21 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano.

Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-21 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Review Request 115212: Fix windows build + 1 compiler warning

2014-01-21 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115212/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

2014-01-21 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115210/ --- (Updated Jan. 22, 2014, 2:56 a.m.) Review request for Build System,

Re: Authors, maintainers and licenses in apidox

2014-01-21 Thread Kevin Ottens
On Tuesday 21 January 2014 17:18:36 Alex Merry wrote: Traditionally, the front pages of our apidox has included a list of authors, the maintainer(s) and the license. This is obviously duplicating/summarising information stored elsewhere, and is easy to let get out of date. Yes... definitely

Re: Split classes into separate files?

2014-01-21 Thread Kevin Ottens
Hello, On Wednesday 22 January 2014 00:30:19 David Gil Oliva wrote: I'm revising KCompletion and I have found that in kcompletion.h you can see the declaration of KCompletionBase (which is defined in a separate file) and KCompletionMatches (which is defined in kcompletion.cpp). I think I

Re: Review Request 115190: Add unit test for KWindowInfo on X11

2014-01-21 Thread Martin Gräßlin
On Jan. 21, 2014, 11:42 p.m., Ben Cooksley wrote: I'm afraid the test fails Martin. Guess KWin and Openbox behave differently in some areas. 5/9 Test #5: kwindowsystem-kwindowinfox11test ..***Failed9.96 sec * Start testing of KWindowInfoX11Test * Config:

Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

2014-01-21 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/ --- Review request for KDE Frameworks and Luigi Toscano. Repository:

Re: Review Request 115190: Add unit test for KWindowInfo on X11

2014-01-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115190/ --- (Updated Jan. 22, 2014, 8:14 a.m.) Review request for KDE Frameworks and

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-21 Thread David Narváez
On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: KF5DocToolsMacros.cmake, lines 166-172 https://git.reviewboard.kde.org/r/115077/diff/1/?file=234284#file234284line166 These should *not* be renamed, as they are compatibility macros. However, they should probably be moved to

<    1   2