---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115387/#review48591
---
Builds and installs fine. I would let more experienced devs
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115269/#review48597
---
I would like to commit this soon if there are no comments.
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115269/#review48598
---
Ship it!
Looks sensible. Just one thing while you're
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115203/#review48600
---
src/config-strlcpy.h.cmake
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115398/
---
Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115358/#review48604
---
Ship it!
Looks good.
- Aurélien Gâteau
On Jan. 28, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115394/#review48605
---
Looks good. Minor nitpicks:
- I would use `#include
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115358/
---
(Updated Jan. 30, 2014, 1:33 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115358/#review48606
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115388/#review48607
---
Ship it!
Looks good to me.
- Aurélien Gâteau
On Jan. 29,
On Wed, Jan 29, 2014, at 8:38, Kevin Krammer wrote:
On Wednesday, 2014-01-29, 14:29:42, Mark Gaiser wrote:
Yeah, i've had that issue quite a few times.
Now since i use gmail i either have an easy reply-to-all option or
(and that's even better) a labs plugin that automatically does
On 30/01/14 13:50, Aurélien Gâteau wrote:
You can avoid this (on the receiving side) by editing your personal
mailing list settings. Quoting mailman settings page:
Avoid duplicate copies of messages?
When you are listed explicitly in the To: or Cc: headers of a list
message, you can opt
See http://build.kde.org/job/plasma-framework_master_qt5/1103/
--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 3 in workspace
http://build.kde.org/job/plasma-framework_master_qt5/ws/
Running Prebuild
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115401/
---
Review request for KDE Frameworks.
Repository: kde4support
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115401/#review48613
---
Ship it!
Ship It!
- Alex Merry
On Jan. 30, 2014, 2:10
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115401/#review48614
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115401/
---
(Updated Jan. 30, 2014, 2:32 p.m.)
Status
--
This change has been
See http://build.kde.org/job/plasma-framework_master_qt5/1104/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115388/
---
(Updated Jan. 30, 2014, 2:44 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115388/#review48619
---
This review has been submitted with commit
On Jan. 30, 2014, 11:47 a.m., Alex Merry wrote:
CMakeLists.txt, lines 52-55
https://git.reviewboard.kde.org/r/115269/diff/1/?file=235515#file235515line52
Make this unconditional (ie: replace all four lines by just the
find_package line)
Will do, thanks.
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115330/#review48620
---
Ship it!
Ship It!
- David Edmundson
On Jan. 27, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115255/#review48624
---
Ship it!
Ship It!
- David Edmundson
On Jan. 27, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/#review48622
---
src/kstartupinfo.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115269/
---
(Updated Jan. 30, 2014, 2:51 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115269/#review48625
---
This review has been submitted with commit
kde4support has some files which clash with the kdelibs4 equivalents.
/usr/share/locale/all_languages
which I proposed to change to kf5_all_lanuages
https://git.reviewboard.kde.org/r/115401/
But there's also /usr/share/locale/en_US/entry.desktop which clases
with the kdelibs4 equivalent.
On 01/30/2014 04:35 AM, Alex Merry wrote:
On 29/01/14 17:29, Michael Palimaka wrote:
Hi,
In a some (not all) tier 3 frameworks, we check for transitive dependencies:
#NOTE: here the dependencies of dependencies are displayed as well, this
shouldn't be needed
#after cmake 3.0.0 is released
See http://build.kde.org/job/khtml_master_qt5/27/changes
Changes:
[martin.sandsmark] don't install unused dbus interface
--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 3 in workspace
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115398/#review48637
---
closing as commented out in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115398/
---
(Updated Jan. 30, 2014, 3:36 p.m.)
Status
--
This change has been
See http://build.kde.org/job/khtml_master_qt5/28/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Wed, Jan 29, 2014, at 9:35, Alex Merry wrote:
On 29/01/14 17:29, Michael Palimaka wrote:
Hi,
In a some (not all) tier 3 frameworks, we check for transitive dependencies:
#NOTE: here the dependencies of dependencies are displayed as well, this
shouldn't be needed
#after cmake
On Jan. 20, 2014, 5 p.m., Thomas Lübking wrote:
given the ratio by this property is set (often) and read (rarely), i wonder
whether we could establish a semi-async functionality, where the client
sends a message to have the property updated, then syncs, reads and returns
the updated
On 01/31/2014 03:12 AM, Aurélien Gâteau wrote:
On Wed, Jan 29, 2014, at 9:35, Alex Merry wrote:
On 29/01/14 17:29, Michael Palimaka wrote:
Hi,
In a some (not all) tier 3 frameworks, we check for transitive dependencies:
#NOTE: here the dependencies of dependencies are displayed as well,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115404/
---
Review request for KDE Frameworks.
Repository: kemoticons
Description
On 30/01/14 16:12, Aurélien Gâteau wrote:
The issue only occurred with CMake 2.8.12 when building kdelibs as a
whole. It is no longer a problem now that the repositories have been
split. Therefore, I think you can go on and remove those dependencies.
I don't understand that - all the
On Jan. 20, 2014, 5 p.m., Thomas Lübking wrote:
given the ratio by this property is set (often) and read (rarely), i wonder
whether we could establish a semi-async functionality, where the client
sends a message to have the property updated, then syncs, reads and returns
the updated
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115404/#review48652
---
Builds with what version of CMake? Please test with 2.8.12.0
A bigger problem is there's no copyright holder or licence for this framework,
anyone know how to find those?
Jonathan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
As there were no real objections and lots of +1s, I'm going to request this
change.
Cheers
--
Martin Klapetek | KDE Developer
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Tuesday 28 January 2014 15:05:30 Kevin Funk wrote:
Am Sonntag, 26. Januar 2014, 18:53:42 schrieb Gregor Mi:
With another addition to qfiledialogtest in
frameworks/frameworkintegration another potential bug can be exposed:
Calling
$ ./qfiledialogtest --nameFilter c (*.cpp)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115394/
---
(Updated Jan. 30, 2014, 10:59 p.m.)
Review request for KDE Frameworks.
On 30/01/14 18:34, Jonathan Riddell wrote:
A bigger problem is there's no copyright holder or licence for this
framework, anyone know how to find those?
Which framework? Do you mean kapidox?
All the Python files should have copyright headers at the top, and the
LICENSE file says it is
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115330/
---
(Updated Jan. 31, 2014, 7:54 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115330/#review48667
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115255/#review48668
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115255/
---
(Updated Jan. 31, 2014, 7:55 a.m.)
Status
--
This change has been
48 matches
Mail list logo
