Re: kf5 alpha 1 : attica?

2014-02-06 Thread Laszlo Papp
On Thu, Feb 6, 2014 at 12:21 AM, David Faure fa...@kde.org wrote: [resent with Frederik's correct email address] On Thursday 06 February 2014 00:53:53 Frederik Gladhorn wrote: Thanks a lot, I really appreciate it. Some issues left: - who do we write down as maintainer for attica? - can I

Taking over maintainer role for KConfig/KDNSSD

2014-02-06 Thread Matthew Dawson
Hi all, Just to let everyone know, I'm taking over the role of maintainer for both KConfig and KDNSSD. I'm most contactable at this email address ( matt...@mjdsystems.ca ). I'm usually idling on IRC with a nick of MJD, but I'm not always watching IRC. I'll do my best to watch over the

Integration Plugin not picked on Wayland

2014-02-06 Thread Martin Gräßlin
Hi frameworkers, I just did the ultimate test of running Kate on Wayland (Weston) [1] and noticed that our integration plugin seems not to get picked. At least Oxygen is not used as the widget style and icons in menus are missing, etc. See screenshot in [2]. Does anyone have an idea why that

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

2014-02-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/ --- (Updated Feb. 6, 2014, 10:19 a.m.) Review request for KDE Frameworks,

Re: Integration Plugin not picked on Wayland

2014-02-06 Thread Kevin Ottens
Hello, On Thursday 06 February 2014 09:37:39 Martin Gräßlin wrote: Does anyone have an idea why that might be the case and how to properly investigate this? Guessing: Does the platform plugin for wayland reimplement QPlatformIntegration::themeNames()? Ideally it should provide the same list

Re: Re: Integration Plugin not picked on Wayland

2014-02-06 Thread Martin Gräßlin
On Thursday 06 February 2014 10:40:06 Kevin Ottens wrote: Hello, On Thursday 06 February 2014 09:37:39 Martin Gräßlin wrote: Does anyone have an idea why that might be the case and how to properly investigate this? Guessing: Does the platform plugin for wayland reimplement

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-06 Thread Kevin Krammer
On Feb. 5, 2014, 3:51 p.m., Aurélien Gâteau wrote: Wow, great work! I attempted doing this some time ago, and all I managed to produce was two unit tests :). Looks good to me and works fine here. Just two (really minor) nitpicks. Kevin Krammer wrote: Thanks :) Good to hear

Re: Re: Re: Integration Plugin not picked on Wayland

2014-02-06 Thread Martin Gräßlin
Martin GräßlinOn Thursday 06 February 2014 10:49:36 wrote: On Thursday 06 February 2014 10:40:06 Kevin Ottens wrote: Hello, On Thursday 06 February 2014 09:37:39 Martin Gräßlin wrote: Does anyone have an idea why that might be the case and how to properly investigate this?

Re: Re: Re: Re: Integration Plugin not picked on Wayland

2014-02-06 Thread Martin Gräßlin
Martin GräßlinOn Thursday 06 February 2014 10:54:42 wrote: Yes, fixes it with the result that app crashes on startup, because Oxygen uses xcb unconditionally. /me goes fixing Oxygen :-) and the screenshot of Kate with Oxygen on Wayland:

Re: Splitting kde-workspace and kde-runtime proposal

2014-02-06 Thread Aleix Pol
On Tue, Jan 28, 2014 at 6:34 PM, Aleix Pol aleix...@kde.org wrote: On Mon, Jan 27, 2014 at 3:21 PM, David Edmundson da...@davidedmundson.co.uk wrote: There is an existing page about slitting runtime here: http://community.kde.org/Frameworks/Epics/New_Runtime_Organization linked to from

Re: Review Request 115504: Only perform tests for plugins that are built

2014-02-06 Thread Alex Merry
On Feb. 5, 2014, 6:52 p.m., Michael Palimaka wrote: CMakeLists.txt, lines 28-30 https://git.reviewboard.kde.org/r/115504/diff/1/?file=242131#file242131line28 Curious, what's the advantage to having a new variable vs. checking Qt5PrintSupport_FOUND later? Well, the relationship

Re: Review Request 115502: Fix math function checks

2014-02-06 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115502/ --- (Updated Feb. 6, 2014, 12:05 p.m.) Status -- This change has been

Re: Review Request 115502: Fix math function checks

2014-02-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115502/#review49110 --- This review has been submitted with commit

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

2014-02-06 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/#review49113 --- Ship it! Ship It! - Alexander Richardson On Feb. 6, 2014,

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

2014-02-06 Thread Alexander Richardson
On Feb. 6, 2014, 2:14 a.m., Alexander Richardson wrote: src/kwindowsystem.cpp, line 342 https://git.reviewboard.kde.org/r/115459/diff/2-3/?file=242085#file242085line342 The non-MSVC macro has a return statement, I think this one needs it as well Andrius da Costa Ribas wrote:

Re: Review Request 115495: Make kgenframeworksapidox generate dependency diagrams

2014-02-06 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115495/#review49120 --- Instant issue: the README.md claims that yapgvb is only

Re: Review Request 115495: Make kgenframeworksapidox generate dependency diagrams

2014-02-06 Thread Aurélien Gâteau
On Feb. 6, 2014, 1:56 p.m., Alex Merry wrote: Instant issue: the README.md claims that yapgvb is only needed to generate the diagrams, but not having it installed causes kgenframeworksapidocs to fail with an ImportError (it imports depdiagram, which imports yapgvb). You need to

Review Request 115517: Do not crash if there is no QMimeData in decodeIsCutSelection

2014-02-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115517/ --- Review request for KDE Frameworks and David Faure. Repository: kio

Re: Review Request 115495: Make kgenframeworksapidox generate dependency diagrams

2014-02-06 Thread Alex Merry
On Feb. 6, 2014, 12:56 p.m., Alex Merry wrote: Instant issue: the README.md claims that yapgvb is only needed to generate the diagrams, but not having it installed causes kgenframeworksapidocs to fail with an ImportError (it imports depdiagram, which imports yapgvb). You need to

Re: Review Request 115517: Do not crash if there is no QMimeData in decodeIsCutSelection

2014-02-06 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115517/#review49126 --- I think the tests would make more sense at the calling sites.

Re: Review Request 115481: Improve knotifyconfig dependencies

2014-02-06 Thread Alex Merry
On Feb. 5, 2014, 11:58 a.m., Alex Merry wrote: tests/CMakeLists.txt, lines 7-20 https://git.reviewboard.kde.org/r/115481/diff/2/?file=241988#file241988line7 These should all be PURPOSE, not DESCRIPTION. Also, Qt5Test should have its PURPOSE set as well. Michael Palimaka

Re: Review Request 115517: Do not crash if there is no QMimeData in decodeIsCutSelection

2014-02-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115517/ --- (Updated Feb. 6, 2014, 2:37 p.m.) Review request for KDE Frameworks and

Re: Review Request 115517: Do not crash if there is no QMimeData in decodeIsCutSelection

2014-02-06 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115517/#review49128 --- Ship it! OK, that works. - Alex Merry On Feb. 6, 2014,

Re: Review Request 115495: Make kgenframeworksapidox generate dependency diagrams

2014-02-06 Thread Aurélien Gâteau
On Feb. 6, 2014, 1:56 p.m., Alex Merry wrote: Instant issue: the README.md claims that yapgvb is only needed to generate the diagrams, but not having it installed causes kgenframeworksapidocs to fail with an ImportError (it imports depdiagram, which imports yapgvb). You need to

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

2014-02-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/#review49135 --- This review has been submitted with commit

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

2014-02-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/ --- (Updated Feb. 6, 2014, 2:22 p.m.) Status -- This change has been

Re: Review Request 115481: Improve knotifyconfig dependencies

2014-02-06 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115481/ --- (Updated Feb. 6, 2014, 3:40 p.m.) Status -- This change has been

Re: Review Request 115481: Improve knotifyconfig dependencies

2014-02-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115481/#review49138 --- This review has been submitted with commit

Re: Review Request 115520: Remove kded transitive dependencies

2014-02-06 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115520/#review49145 --- Ship it! Ship It! - Alex Merry On Feb. 6, 2014, 4:41

Re: Review Request 115520: Remove kded transitive dependencies

2014-02-06 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115520/ --- (Updated Feb. 6, 2014, 5:41 p.m.) Status -- This change has been

Re: Review Request 115520: Remove kded transitive dependencies

2014-02-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115520/#review49146 --- This review has been submitted with commit

Re: kf5 alpha 1 : attica?

2014-02-06 Thread Kevin Ottens
On Thursday 06 February 2014 07:23:30 Kevin Ottens wrote: On Thursday 06 February 2014 01:15:15 David Faure wrote: Some issues left: - who do we write down as maintainer for attica? Good question, let's mark it TBD until someone dares to step up for it. That said, obviously, if there's

Re: kf5 alpha 1 : attica?

2014-02-06 Thread Kevin Ottens
On Thursday 06 February 2014 07:23:30 Kevin Ottens wrote: On Thursday 06 February 2014 01:15:15 David Faure wrote: Some issues left: - who do we write down as maintainer for attica? Good question, let's mark it TBD until someone dares to step up for it. That said, obviously, if there's

alpha1 release

2014-02-06 Thread David Faure
I have packaged up KF5 alpha 1 and uploaded it for packagers. Can we consider KF5 frozen all of tomorrow (Friday 7) ? This way if there's any showstopper bugfix I can redo the tarballs without bringing in unrelated changes which might create other problems. Sorry for the productivity loss :-)

Review Request 115524: Hide a private method and a private slot of KComboBox behind the d-pointer

2014-02-06 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115524/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Review Request 115524: Hide a private method and a private slot of KComboBox behind the d-pointer

2014-02-06 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115524/ --- (Updated Feb. 6, 2014, 10:35 p.m.) Review request for KDE Frameworks.

Review Request 115525: Deprecate slots in KCompletion and convert into slots the methods they call

2014-02-06 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115525/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Taking over maintainer role for KConfig/KDNSSD

2014-02-06 Thread Matthew Dawson
On February 6, 2014 12:12:18 PM Alex Merry wrote: On 06/02/14 07:38, Matthew Dawson wrote: I'll do my best to watch over the frameworks, but I'm not sure how much I'll be able to push them forward in the near future. At the very least I'll keep an eye on any review requests that come in on

Review Request 115526: Refactor private class member variables of KCompletionBase for readability

2014-02-06 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115526/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Review Request 115525: Deprecate slots in KCompletion and convert into slots the methods they call

2014-02-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115525/#review49161 --- Ship it! Looks good to me - Aleix Pol Gonzalez On Feb. 6,

Re: alpha1 release

2014-02-06 Thread Martin Klapetek
Hey, On Thu, Feb 6, 2014 at 11:30 PM, David Faure fa...@kde.org wrote: I have packaged up KF5 alpha 1 and uploaded it for packagers. Can we consider KF5 frozen all of tomorrow (Friday 7) ? I have quite some extensive changes for KNotifications (basically merging KNotify daemon to

Re: alpha1 release

2014-02-06 Thread Kevin Ottens
Hello, On Friday 07 February 2014 06:25:46 Martin Klapetek wrote: On Thu, Feb 6, 2014 at 11:30 PM, David Faure fa...@kde.org wrote: I have packaged up KF5 alpha 1 and uploaded it for packagers. Can we consider KF5 frozen all of tomorrow (Friday 7) ? I have quite some extensive changes