Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-16 Thread Frank Reininghaus
On Feb. 15, 2014, 8:28 p.m., David Faure wrote: Yeah the description is wrong. Making something Q_MOVABLE means that inserting into the list, or the copying that happens when reallocating for more space, will be able to memmove() instead of copy-constructing items. This doesn't

Re: Review Request 115421: Clean up the CMakeLists.txt files

2014-02-16 Thread Kevin Ottens
Hello, On Saturday 15 February 2014 23:27:40 David Faure wrote: Looks like a historical thing to me, from before kstyle got integrated into frameworkintegration. If I read git log correctly, this src/kstyle/CMakeLists.txt file comes from Kévin's commit 3864cfe2347af01b. Kévin, any reason

Re: Review Request 115686: Fix mimetype declarations in json files

2014-02-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115686/#review49900 --- This review has been submitted with commit

Re: Review Request 115686: Fix mimetype declarations in json files

2014-02-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115686/ --- (Updated Feb. 16, 2014, 10:47 a.m.) Status -- This change has been

Re: Review Request 115765: Improve the ECMGenerateHeaders API with a variable for generated files

2014-02-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115765/#review49901 --- This review has been submitted with commit

Re: Review Request 115765: Improve the ECMGenerateHeaders API with a variable for generated files

2014-02-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115765/ --- (Updated Feb. 16, 2014, 10:49 a.m.) Status -- This change has been

Re: Review Request 115767: Use the new syntax for ecm_generate_headers()

2014-02-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115767/#review49903 --- This review has been submitted with commit

Re: Review Request 115767: Use the new syntax for ecm_generate_headers()

2014-02-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115767/ --- (Updated Feb. 16, 2014, 10:54 a.m.) Status -- This change has been

Re: Review Request 115766: Use the new ecm_generate_headers() syntax

2014-02-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115766/ --- (Updated Feb. 16, 2014, 10:55 a.m.) Status -- This change has been

Re: Review Request 115766: Use the new ecm_generate_headers() syntax

2014-02-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115766/#review49904 --- This review has been submitted with commit

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-16 Thread Alex Merry
On Feb. 15, 2014, 10:33 p.m., David Faure wrote: src/imageformats/CMakeLists.txt, line 137 https://git.reviewboard.kde.org/r/115355/diff/4/?file=244028#file244028line137 don't you mean removing the whole use of find_package(SharedMimeInfo), once we can depend on smi 1.3? Why

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-16 Thread David Faure
On Feb. 15, 2014, 10:33 p.m., David Faure wrote: src/imageformats/CMakeLists.txt, line 137 https://git.reviewboard.kde.org/r/115355/diff/4/?file=244028#file244028line137 don't you mean removing the whole use of find_package(SharedMimeInfo), once we can depend on smi 1.3? Why

frameworks with multiple libraries

2014-02-16 Thread David Faure
kio's KF5KIOConfig.cmake.in says, among others: find_dependency(KF5XmlGui @KF5_VERSION@) What if I only want to use KIOCore? Can we make these find_dependency calls dependent on the COMPONENTS in find_package(KF5KIO)? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in

Review Request 115773: Remove code that allows KStyle to build standalone

2014-02-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115773/ --- Review request for KDE Frameworks, David Faure and Kevin Ottens.

Re: Review Request 115700: Remove unused frameworkintegration dependencies

2014-02-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115700/#review49906 --- Just noticed this. It interacts a little with

Re: Review Request 115700: Remove unused frameworkintegration dependencies

2014-02-16 Thread Alex Merry
On Feb. 16, 2014, 11:25 a.m., Alex Merry wrote: Just noticed this. It interacts a little with https://git.reviewboard.kde.org/r/115773/ (which implemented David's suggestion to make KStyle not build standalone any more). So, in term of actual recommendations, I would commit the change

Re: Review Request 115773: Remove code that allows KStyle to build standalone

2014-02-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115773/#review49908 --- Oops, race condition with me ;) Sorry. I'm working on a

Review Request 115774: Remove code that allows KStyle to build standalone

2014-02-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115774/ --- Review request for KDE Frameworks. Repository: frameworkintegration

Re: Review Request 115773: Remove code that allows KStyle to build standalone

2014-02-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115773/ --- (Updated Feb. 16, 2014, 11:36 a.m.) Status -- This change has been

Re: Review Request 115774: Remove code that allows KStyle to build standalone

2014-02-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115774/#review49909 --- One thing worth considering as part of this is whether extra

Re: Review Request 115774: Remove code that allows KStyle to build standalone

2014-02-16 Thread David Faure
On Feb. 16, 2014, 11:40 a.m., Alex Merry wrote: One thing worth considering as part of this is whether extra integration classes should get their own libraries or be put in the same one as KStyle. If the latter, we probably want to rename KF5::Style. The kstyle lib is for KStyle

Build failed in Jenkins: kdeclarative_master_qt5 #25

2014-02-16 Thread KDE CI System
See http://build.kde.org/job/kdeclarative_master_qt5/25/changes Changes: [faure] Fix porting with prefix -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace

Jenkins build is back to normal : kdeclarative_master_qt5 #26

2014-02-16 Thread KDE CI System
See http://build.kde.org/job/kdeclarative_master_qt5/26/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115774: Remove code that allows KStyle to build standalone

2014-02-16 Thread Alex Merry
On Feb. 16, 2014, 11:40 a.m., Alex Merry wrote: One thing worth considering as part of this is whether extra integration classes should get their own libraries or be put in the same one as KStyle. If the latter, we probably want to rename KF5::Style. David Faure wrote: The

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/ --- (Updated Feb. 16, 2014, 12:14 p.m.) Review request for KDE Frameworks.

Review Request 115775: Defer to CMake's find_dependency macro if it exists

2014-02-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115775/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: frameworks with multiple libraries

2014-02-16 Thread Alex Merry
On 16/02/14 11:23, David Faure wrote: kio's KF5KIOConfig.cmake.in says, among others: find_dependency(KF5XmlGui @KF5_VERSION@) What if I only want to use KIOCore? Can we make these find_dependency calls dependent on the COMPONENTS in find_package(KF5KIO)? I dunno; what does this

Re: Review Request 115774: Remove code that allows KStyle to build standalone

2014-02-16 Thread David Faure
On Feb. 16, 2014, 11:40 a.m., Alex Merry wrote: One thing worth considering as part of this is whether extra integration classes should get their own libraries or be put in the same one as KStyle. If the latter, we probably want to rename KF5::Style. David Faure wrote: The

Re: frameworks with multiple libraries

2014-02-16 Thread David Faure
On Sunday 16 February 2014 12:19:08 Alex Merry wrote: On 16/02/14 11:23, David Faure wrote: kio's KF5KIOConfig.cmake.in says, among others: find_dependency(KF5XmlGui @KF5_VERSION@) What if I only want to use KIOCore? Can we make these find_dependency calls dependent on the

Build failed in Jenkins: krunner_master_qt5 #12

2014-02-16 Thread KDE CI System
See http://build.kde.org/job/krunner_master_qt5/12/changes Changes: [faure] Use the new syntax for ecm_generate_headers() -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Build failed in Jenkins: ktexteditor_master_qt5 #204

2014-02-16 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_master_qt5/204/changes Changes: [faure] Use the new syntax for ecm_generate_headers() (with prefix) -- [...truncated 711 lines...] [ 7%] Built target GeneratePhpXmlFiles [ 7%] Automatic moc for target

Re: Review Request 115774: Remove code that allows KStyle to build standalone

2014-02-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115774/#review49913 --- Ship it! Ship It! - Alex Merry On Feb. 16, 2014, 11:31

Re: Review Request 115774: Remove code that allows KStyle to build standalone

2014-02-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115774/#review49914 --- This review has been submitted with commit

Re: Review Request 115774: Remove code that allows KStyle to build standalone

2014-02-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115774/ --- (Updated Feb. 16, 2014, 12:53 p.m.) Status -- This change has been

Re: Build failed in Jenkins: ktexteditor_master_qt5 #204

2014-02-16 Thread Alex Merry
Yeah, you'll need to change include_directories() and/or target_include_directories() commands in a bunch of these (in this case, it's really near the top of src/CMakeLists.txt). I suggest at least doing rm -rf $PREFIX/include/KF5/FWName before building pre-push. Alex On 16/02/14 12:49, KDE CI

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-16 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/ --- (Updated Feb. 16, 2014, 6:54 p.m.) Review request for KDE Frameworks and

Re: Review Request 115741: Fix MSVC build of kinit

2014-02-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115741/#review49987 --- Ship it! Thanks! src/kwrapper/kwrapper_win.cpp

Re: Review Request 115745: kservice: Allow compiling with MSVC

2014-02-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115745/#review50002 --- Ship it! Ship It! - David Faure On Feb. 14, 2014, 12:30

Re: Review Request 115755: Fix loading of khtmlplart plugin

2014-02-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115755/#review50003 --- Ship it! Ship It! - David Faure On Feb. 15, 2014, 12:15

KF5 Update Meeting 2014-w8 Reminder

2014-02-16 Thread Kevin Ottens
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed

Re: Review Request 115724: Drop version check for Qt at least being 4.7

2014-02-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115724/ --- (Updated Feb. 17, 2014, 7:17 a.m.) Status -- This change has been

Build failed in Jenkins: knotifications_master_qt5 #26

2014-02-16 Thread KDE CI System
See http://build.kde.org/job/knotifications_master_qt5/26/ -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace http://build.kde.org/job/knotifications_master_qt5/ws/ Running Prebuild steps

Re: Review Request 115715: Remove X11 dependency from kprintutils

2014-02-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115715/ --- (Updated Feb. 17, 2014, 7:19 a.m.) Status -- This change has been

Re: Review Request 115714: Only use xtest code if we are on platform X11

2014-02-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115714/ --- (Updated Feb. 17, 2014, 7:20 a.m.) Status -- This change has been

Re: Review Request 115714: Only use xtest code if we are on platform X11

2014-02-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115714/#review50012 --- This review has been submitted with commit

Jenkins build is back to normal : knotifications_master_qt5 #27

2014-02-16 Thread KDE CI System
See http://build.kde.org/job/knotifications_master_qt5/27/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115711: Introduce a config-kstyle.h.cmake

2014-02-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115711/#review50013 --- This review has been submitted with commit

Re: Review Request 115711: Introduce a config-kstyle.h.cmake

2014-02-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115711/ --- (Updated Feb. 17, 2014, 7:26 a.m.) Status -- This change has been

Re: Review Request 115701: Improve build without X11 support in kde4support

2014-02-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115701/ --- (Updated Feb. 17, 2014, 7:29 a.m.) Status -- This change has been

Re: Review Request 115701: Improve build without X11 support in kde4support

2014-02-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115701/#review50014 --- This review has been submitted with commit