Re: Review Request 117560: ECMCreateQmFromPoFiles: adjust API to make it usable from within trunk/l10n-kf5

2014-04-16 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117560/ --- (Updated April 16, 2014, 8:28 a.m.) Status -- This change has been

Re: Review Request 117560: ECMCreateQmFromPoFiles: adjust API to make it usable from within trunk/l10n-kf5

2014-04-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117560/#review55845 --- This review has been submitted with commit

Review Request 117581: Deprecate ecm_dbus_add_activation_service()

2014-04-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117581/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Review Request 117582: Simplify D-Bus service CMake code

2014-04-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117582/ --- Review request for KDE Frameworks. Repository: kded Description

Review Request 117583: Remove use of ecm_dbus_add_activation_service()

2014-04-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117583/ --- Review request for KDE Frameworks. Repository: kwallet Description

Review Request 117585: ECMFindModuleHelpers: set traditional variables

2014-04-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117585/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Review Request 117593: ECMGeneratePriFile: Allow lib and include install dirs to be overridden

2014-04-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117593/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and

Jenkins build became unstable: kwindowsystem_master_qt5 » All,LINBUILDER #44

2014-04-16 Thread KDE CI System
See http://build.kde.org/job/kwindowsystem_master_qt5/Variation=All,label=LINBUILDER/44/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117596: ECMCreateQmFromPoFiles: Also check CMAKE_INSTALL_LOCALEDIR

2014-04-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117596/#review55888 --- This review has been submitted with commit

Re: Review Request 117596: ECMCreateQmFromPoFiles: Also check CMAKE_INSTALL_LOCALEDIR

2014-04-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117596/ --- (Updated April 16, 2014, 3:54 p.m.) Status -- This change has been

Re: Review Request 117475: kmimeassociationstest: remove kde4- prefix from desktop file names

2014-04-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117475/ --- (Updated April 16, 2014, 4:50 p.m.) Status -- This change has been

Re: Review Request 117475: kmimeassociationstest: remove kde4- prefix from desktop file names

2014-04-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117475/#review55897 --- This review has been submitted with commit

Re: Review Request 117475: kmimeassociationstest: remove kde4- prefix from desktop file names

2014-04-16 Thread Alex Merry
On April 16, 2014, 4:50 p.m., Commit Hook wrote: This review has been submitted with commit 9bbdd1615b484c229657fd0896b2dbebdea9988d by Alex Merry to branch master. Oops, wrong RR number. - Alex --- This is an automatically

Review Request 117599: Improve tests

2014-04-16 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117599/ --- Review request for KDE Frameworks. Repository: plasma-framework

Re: Review Request 117600: Allow ecm_create_qm_loader() to be passed the _SRCS variable

2014-04-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117600/ --- (Updated April 16, 2014, 4:52 p.m.) Status -- This change has been

Re: Update your copy of extra-cmake-modules

2014-04-16 Thread šumski
On Wednesday 16 of April 2014 07:36:57 Aurélien Gâteau wrote: Hi, I just pushed some changes to frameworks using Qt for translations which requires a recent version of extra-cmake-modules (you need to have 071581a3f899c881c9938efd082fd32589822b45). If you get build failures complaining

Hitting assertion in kio-trash (KF5KIOCore)

2014-04-16 Thread Kevin Funk
Hey, While running unit tests from kdevplatform I hit the following assert in trash/trashimpl.cpp (from workspace/kio-extras) Output of the unit test (which attempts to trash some folders): trying to create /home/krf/.local/share/Trash/info/.trashinfo trying to create

Review Request 117602: Remove more UPnP stuff

2014-04-16 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117602/ --- Review request for KDE Frameworks and Àlex Fiestas. Repository: solid

Jenkins build became unstable: kdelibs_stable #1063

2014-04-16 Thread KDE CI System
See http://build.kde.org/job/kdelibs_stable/1063/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string

2014-04-16 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/ --- Review request for KDE Frameworks and David Faure. Repository: kservice

Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string

2014-04-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/#review55921 --- src/plugin/kdbusservicestarter.cpp

Re: Review Request 117599: Improve tests

2014-04-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117599/#review55922 --- Ship it! Looks good, interesting work towards a more unified