Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-23 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/ --- (Updated April 23, 2014, 8:49 a.m.) Review request for KDE Frameworks

Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/ --- Review request for KDE Frameworks, Àlex Fiestas and Bhushan Shah. Bugs:

Re: KF5 Update Meeting Minutes 2014-w17

2014-04-23 Thread Luigi Toscano
On Tuesday 22 of April 2014 20:11:28 Nicolás Alvarez wrote: El martes, 22 de abril de 2014, Allen Winter win...@kde.org escribió: with Harald's help. Stuck in docbook hell at the moment (kdoctools/xslt.cpp says it can't find the customizations). Anyway, just thought I'd mention this.

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-23 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#review56264 --- src/document/katedocument.cpp

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-23 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/ --- (Updated April 23, 2014, 11:15 a.m.) Review request for KDE Frameworks

Review Request 117704: Deprecate obsolete KStartupInfo ctor

2014-04-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117704/ --- Review request for KDE Frameworks. Repository: kwindowsystem

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-23 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/#review56269 --- src/kstartupinfo.cpp

Review Request 117705: co-installability: rename kactivitymanagerd to kactivitymanagerd5

2014-04-23 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117705/ --- Review request for KDE Frameworks. Repository: kactivities Description

Review Request 117706: remove unused kwallet upgrade script

2014-04-23 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117706/ --- Review request for KDE Frameworks and Àlex Fiestas. Repository: kwallet

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-23 Thread Martin Gräßlin
On April 23, 2014, 3:03 p.m., Thomas Lübking wrote: src/kstartupinfo.cpp, line 413 https://git.reviewboard.kde.org/r/117701/diff/1/?file=267866#file267866line413 this is somehow not equivalent to the other variant (ignores silent/uninited) - the iterator should perhaps go with a

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

2014-04-23 Thread David Faure
On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote: Until now we had no problems with the data installed to bin/../share and this setup would make it impossible to have multiple independent kde setups on one system. Alexander Richardson wrote: I know. The problem is

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

2014-04-23 Thread Andrius da Costa Ribas
On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote: Until now we had no problems with the data installed to bin/../share and this setup would make it impossible to have multiple independent kde setups on one system. Alexander Richardson wrote: I know. The problem is

Re: [kdesrc-build] /: kf5: Port rc files to use branch-groups consistently.

2014-04-23 Thread David Faure
On Wednesday 05 March 2014 10:44:24 Kevin Ottens wrote: * kactivities moved under kde/kdelibs/kactivities (a very odd location in the frameworks world, but kde_projects.xml is global, not branch-dependent) Ideally should be under frameworks at some point. I'd rather have it odd in the

Re: Review Request 117708: move kioslave docs paths for co-installability

2014-04-23 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117708/#review56293 --- I think after this change many documentation links (at least

Review Request 117708: move kioslave docs paths for co-installability

2014-04-23 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117708/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: KF5 Update Meeting Minutes 2014-w17

2014-04-23 Thread Allen Winter
On Wednesday, April 23, 2014 12:40:09 PM Luigi Toscano wrote: On Tuesday 22 of April 2014 20:11:28 Nicolás Alvarez wrote: El martes, 22 de abril de 2014, Allen Winter win...@kde.org escribió: with Harald's help. Stuck in docbook hell at the moment (kdoctools/xslt.cpp says it can't

Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.

2014-04-23 Thread David Faure
On April 22, 2014, 9:50 a.m., Kevin Krammer wrote: src/lib/util/kdelibs4migration.cpp, line 81 https://git.reviewboard.kde.org/r/117511/diff/2/?file=267469#file267469line81 would QStringLiteral work here? Given the multiple implementations of QStringLiteral depending on compiler

Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.

2014-04-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117511/ --- (Updated April 23, 2014, 4:26 p.m.) Review request for KDE Frameworks,

Re: Plasma Next - Translations KCM - What Languages?

2014-04-23 Thread David Faure
On Sunday 16 March 2014 15:49:02 Chusslove Illich wrote: The related problem for me is this: why are there still standalone language packages for some of KDE software (the SC)? Other than historical reasons, the only advantage I see is installation space. But I don't see anyone complaining

Re: Review Request 117012: Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed camelcase header under $

2014-04-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117012/#review56306 --- The reason I did it this way was because existing application

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #282

2014-04-23 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/282/changes Changes: [hein] Install header for Dialog so it's publically subclassable as discussed. -- Started by upstream project plasma-framework_master_qt5 build

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #282

2014-04-23 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/282/changes Changes: [hein] Install header for Dialog so it's publically subclassable as discussed. -- Started by upstream project plasma-framework_master_qt5 build

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #283

2014-04-23 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/283/changes Changes: [hein] Revert Install header for Dialog so it's publically subclassable as discussed. -- Started by upstream project

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #283

2014-04-23 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/283/changes Changes: [hein] Revert Install header for Dialog so it's publically subclassable as discussed. -- Started by upstream project plasma-framework_master_qt5

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-23 Thread Martin Gräßlin
On April 23, 2014, 3:03 p.m., Thomas Lübking wrote: src/kstartupinfo.cpp, line 413 https://git.reviewboard.kde.org/r/117701/diff/1/?file=267866#file267866line413 this is somehow not equivalent to the other variant (ignores silent/uninited) - the iterator should perhaps go with a

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-23 Thread Martin Gräßlin
On April 23, 2014, 3:03 p.m., Thomas Lübking wrote: src/kstartupinfo.cpp, line 413 https://git.reviewboard.kde.org/r/117701/diff/1/?file=267866#file267866line413 this is somehow not equivalent to the other variant (ignores silent/uninited) - the iterator should perhaps go with a

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #284

2014-04-23 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/284/changes Changes: [notmart] always use all the borders for floating dialogs -- Started by upstream project plasma-framework_master_qt5 build number 284 originally

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #284

2014-04-23 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/284/changes Changes: [notmart] always use all the borders for floating dialogs -- Started by upstream project plasma-framework_master_qt5 build number 284

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #285

2014-04-23 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/285/changes Changes: [notmart] correct the last commit -- Started by upstream project plasma-framework_master_qt5 build number 285 originally caused by: Started by

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #285

2014-04-23 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/285/changes Changes: [notmart] correct the last commit -- Started by upstream project plasma-framework_master_qt5 build number 285 originally caused by: Started by

Randa Meetings 2014: Registration Deadline and Fundraising

2014-04-23 Thread Mario Fux
Good morning gals and guys You get this email because you're either: - Already registered on http://sprints.kde.org/sprint/212. - You're subscribed to a mailing list of a group that participates this year. - I already asked you in one way or another to come to Randa and you're not yet sure. - Or

Re: Review Request 117078: Allow compiling kio on windows

2014-04-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117078/#review56323 --- Ship it! A few comments, but none of them is a blocker.

Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string

2014-04-23 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/ --- (Updated April 23, 2014, 9:09 p.m.) Status -- This change has been

Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string

2014-04-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/#review56327 --- This review has been submitted with commit

Re: Review Request 117705: co-installability: rename kactivitymanagerd to kactivitymanagerd5

2014-04-23 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117705/#review56328 --- https://git.reviewboard.kde.org/r/115602/ - Jonathan Riddell

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-23 Thread Thomas Lübking
On April 23, 2014, 1:03 p.m., Thomas Lübking wrote: src/kstartupinfo.cpp, line 413 https://git.reviewboard.kde.org/r/117701/diff/1/?file=267866#file267866line413 this is somehow not equivalent to the other variant (ignores silent/uninited) - the iterator should perhaps go with a

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-23 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/#review56333 --- Ship it! Ship It! - Thomas Lübking On April 23, 2014,

Build failed in Jenkins: knewstuff_master_qt5 #46

2014-04-23 Thread KDE CI System
See http://build.kde.org/job/knewstuff_master_qt5/46/changes Changes: [jpwhiting] Move khotnewstuff and khotnewstuff_upload to knewstuff from kde-runtime. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/ --- (Updated April 24, 2014, 7:27 a.m.) Review request for KDE Frameworks,

Review Request 117731: Improve KStartupInfo::Private::remove_startup_info_internal

2014-04-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117731/ --- Review request for KDE Frameworks and Thomas Lübking. Repository: