Re: Review Request 117080: cleanup KDirModelTest

2014-04-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117080/#review56346 --- Ship it! I wonder why this was discarded -- other than the

Jenkins build is back to normal : knewstuff_master_qt5 #47

2014-04-24 Thread KDE CI System
See http://build.kde.org/job/knewstuff_master_qt5/47/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 » All,LINBUILDER #286

2014-04-24 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/286/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 » NoX11,LINBUILDER #286

2014-04-24 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/286/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117731: Improve KStartupInfo::Private::remove_startup_info_internal

2014-04-24 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117731/#review56349 --- Ship it! Ship It! - Thomas Lübking On April 24, 2014,

Review Request 117733: Fully port KXMessages to XCB

2014-04-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117733/ --- Review request for KDE Frameworks. Repository: kwindowsystem

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

2014-04-24 Thread Patrick Spendrin
On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote: Until now we had no problems with the data installed to bin/../share and this setup would make it impossible to have multiple independent kde setups on one system. Alexander Richardson wrote: I know. The problem is

Re: Re: Re: Writing a Frameworks book at Randa

2014-04-24 Thread Valorie Zimmerman
On Sun, Apr 13, 2014 at 10:38 PM, Martin Gräßlin mgraess...@kde.org wrote: On Friday 11 April 2014 00:23:26 David Narvaez wrote: On Thu, Apr 10, 2014 at 5:02 AM, Martin Gräßlin mgraess...@kde.org wrote: we might have here a chicken-egg problem. Good API documentation would significantly help

Review request: kdeebugdialog5 co-installability

2014-04-24 Thread Jonathan Riddell
Reviewboard does not like this patch and even my usual goto man for git help agateau can't work out why. So here's a manual review request kdelibs4support: http://starsky.19inch.net/~jr/tmp/DIFF rename kdebugdialog to kdeebugdialog5 internally and move documentation to allow for

Re: Review Request 117080: cleanup KDirModelTest

2014-04-24 Thread Alexander Richardson
On April 24, 2014, 8:44 a.m., David Faure wrote: I wonder why this was discarded -- other than the fact that I took too much time to get to it. It looks good to me. Okay, I'll reopen and fix the issues. - Alexander --- This is

Review Request 117749: Allow kmimeassociationstest to be run alone

2014-04-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117749/ --- Review request for KDE Frameworks and David Faure. Repository: kservice

Re: Review Request 117475: kmimeassociationstest: do not use KDE apps in test

2014-04-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117475/ --- (Updated April 24, 2014, 6:54 p.m.) Review request for KDE Frameworks

Android integration in KConfig framework

2014-04-24 Thread JAZEIX Johnny
Hi, I'm currently working on GCompris port (passing from Gtk to Qt5 qml/js) and for storing persistent data, i'm using KConfig (from https://projects.kde.org/projects/frameworks/kconfig/repository). It works fine on Desktop (tested on linux) and with a slight modification (I attached a

Re: Android integration in KConfig framework

2014-04-24 Thread Aleix Pol
On Thu, Apr 24, 2014 at 9:11 PM, JAZEIX Johnny jaz...@gmail.com wrote: Hi, I'm currently working on GCompris port (passing from Gtk to Qt5 qml/js) and for storing persistent data, i'm using KConfig (from https://projects.kde.org/projects/frameworks/kconfig/repository). It works fine on

Review Request 117758: Update install-compile.docbook translations to not reference KDE4

2014-04-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano.

Re: Review Request 117758: Update install-compile.docbook translations to not reference KDE4

2014-04-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/ --- (Updated April 24, 2014, 9:46 p.m.) Review request for Documentation,

Re: Review Request 117011: Use bin/../share on Windows as a workaround

2014-04-24 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/ --- (Updated April 24, 2014, 9:57 p.m.) Status -- This change has been

Re: Android integration in KConfig framework

2014-04-24 Thread Aleix Pol
On Thu, Apr 24, 2014 at 10:55 PM, Aleix Pol aleix...@kde.org wrote: On Thu, Apr 24, 2014 at 9:11 PM, JAZEIX Johnny jaz...@gmail.com wrote: Hi, I'm currently working on GCompris port (passing from Gtk to Qt5 qml/js) and for storing persistent data, i'm using KConfig (from

Re: Review Request 117758: Update install-compile.docbook translations to not reference KDE4

2014-04-24 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/#review56422 --- Ship it! I was hoping in other answers from translators :(

Re: Review Request 117491: Rework FindX11_XCB.cmake

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/#review56423 --- Ship it! Ship It! - Kevin Ottens On April 11, 2014, 8:32

Re: Review Request 117491: Rework FindX11_XCB.cmake

2014-04-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/#review56424 --- This review has been submitted with commit

Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/#review56425 --- Ship it! Ship It! - Kevin Ottens On April 14, 2014, 4:04

Re: Review Request 117585: ECMFindModuleHelpers: set traditional variables

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117585/#review56427 --- Ship it! Ship It! - Kevin Ottens On April 16, 2014, 1:14

Re: Review Request 117758: Update install-compile.docbook translations to not reference KDE4

2014-04-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/ --- (Updated April 24, 2014, 10:17 p.m.) Review request for Documentation,

Re: Review Request 117602: Remove more UPnP stuff

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117602/#review56430 --- Ship it! Ship It! - Kevin Ottens On April 16, 2014, 7:46

Re: Review Request 117617: New syntax for ecm_install_icons()

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117617/#review56432 --- Ship it! Ship It! - Kevin Ottens On April 17, 2014, 7:40

Re: Review Request 117658: Add a stub for ECMFindModuleHelpers to the find-modules dir

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117658/#review56434 --- Ship it! Ship It! - Kevin Ottens On April 20, 2014, 3

Re: Review Request 117581: Remove ECMDBusAddActivationService module

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117581/#review56435 --- Ship it! Ship It! - Kevin Ottens On April 21, 2014, 9:47

Re: Review Request 117619: Make ecm_setup_version interact well with CMP0048

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117619/#review56436 --- Ship it! Ship It! - Kevin Ottens On April 21, 2014, 9:49

Re: Review Request 117682: Define _DARWIN_C_SOURCE when building on Mac

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117682/#review56438 --- Same here, looks fine to me, but I'd like Harald to have a

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#review56439 --- Any chance to have some unit tests? - Kevin Ottens On

Re: Review Request 117749: Allow kmimeassociationstest to be run alone

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117749/#review56440 --- Looks fine to me. Let's wait for David though. - Kevin

Re: Review Request 117758: Update install-compile.docbook translations to not reference KDE4

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/#review56441 --- Ship it! Ship It! - Kevin Ottens On April 24, 2014, 10:17

Re: Review Request 117703: Use NETWinInfo instead of custom XLib code in KStartupInfo

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117703/#review56442 --- Ship it! Ship It! - Kevin Ottens On April 23, 2014, 11:58

Re: Review Request 117706: remove unused kwallet upgrade script

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117706/#review56444 --- Ship it! Ship It! - Kevin Ottens On April 23, 2014, 1:37

Re: Review Request 117708: move kioslave docs paths for co-installability

2014-04-24 Thread Kevin Ottens
On April 23, 2014, 3:30 p.m., Luigi Toscano wrote: I think after this change many documentation links (at least in khelpcenter) need to be fixed (I can't check now). That'd need to be confirmed before letting this patch in or not. - Kevin

Re: Review Request 117749: Allow kmimeassociationstest to be run alone

2014-04-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117749/#review56447 --- Ship it! Ship It! - David Faure On April 24, 2014, 5:37

Re: Review Request 117731: Improve KStartupInfo::Private::remove_startup_info_internal

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117731/#review56448 --- Ship it! Ship It! - Kevin Ottens On April 24, 2014, 5:46

Re: Review Request 117708: move kioslave docs paths for co-installability

2014-04-24 Thread Luigi Toscano
On April 23, 2014, 5:30 p.m., Luigi Toscano wrote: I think after this change many documentation links (at least in khelpcenter) need to be fixed (I can't check now). Kevin Ottens wrote: That'd need to be confirmed before letting this patch in or not. Right: I checked, and all

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-24 Thread Sven Brauch
On April 24, 2014, 10:31 p.m., Kevin Ottens wrote: Any chance to have some unit tests? Sure, I'll add some shortly. - Sven --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 117758: Update install-compile.docbook translations to not reference KDE4

2014-04-24 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/#review56458 --- Ship it! OK for me, thanks - Burkhard Lück On April 24,