Frameworks with ecm_add_test failing to configure with cmake

2014-05-10 Thread Bhushan Shah
Hello With extra-cmake-modules master the frameworks that uses ecm_add_tests are failing to configure.. For example, karchive. (not tested with others as my system can't even first package) -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success -- Performing Test

Re: Frameworks with ecm_add_test failing to configure with cmake

2014-05-10 Thread Martin Gräßlin
On Saturday 10 May 2014 13:47:56 Bhushan Shah wrote: Hello With extra-cmake-modules master the frameworks that uses ecm_add_tests are failing to configure.. For example, karchive. (not tested with others as my system can't even first package) I can confirm that behavior. I'm just

[extra-cmake-modules] modules: Revert use the NAME_PREFIX only for the test, not for the executable

2014-05-10 Thread Alex Merry
Git commit 7213137a75e832976c25168ae640d26369c771a7 by Alex Merry. Committed on 10/05/2014 at 10:26. Pushed by alexmerry into branch 'master'. Revert use the NAME_PREFIX only for the test, not for the executable This reverts commits b90b64632f46e929f26ab9a4ee0033478febe0eb

Jenkins build is back to normal : karchive_master_qt5 #48

2014-05-10 Thread KDE CI System
See http://build.kde.org/job/karchive_master_qt5/48/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kcoreaddons_master_qt5 #95

2014-05-10 Thread KDE CI System
See http://build.kde.org/job/kcoreaddons_master_qt5/95/ -- Started by user Ben Cooksley Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/kcoreaddons_master_qt5/ws/ Running Prebuild steps

Review Request 118069: Fix build of kconfig with recent extra-cmake-modules

2014-05-10 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118069/ --- Review request for KDE Frameworks. Repository: kconfig Description

Re: Review Request 118069: Fix build of kconfig with recent extra-cmake-modules

2014-05-10 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118069/ --- (Updated May 10, 2014, 6:20 p.m.) Review request for KDE Frameworks.

Re: Review Request 118069: Fix build of kconfig with recent extra-cmake-modules

2014-05-10 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118069/ --- (Updated May 10, 2014, 6:37 p.m.) Review request for KDE Frameworks and

Re: Review Request 118069: Fix build of kconfig with recent extra-cmake-modules

2014-05-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118069/#review57677 --- I changed this to build with the version without the prefix

Review Request 118071: add a message to the assertion

2014-05-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118071/ --- Review request for KDE Frameworks. Repository: kservice Description

Re: Review Request 118071: add a message to the assertion

2014-05-10 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118071/#review57678 --- src/services/kservicetypefactory.cpp

Re: Review Request 118071: add a message to the assertion

2014-05-10 Thread Alexander Richardson
On May 10, 2014, 3:59 p.m., Mark Gaiser wrote: src/services/kservicetypefactory.cpp, line 38 https://git.reviewboard.kde.org/r/118071/diff/1/?file=272328#file272328line38 You have a double ;; ;) Ah nice catch, will fix that before comitting - Alexander

Re: [extra-cmake-modules] modules: Revert use the NAME_PREFIX only for the test, not for the executable

2014-05-10 Thread Patrick Spendrin
Am 10.05.2014 12:28, schrieb Alex Merry: Git commit 7213137a75e832976c25168ae640d26369c771a7 by Alex Merry. Committed on 10/05/2014 at 10:26. Pushed by alexmerry into branch 'master'. Revert use the NAME_PREFIX only for the test, not for the executable This reverts commits

Re: [extra-cmake-modules] modules: Revert use the NAME_PREFIX only for the test, not for the executable

2014-05-10 Thread Alex Merry
On 10/05/14 20:37, Patrick Spendrin wrote: As you can see in my commits in ktextwidgets, kio, kxmlgui and several other locations, only the add_test call had the name prefix and not the executable. One occurance where the previous (and now current) will fail is kxmlgui autotests, where dfaure

Re: Review Request 118069: Fix build of kconfig with recent extra-cmake-modules

2014-05-10 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118069/#review57692 --- Is this still needed? It appears to be working now. - Alex

Jenkins build is back to normal : kapidox_master_qt5 #32

2014-05-10 Thread KDE CI System
See http://build.kde.org/job/kapidox_master_qt5/32/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kdelibs_stable #1086

2014-05-10 Thread KDE CI System
See http://build.kde.org/job/kdelibs_stable/1086/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118077: Fix build of kdelibs4migration.cpp on MSVC2010

2014-05-10 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118077/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 118069: Fix build of kconfig with recent extra-cmake-modules

2014-05-10 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118069/ --- (Updated May 11, 2014, 8:28 a.m.) Status -- This change has been