Re: Review Request 118101: fixed windows build

2014-05-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118101/#review57977 --- This review has been submitted with commit

Re: Review Request 118101: fixed windows build

2014-05-15 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118101/ --- (Updated May 15, 2014, 9:30 a.m.) Status -- This change has been

Jenkins build became unstable: kdelibs_stable #1089

2014-05-15 Thread KDE CI System
See http://build.kde.org/job/kdelibs_stable/1089/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118147: fix running ECMKDEModules test

2014-05-15 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118147/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and

Review Request 118149: Make sure KHelpCenter documentation goes to its own subdirectory

2014-05-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118149/ --- Review request for Documentation and KDE Frameworks. Repository:

Re: Review Request 118149: Make sure KHelpCenter documentation goes to its own subdirectory

2014-05-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118149/#review57993 --- By the way, I found the offending entries with: find . -name

Re: Review Request 118119: remove unneeded header

2014-05-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118119/#review57995 --- This review has been submitted with commit

Re: Review Request 118119: remove unneeded header

2014-05-15 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118119/ --- (Updated May 15, 2014, 2:54 p.m.) Status -- This change has been

Review Request 118153: remove unneeded file which collides with kf5plasma exports

2014-05-15 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118153/ --- Review request for KDE Frameworks, kdewin and Plasma. Repository:

Review Request 118155: adapt to ecm_add_tests so that tests can be found

2014-05-15 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118155/ --- Review request for KDE Frameworks, kdewin and Plasma. Repository:

Re: Review Request 118149: Make sure KHelpCenter documentation goes to its own subdirectory

2014-05-15 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118149/#review57998 --- Ship it! Ship It! - Luigi Toscano On May 15, 2014, 4:40

Re: Review Request 118149: Make sure KHelpCenter documentation goes to its own subdirectory

2014-05-15 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118149/#review57999 --- Ship it! Thanks doc/khelpcenter/CMakeLists.txt

Review Request 118156: Make SUBDIR argument mandatory in kdoctools_create_handbook

2014-05-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118156/ --- Review request for Documentation and KDE Frameworks. Repository:

Re: Review Request 118149: Make sure KHelpCenter documentation goes to its own subdirectory

2014-05-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118149/#review58004 --- This review has been submitted with commit

Re: Review Request 118155: adapt to ecm_add_tests so that tests can be found

2014-05-15 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118155/#review58006 --- Ship it! Ship It! - Patrick von Reth On May 15, 2014, 3

Re: Review Request 118153: remove unneeded file which collides with kf5plasma exports

2014-05-15 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118153/#review58007 --- Ship it! Ship It! - Patrick von Reth On May 15, 2014,

Re: Review Request 118149: Make sure KHelpCenter documentation goes to its own subdirectory

2014-05-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118149/ --- (Updated May 15, 2014, 3:19 p.m.) Status -- This change has been

Re: Review Request 118156: Make SUBDIR argument mandatory in kdoctools_create_handbook

2014-05-15 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118156/#review58009 --- Ship it! Ship It! - Luigi Toscano On May 15, 2014, 5:18

Re: Review Request 118153: remove unneeded file which collides with kf5plasma exports

2014-05-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118153/#review58012 --- Ship it! Ship It! - Marco Martin On May 15, 2014, 2:57

Re: Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

2014-05-15 Thread Aleix Pol Gonzalez
On May 14, 2014, 10:48 a.m., Aleix Pol Gonzalez wrote: Note that this broke lots of KAboutData uses. Please, when doing such changes remember there's things already ported. Michael Pyne wrote: Yes, my apologies. But the pain this change would cause if implemented (and

Re: Review Request 118102: Use all entries from a cert attribute instead of just using the first one

2014-05-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118102/#review58018 --- You probably want to .join(, ) with a space so it can wrap.

Re: Review Request 118104: Fix tests in kio

2014-05-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118104/#review58019 --- Ship it! Ship It! - David Edmundson On May 12, 2014, 4:45

Re: Review Request 118116: Rename DBus interfaces to use new namespaces

2014-05-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118116/#review58020 --- Ship it! Ship It! - David Edmundson On May 13, 2014, 4:25

Re: Review Request 118147: fix running ECMKDEModules test

2014-05-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118147/#review58023 --- Ship it! Ship It! - Alex Merry On May 15, 2014, 2:32

Re: Review Request 118147: fix running ECMKDEModules test

2014-05-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118147/#review58032 --- This review has been submitted with commit

Re: Review Request 118147: fix running ECMKDEModules test

2014-05-15 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118147/ --- (Updated May 15, 2014, 7:03 p.m.) Status -- This change has been

Re: Review Request 118115: adapt to ecm_add_test

2014-05-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118115/#review58033 --- This review has been submitted with commit

Re: Review Request 118153: remove unneeded file which collides with kf5plasma exports

2014-05-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118153/#review58035 --- This review has been submitted with commit

Re: Review Request 118153: remove unneeded file which collides with kf5plasma exports

2014-05-15 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118153/ --- (Updated May 15, 2014, 9:10 p.m.) Status -- This change has been

Re: Review Request 117125: start_kdeinit: Use capabilities instead of SUID

2014-05-15 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117125/ --- (Updated May 15, 2014, 11:12 p.m.) Review request for KDE Frameworks,

Re: Review Request 118156: Make SUBDIR argument mandatory in kdoctools_create_handbook

2014-05-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118156/#review58039 --- This review has been submitted with commit

Re: Review Request 118156: Make SUBDIR argument mandatory in kdoctools_create_handbook

2014-05-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118156/ --- (Updated May 15, 2014, 11:20 p.m.) Status -- This change has been

Review Request 118158: Always set src_dir to a not-empty value ('.')

2014-05-15 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118158/ --- Review request for Documentation, KDE Frameworks, Alex Merry, and Aurélien