---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118970/#review61067
---
I didn't find any large problems in the patch itself, just a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118970/#review61068
---
The code formatting is quite off. You probably want to run
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118911/
---
(Updated June 27, 2014, 8:38 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118911/#review61070
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118962/#review61080
---
+1 from me!
src/downloaddialog.h
Morning
As I was asked recently why the release schedule of KDE Frameworks 5 is not
(yet) on techbase.kde.org I took the liberty to change this:
http://techbase.kde.org/Schedules/Frameworks
It's link to the main page as well:
http://techbase.kde.org/Schedules
The content is taken from:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118972/
---
Review request for KDE Frameworks and Plasma.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118972/#review61082
---
Ship it!
Concept seems fine in general.
Check my comment
On June 27, 2014, 12:24 p.m., David Edmundson wrote:
src/declarativeimports/core/quicktheme.h, line 179
https://git.reviewboard.kde.org/r/118972/diff/1/?file=284935#file284935line179
Doesn't redeclaring a signal in a subclass cause a massive warning at
runtime?
We used to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118972/
---
(Updated June 27, 2014, 1:07 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118972/#review61085
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118972/
---
(Updated June 27, 2014, 1:09 p.m.)
Status
--
This change has been
See
http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/600/changes
Changes:
[notmart] Don't expose color properties in c++ api
--
Started by upstream project plasma-framework_master_qt5 build number 600
originally
See
http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/600/changes
Changes:
[notmart] Don't expose color properties in c++ api
--
Started by upstream project plasma-framework_master_qt5 build number 600
originally caused
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118972/#review61086
---
This review has been submitted with commit
See
http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/601/
--
Started by upstream project plasma-framework_master_qt5 build number 601
originally caused by:
Started by remote host 2a01:4f8:160:9363::9 with note:
See
http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/601/
--
Started by upstream project plasma-framework_master_qt5 build number 601
originally caused by:
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118962/#review61105
---
Ship it!
Ship It!
- Marco Martin
On June 26, 2014, 7:03
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118962/#review61106
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118962/
---
(Updated June 27, 2014, 6:17 p.m.)
Status
--
This change has been
Hi Ben,Hi Olivier,Hi KF5 devs,Hi folks on KDE-MAC,I finally came up with a patch for QStandardPaths:--MVM2:scripts marko$ ls -l
On Saturday 01 March 2014 17:33:45 David Faure wrote:
I don't mind adding it - but what about releasing?
Is anyone taking care of releasing polkit-qt-?
Or should we make it a framework so I release it with the rest of the
stuff
? Cc'ing some polkit-qt contributors.
This question is
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118985/
---
Review request for KDE Frameworks and Matthew Dawson.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118985/#review61112
---
src/core/ksharedconfig.cpp
On June 27, 2014, 11:47 p.m., Mark Gaiser wrote:
src/core/ksharedconfig.cpp, line 91
https://git.reviewboard.kde.org/r/118985/diff/1/?file=285018#file285018line91
-- slightly unrelated since it wasn't there before this patch.
} else {
wasTestModeEnabled =
On Friday 27 June 2014 23:01:33 Marko Käning wrote:
I guess I’ve spotted that one of the frameworks obviously messes up when
writing to the standard location below “Library/Application Support/“
because it omits the trailing slash leading to this mess-up:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118852/#review61114
---
autotests/kconfigtest.cpp
Hi David,
On 28 Jun 2014, at 01:59 , David Faure fa...@kde.org wrote:
That was one of the kbookmarks autotest. Fixed, thanks for the report.
oh, I am glad you spotted that so quickly.
Thanks for fixing it right away.
Greets,
Marko
___
On June 27, 2014, 9:02 p.m., David Faure wrote:
autotests/kconfigtest.cpp, line 175
https://git.reviewboard.kde.org/r/118852/diff/1/?file=282763#file282763line175
So any idea what in here triggers the ICE, more specifically, if it's
not related to enums?
Minimal ICE test case:
2014-06-27 20:59 GMT-03:00 David Faure fa...@kde.org:
On Friday 27 June 2014 23:01:33 Marko Käning wrote:
I guess I’ve spotted that one of the frameworks obviously messes up when
writing to the standard location below “Library/Application Support/“
because it omits the trailing slash leading
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118970/#review61117
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118970/
---
(Updated June 28, 2014, 12:57 a.m.)
Status
--
This change has been
32 matches
Mail list logo
