Re: Review Request 119382: Port kio-mtp to KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119382/#review63827 --- Ship it! Ship It! - David Faure On July 26, 2014, 8:40

Re: KAction Warning

On Saturday 19 July 2014 23:57:15 Christoph Cullmann wrote: Hi, perhaps that is a stupid question, but last time I read up in the docs, they didn't help me: KatePart spits out a lot of: kate(15138)/(default) KXMLGUIFactoryPrivate::saveDefaultActionProperties: Shortcut for KAction

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

On Aug. 2, 2014, 9:04 a.m., Alex Merry wrote: I would rather change the code. The Qt behaviour was changed for a reason, to prevent accidental use of dangerous behaviour, and I'm not too keen on undoing that move for all software that uses KDECompilerSettings. Sune Vuorela wrote:

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/ --- (Updated Aug. 5, 2014, 7:50 a.m.) Status -- This change has been

Re: KAction Warning

Le mardi 5 août 2014 08:19:35 David Faure a écrit : On Saturday 19 July 2014 23:57:15 Christoph Cullmann wrote: Hi, perhaps that is a stupid question, but last time I read up in the docs, they didn't help me: KatePart spits out a lot of: kate(15138)/(default)

Re: KAction Warning

On Saturday 19 July 2014 23:57:15 Christoph Cullmann wrote: Hi, perhaps that is a stupid question, but last time I read up in the docs, they didn't help me: KatePart spits out a lot of: kate(15138)/(default) KXMLGUIFactoryPrivate::saveDefaultActionProperties: Shortcut for

Re: Review Request 119382: Port kio-mtp to KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119382/ --- (Updated Srp. 5, 2014, 12:36 odp.) Status -- This change has been

Making KFileMetaData a framework

Hello people I would like to make KFileMetaData a framework. It's a simple library for extracting file metadata and text. It depends on the i18n and KArchive (can be made optional), along with a number of external dependencies which are optional. The code is of decent quality, and we have a

Re: Making KFileMetaData a framework

In general that's some of the tidied code I've seen in a long time. Comments below. One major, most not. TypeInfo/PropertyInfo/SimpleExtractionResult need a working operator= otherwise we shallow copy d. I can cause a crash in dump.cpp Extracting info from a file can take a long

Re: Review Request 119152: Do not define QT_DISABLE_DEPRECATED_BEFORE

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119152/ --- (Updated Aug. 5, 2014, 8:06 p.m.) Status -- This change has been

Re: Review Request 119588: Remove Qt5 debugfull hack from ECMConfig.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119588/ --- (Updated Aug. 5, 2014, 9:09 p.m.) Review request for Extra Cmake Modules

Re: Review Request 119505: Instance our onw QFileDialog instead of using getExistingDirectoryUrl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119505/ --- (Updated ago. 5, 2014, 10:01 p.m.) Review request for KDE Frameworks.

Re: KDE Frameworks 5.1.0 release

Martin Klapetek ha scritto: On Sat, Aug 2, 2014 at 3:48 PM, David Faure fa...@kde.org mailto:fa...@kde.org wrote: I just tagged and packed 5.1.0. Bugzilla versions also need to be updated. Is there some easy batch way to add new versions to bugzilla products? If not, I'll spend the

Re: Review Request 119588: Remove Qt5 debugfull hack from ECMConfig.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119588/#review63888 --- Ship it! Looks reasonable to me. - Aleix Pol Gonzalez On