Re: Review Request 118263: Port polkit-kde-agent to KF5::KDELibs4Support and KF5::IconThemes

2014-08-07 Thread Martin Bříza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118263/ --- (Updated Aug. 7, 2014, 9:54 a.m.) Status -- This change has been

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList activities) method

2014-08-07 Thread Thomas Lübking
On Aug. 6, 2014, 5:04 nachm., Thomas Lübking wrote: src/netwm.cpp, line 4779 https://git.reviewboard.kde.org/r/119267/diff/3/?file=296945#file296945line4779 - qstrdup? (also new code issue) Ivan Čukić wrote: nstrdup is used all over the file, qstrdup not. Would it be

Re: Review Request 119523: port TextField to QtControls

2014-08-07 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119523/ --- (Updated Aug. 7, 2014, 1:45 p.m.) Status -- This change has been

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

2014-08-07 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/ --- (Updated Aug. 7, 2014, 3:19 p.m.) Review request for KDE Frameworks and

Re: OSX/CI: plasma-framework fails building on branch master

2014-08-07 Thread Aleix Pol
On Fri, Aug 8, 2014 at 12:06 AM, Marko Käning mk-li...@email.de wrote: What am I missing here? --- ld: library not found for -lgcov clang: error: linker command failed with exit code 1 (use -v to see invocation) --- This hasn’t happened before... You're building with coverage enabled,