Re: Review Request 119849: Improve CMAKE error message when XRender or XFixes are missing

2014-08-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119849/#review64890 --- Ship it! best would of course be to migrate away from those

Re: Kioslave repos

2014-08-20 Thread Marco Martin
On Tuesday 19 August 2014, David Faure wrote: Does anyone disagree with my line of thought above? plasma-devel list may also have an opinion on this, sending there. Any news? To me it should be in whatever place it is better for most people, and if there are use cases for it being

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-20 Thread Marco Martin
On Aug. 19, 2014, 7:43 p.m., David Edmundson wrote: src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml, line 33 https://git.reviewboard.kde.org/r/119846/diff/1/?file=306474#file306474line33 Good question. I think it is needed to set background to

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/ --- (Updated Aug. 20, 2014, 9:36 a.m.) Review request for KDE Frameworks and

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-20 Thread Marco Martin
On Aug. 19, 2014, 7:43 p.m., David Edmundson wrote: src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml, line 51 https://git.reviewboard.kde.org/r/119846/diff/1/?file=306474#file306474line51 checked isn't a boolean, it's an enum of the checked, partial,

Re: Review Request 119808: Move module metadata to after class picker

2014-08-20 Thread Aleix Pol Gonzalez
On Aug. 19, 2014, 10:19 a.m., Aleix Pol Gonzalez wrote: I think it's disputable that the developers will want to interact with the File List more often. I think this shows we want a new design after all. For the moment, I won't +1 or -1. Alex Merry wrote: I'm admittedly going

Re: Review Request 119808: Move module metadata to after class picker

2014-08-20 Thread Martin Klapetek
On Aug. 19, 2014, 12:19 p.m., Aleix Pol Gonzalez wrote: I think it's disputable that the developers will want to interact with the File List more often. I think this shows we want a new design after all. For the moment, I won't +1 or -1. Alex Merry wrote: I'm admittedly going

Re: Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

2014-08-20 Thread Martin Klapetek
On Aug. 1, 2014, 4:31 p.m., Aleix Pol Gonzalez wrote: Well, you only get the frameworks integration when you're running Plasma 5... Actually, frameworksintegration should move to kde/workspace at least. It's not a framework. Martin Klapetek wrote: Well the message boxes

Re: How to promote less mature Frameworks?

2014-08-20 Thread Aleix Pol
On Tue, Aug 19, 2014 at 11:25 PM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 19 d'agost de 2014, a les 08:44:10, David Faure va escriure: On Friday 15 August 2014 12:51:58 Kevin Ottens wrote: On Friday 15 August 2014 09:34:04 Alex Merry wrote: On Friday 15 August 2014 10:21:57

Re: Kioslave repos

2014-08-20 Thread Aleix Pol
On Tue, Aug 19, 2014 at 9:49 PM, David Faure fa...@kde.org wrote: On Tuesday 01 July 2014 22:25:15 Jonathan Riddell wrote: On Tue, Jul 01, 2014 at 11:25:11PM +0200, David Faure wrote: On Sunday 27 April 2014 19:35:37 I wrote: * place that repo in kde/ or kde/something in the

Re: Kioslave repos

2014-08-20 Thread Jonathan Riddell
On Wed, Aug 20, 2014 at 12:28:30PM +0200, Aleix Pol wrote: On Tue, Aug 19, 2014 at 9:49 PM, David Faure fa...@kde.org wrote: On Tuesday 01 July 2014 22:25:15 Jonathan Riddell wrote: On Tue, Jul 01, 2014 at 11:25:11PM +0200, David Faure wrote: On Sunday 27 April 2014

Re: Kioslave repos

2014-08-20 Thread Luigi Toscano
On Wednesday 20 of August 2014 11:38:12 Jonathan Riddell wrote: On Wed, Aug 20, 2014 at 12:28:30PM +0200, Aleix Pol wrote: On Tue, Aug 19, 2014 at 9:49 PM, David Faure fa...@kde.org wrote: On Tuesday 01 July 2014 22:25:15 Jonathan Riddell wrote: On Tue, Jul 01, 2014 at

Re: How to promote less mature Frameworks?

2014-08-20 Thread Daniel Vratil
On Wednesday 20 of August 2014 12:14:31 Aleix Pol wrote: On Tue, Aug 19, 2014 at 11:25 PM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 19 d'agost de 2014, a les 08:44:10, David Faure va escriure: On Friday 15 August 2014 12:51:58 Kevin Ottens wrote: On Friday 15 August 2014

Re: How to promote less mature Frameworks?

2014-08-20 Thread laurent Montel
Le mercredi 20 août 2014 12:14:31 Aleix Pol a écrit : I see a small problem with git-only repos, and it's called release+distributions. I have heard that the plam is to frameworks-ize kdepimlibs, ideally one would like to do a release of kdepimlibs so that the kf5-based kdepim can

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/ --- (Updated Aug. 20, 2014, 1:05 p.m.) Review request for KDE Frameworks and

Re: Review Request 119849: Improve CMAKE error message when XRender or XFixes are missing

2014-08-20 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119849/ --- (Updated Aug. 20, 2014, 1:49 p.m.) Status -- This change has been

Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #91

2014-08-20 Thread KDE CI System
See http://build.kde.org/job/kwindowsystem_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

OSX/CI: threadweaver fails to build test

2014-08-20 Thread Marko Käning
Linking CXX executable ThreadWeaverJobTests [100%] Built target ThreadWeaverJobTests /Users/marko/WC/KDECI-builds/threadweaver/examples/ThumbNailer/Model.cpp:77:24: error: use of undeclared identifier 'accumulate' auto const soFar = accumulate(m_images.begin(), m_images.end(),

Re: OSX/CI: threadweaver fails to build test

2014-08-20 Thread Nicolás Alvarez
2014-08-20 14:21 GMT-03:00 Marko Käning mk-li...@email.de: Linking CXX executable ThreadWeaverJobTests [100%] Built target ThreadWeaverJobTests /Users/marko/WC/KDECI-builds/threadweaver/examples/ThumbNailer/Model.cpp:77:24: error: use of undeclared identifier 'accumulate' auto const

Re: OSX/CI: threadweaver fails to build test

2014-08-20 Thread Marko Käning
On 20 Aug 2014, at 19:28 , Nicolás Alvarez nicolas.alva...@gmail.com wrote: I got the same error on Windows. Fixed. Thanks, Nicolás, for taking care of this so quickly! (Will only later be able to test this on the OSX/CI system.) Greets, Marko ___

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-20 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/#review64922 --- Ship it! Ship It! - David Edmundson On Aug. 20, 2014,

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/ --- (Updated Aug. 20, 2014, 6:51 p.m.) Status -- This change has been

Re: Review Request 119871: Fix rendering glitches of TabButtons due to inconsistent option-state settings

2014-08-20 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119871/ --- (Updated Aug. 20, 2014, 8 p.m.) Review request for KDE Frameworks and

Re: Review Request 119871: Fix rendering glitches of TabButtons due to inconsistent option-state settings

2014-08-20 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119871/ --- (Updated Aug. 20, 2014, 8:02 p.m.) Review request for KDE Frameworks,

Re: Review Request 119871: Fix rendering glitches of TabButtons due to inconsistent option-state settings

2014-08-20 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119871/#review64935 --- Ship it! Actually, I see no reason why it should make things

Re: Review Request 119871: Fix rendering glitches of TabButtons due to inconsistent option-state settings

2014-08-20 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119871/ --- (Updated Aug. 20, 2014, 8:21 p.m.) Review request for KDE Frameworks,

Re: Review Request 119871: Fix rendering glitches of TabButtons due to inconsistent option-state settings

2014-08-20 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119871/ --- (Updated Aug. 20, 2014, 8:26 p.m.) Status -- This change has been

Re: kcoreaddons fails to build properly on OSX/CI (was OSX/CI: kauth fails to build )

2014-08-20 Thread Marko Käning
Hi Ben, just now on IRC Cristian pointed me to [1] which is exactly the problem I am seeing here with the latest cmake version!!! BUT, I am not using different versions of cmake locally, since that’s impossible with the CI system anyway. === So, could be it would be a good idea to re-open the

Review Request 119876: KIO: add KIO::EmptyTrashJob* KIO::emptyTrash().

2014-08-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119876/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 119868: KConfig add DirectoryType support

2014-08-20 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119868/ --- (Updated Aug. 20, 2014, 10:34 p.m.) Review request for KDE Frameworks,

Re: Review Request 119869: KIO: Correctly handle .directory files

2014-08-20 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119869/ --- (Updated Aug. 20, 2014, 10:35 p.m.) Review request for KDE Frameworks,