Re: Review Request 121100: Add qCDebug statements back into knewstuff sources.

2014-11-11 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121100/ --- (Updated Nov. 12, 2014, 2:01 a.m.) Status -- This change has been ma

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-11 Thread Albert Astals Cid
> On nov. 11, 2014, 2:39 p.m., Albert Astals Cid wrote: > > I sincerely think this is a *VERY BAD* idea. I don't want my app behaving > > differently depending if a third party misterious compononent that is not > > documented anywhere is installed or not. If you have a dependency, well put >

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-11 Thread Daniel Vrátil
> On Nov. 11, 2014, 3:39 p.m., Albert Astals Cid wrote: > > I sincerely think this is a *VERY BAD* idea. I don't want my app behaving > > differently depending if a third party misterious compononent that is not > > documented anywhere is installed or not. If you have a dependency, well put >

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-11 Thread Albert Astals Cid
> On nov. 11, 2014, 2:39 p.m., Albert Astals Cid wrote: > > I sincerely think this is a *VERY BAD* idea. I don't want my app behaving > > differently depending if a third party misterious compononent that is not > > documented anywhere is installed or not. If you have a dependency, well put >

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-11 Thread Sebastian Kügler
Hi Nicolas, Sorry for my late reply, I thought I had replied, but apparently that was never sent. :/ On Thursday, November 06, 2014 16:26:01 Nicolás Alvarez wrote: > 2014-11-05 23:44 GMT-03:00 Sebastian Kügler : > > So, this code is in a bit of a draft stage, I'd very much welcome feedback > > a

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-11 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121095/ --- (Updated Nov. 11, 2014, 3:51 p.m.) Review request for KDE Frameworks, Dav

Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext -> HTML conversion

2014-11-11 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121094/ --- (Updated Nov. 11, 2014, 3:51 p.m.) Review request for KDE Frameworks and

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-11 Thread Daniel Vrátil
> On Nov. 11, 2014, 3:39 p.m., Albert Astals Cid wrote: > > I sincerely think this is a *VERY BAD* idea. I don't want my app behaving > > differently depending if a third party misterious compononent that is not > > documented anywhere is installed or not. If you have a dependency, well put >

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121095/#review70238 --- I sincerely think this is a *VERY BAD* idea. I don't want my a

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-11 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121095/#review70236 --- Perhaps add a framework guy to this request (and other request

Re: Review Request 121103: KCodecs: Import KEmailAddress class from email address parsing and validation from KPimUtils

2014-11-11 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121103/ --- (Updated Nov. 11, 2014, 2:27 p.m.) Status -- This change has been di

Review Request 121103: KCodecs: Import KEmailAddress class from email address parsing and validation from KPimUtils

2014-11-11 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121103/ --- Review request for KDE Frameworks. Repository: kcodecs Description

Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext -> HTML conversion

2014-11-11 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121094/ --- (Updated Nov. 11, 2014, 1:49 p.m.) Review request for KDE Frameworks. R

Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext -> HTML conversion

2014-11-11 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121094/#review70234 --- src/lib/text/ktexttohtml.cpp

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-11 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121095/ --- (Updated Nov. 11, 2014, 1:12 p.m.) Review request for KDE Frameworks. R

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-11 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121095/#review70233 --- src/integrationplugin/frameworkintegrationplugin.cpp

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

2014-11-11 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/ --- (Updated Nov. 11, 2014, 11:20 a.m.) Status -- This change has been m

Jenkins build became unstable: kservice_master_qt5 #199

2014-11-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121100: Add qCDebug statements back into knewstuff sources.

2014-11-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121100/#review70228 --- Ship it! Looks sane. Some minor (and unrelated) comments inl

Re: How to port KTabBar::mouseMiddleClick?

2014-11-11 Thread David Gil Oliva
El 11/11/2014 10:50, "Kevin Funk" escribió: > > On Monday 10 November 2014 15:19:22 Nicolás Alvarez wrote: > > 2014-11-09 7:28 GMT-03:00 Frank Reininghaus : > > > Hi, > > > > > > 2014-11-06 2:59 GMT+01:00 Milian Wolff: > > >> Hey all, > > >> > > >> what do I do to get middle-click-closes-tab in Qt

Re: How to port KTabBar::mouseMiddleClick?

2014-11-11 Thread David Gil Oliva
El 10/11/2014 19:19, "Nicolás Alvarez" escribió: > > 2014-11-09 7:28 GMT-03:00 Frank Reininghaus : > > Hi, > > > > 2014-11-06 2:59 GMT+01:00 Milian Wolff: > >> Hey all, > >> > >> what do I do to get middle-click-closes-tab in Qt 5 without KTabBar? > >> Previously, we used KTabBar and its mouseMidd

Re: How to port KTabBar::mouseMiddleClick?

2014-11-11 Thread Kevin Funk
On Monday 10 November 2014 15:19:22 Nicolás Alvarez wrote: > 2014-11-09 7:28 GMT-03:00 Frank Reininghaus : > > Hi, > > > > 2014-11-06 2:59 GMT+01:00 Milian Wolff: > >> Hey all, > >> > >> what do I do to get middle-click-closes-tab in Qt 5 without KTabBar? > >> Previously, we used KTabBar and its

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

2014-11-11 Thread David Faure
> On Nov. 10, 2014, 9:57 p.m., David Faure wrote: > > src/services/kplugininfo.cpp, line 47 > > > > > > Missing "static" before inline, if these methods are only used in this > > .cpp file. > > Alexander Richard

Re: Review Request 121082: Add TODO for private signals in KJob

2014-11-11 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121082/ --- (Updated Nov. 11, 2014, 8:48 a.m.) Status -- This change has been ma