Re: Supporting MSVC2010 in ktexteditor framework

2014-11-17 Thread Ivan Čukić
On Monday, 17 November 2014 07:33:00 Kevin Ottens wrote: On Sunday 16 November 2014 18:01:04 Ivan Čukić wrote: Hi, The topic of increasing the compiler versions we require might have been started for the specific issue one of the frameworks had, but I think it shouldn't have died out

Re: Review Request 121098: Restore filedialog functionality for modal dialogs.

2014-11-17 Thread Martin Klapetek
On Nov. 15, 2014, 12:16 a.m., Martin Klapetek wrote: src/platformtheme/kdeplatformfiledialoghelper.cpp, lines 301-303 https://git.reviewboard.kde.org/r/121098/diff/1/?file=327582#file327582line301 Looking at QDialog docs, it says modal : bool This property holds

Re: Supporting MSVC2010 in ktexteditor framework

2014-11-17 Thread Ivan Čukić
Yeah, it looks like I've been looking at the CTP from November 2012 - for VS11 [1]. It would be awesome if somebody who has VS11 actually investigated this. Namely, the 11.0 proper should support variadics up to some number of arguments (yes, sounds really daft and hackish). If true, it

Re: Supporting MSVC2010 in ktexteditor framework

2014-11-17 Thread Nicolás Álvarez
El 17/11/2014, a las 06:03, Ivan Čukić ivan.cu...@kde.org escribió: On Monday, 17 November 2014 07:33:00 Kevin Ottens wrote: On Sunday 16 November 2014 18:01:04 Ivan Čukić wrote: - initializer lists Unsupported on VS2012. Again, seems to be that CTP thingie, damn. (though, again, the

Re: Problem with kdeinit and StartupInfo

2014-11-17 Thread Martin Klapetek
On Sat, Oct 4, 2014 at 1:47 PM, Alex Merry alex.me...@kde.org wrote: On 2014-10-04 10:08, David Faure wrote: On Friday 03 October 2014 12:15:09 Alex Merry wrote: Note that KDBusService has a known limitation where it just doesn't work with startup notifications in unique mode - the

Re: Supporting MSVC2010 in ktexteditor framework

2014-11-17 Thread Nicolás Alvarez
El domingo, 16 de noviembre de 2014, Ivan Čukić ivan.cu...@kde.org escribió: Hi, The topic of increasing the compiler versions we require might have been started for the specific issue one of the frameworks had, but I think it shouldn't have died out when the issue in question got patched.

Re: Supporting MSVC2010 in ktexteditor framework

2014-11-17 Thread Kai Uwe Broulik
- initializer lists Unsupported on VS2012. Again, seems to be that CTP thingie, damn. (though, again, the initializer lists should also be tested - maybe they also work if the number of arguments is less than ...) I've had problems with them even on VS2013, like return QHashint,

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-17 Thread Marco Martin
On Nov. 14, 2014, 12:16 p.m., Marco Martin wrote: hm, i don't really like it. is it working around a problem in particular? if i try the patch, the difference during startup (or just duringopening a popup on the first time) is pretty noticeable like, the wallpaper appearing several

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-17 Thread Sebastian Kügler
Hi Milian, Thanks for looking at my patches. Since the branch, as you noticed, is quite contaminated with unrelated changes, merging in and out stuff, I'll push these changes to a cleaned branch, and will address the issues you pointed out. I'll post a new RR then. On Sunday, November 16,

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-17 Thread Sebastian Kügler
Hi David, On Sunday, November 16, 2014 18:10:27 David Faure wrote: Cool that you're looking into this. On Thursday 06 November 2014 03:44:58 Sebastian Kügler wrote: - a small tool called kplugin-update-index collects the json metadata from the plugins, and puts the list of plugins in a

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

2014-11-17 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121145/ --- (Updated Nov. 17, 2014, 3:39 p.m.) Review request for KDE Frameworks,

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

2014-11-17 Thread Laurent Montel
On nov. 17, 2014, 3:24 après-midi, Christoph Feck wrote: src/ksplittercollapserbutton.cpp, line 276 https://git.reviewboard.kde.org/r/121145/diff/3/?file=328890#file328890line276 Please pass at least a QStyleOption to pixelMetric(). For some styles, the metric depends on the font

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

2014-11-17 Thread Christoph Feck
On Nov. 17, 2014, 3:24 p.m., Christoph Feck wrote: src/ksplittercollapserbutton.cpp, line 276 https://git.reviewboard.kde.org/r/121145/diff/3/?file=328890#file328890line276 Please pass at least a QStyleOption to pixelMetric(). For some styles, the metric depends on the font size,

Re: Review Request 121098: Restore filedialog functionality for modal dialogs.

2014-11-17 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121098/ --- (Updated Nov. 17, 2014, 9:39 a.m.) Status -- This change has been

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

2014-11-17 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121145/ --- (Updated nov. 17, 2014, 4:48 après-midi) Review request for KDE

Review Request 121153: Restore filedialog show() functionality for modal dialogs

2014-11-17 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121153/ --- Review request for KDE Frameworks. Repository: frameworkintegration

Review Request 121160: Add libgit2 compile-time check for threads support

2014-11-17 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121160/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository:

Re: Review Request 121160: Add libgit2 compile-time check for threads support

2014-11-17 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121160/#review70541 --- Ship it! Ship It! - Christoph Cullmann On Nov. 17, 2014,

Review Request 121163: Also allow absolute filepaths for configfile parameter.

2014-11-17 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121163/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository:

Re: Review Request 121163: Also allow absolute filepaths for configfile parameter.

2014-11-17 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121163/#review70545 --- Ship it! Works for me :) - Albert Astals Cid On nov. 17,

Re: Review Request 121160: Add libgit2 compile-time check for threads support

2014-11-17 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121160/ --- (Updated Nov. 17, 2014, 10:45 p.m.) Status -- This change has been

OSX/CI: gwenview build fails on branch master

2014-11-17 Thread Marko Käning
1) Kdcraw is not found, although project libkdcraw is installed on the OSX/CI system. 2) I am wondering also why gwenview fails building on OSX for the not installed optional package Exiv2. --- . . . -- Could NOT find Exiv2 (missing: EXIV2_LIBRARY EXIV2_INCLUDE_DIR) (Required is at least

Re: Review Request 121163: Also allow absolute filepaths for configfile parameter.

2014-11-17 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121163/ --- (Updated Nov. 17, 2014, 11:28 p.m.) Status -- This change has been

Re: Review Request 121153: Restore filedialog show() functionality for modal dialogs

2014-11-17 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121153/#review70564 --- I tested this here and FileDialog qml still hangs the ui with