Re: Review Request 121575: FindEpoxy.cmake

2014-12-18 Thread Jan Kundrát
On Dec. 18, 2014, 8:47 a.m., Martin Gräßlin wrote: find-modules/Findepoxy.cmake, line 14 https://git.reviewboard.kde.org/r/121575/diff/1/?file=333638#file333638line14 I just need to point out that I consider epoxy as a bad dependency for usage in a cross platform library (like

Re: Review Request 121575: FindEpoxy.cmake

2014-12-18 Thread Marco Martin
On Dec. 18, 2014, 8:47 a.m., Martin Gräßlin wrote: find-modules/Findepoxy.cmake, line 14 https://git.reviewboard.kde.org/r/121575/diff/1/?file=333638#file333638line14 I just need to point out that I consider epoxy as a bad dependency for usage in a cross platform library (like

Re: Review Request 121258: Restart KDirWatch after a failed delete operation

2014-12-18 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121258/ --- (Updated Dec. 18, 2014, 9:38 a.m.) Status -- This change has been

Re: Baloo Framework - License Exception

2014-12-18 Thread Vishesh Handa
On Wed, Dec 17, 2014 at 2:38 PM, Milian Wolff m...@milianw.de wrote: May I ask the question why Baloo should become a framework in the first place? On Windows or Mac, people won't use it anyways, no? Or is it required there for e.g. searches in KMail? * Windows and Mac people should be

libnm-qt framework

2014-12-18 Thread Jan Grulich
Hi, I would like to inform you that libnm-qt (NetworkManagerQt) finally became an official framework. Git repository was moved under frameworks/libnm-qt and first release should be with KDE Frameworks 5.6.0. If you have any issues with this library you can report it under

Re: libnm-qt framework

2014-12-18 Thread David Faure
On Thursday 18 December 2014 12:34:55 Jan Grulich wrote: Hi David, I wanted to ask you if you could add libnm-qt to the list of frameworks in sysadmin/release-tools/modules.git as I probably don't have access there. Also if you could please re-check kde-build-metadata if I adjusted there

Re: Review Request 119607: Support for .hidden files

2014-12-18 Thread Bruno Nova
On Set. 17, 2014, 7:59 p.m., David Faure wrote: Thanks for the patch. A few comments: Is there any sort of spec or reference implementation for .hidden files? Are they supposed to support wildcards, for instance? Something else, it would be good to add a unittest to

Re: Baloo Framework - License Exception

2014-12-18 Thread Milian Wolff
On Thursday 18 December 2014 12:43:18 Vishesh Handa wrote: On Wed, Dec 17, 2014 at 2:38 PM, Milian Wolff m...@milianw.de wrote: May I ask the question why Baloo should become a framework in the first place? On Windows or Mac, people won't use it anyways, no? Or is it required there for

Re: Review Request 121581: Plotter in kdeclarative

2014-12-18 Thread Sebastian Gottfried
On Dez. 18, 2014, 1:05 vorm., Aleix Pol Gonzalez wrote: I think it's a useful component that can end up being really useful elsewhere, therefore I think kdeclarative it's a good place to be. I'd say it would be better to have it in a separate qml module. IIRC, the idea of

Re: Review Request 121581: Plotter in kdeclarative

2014-12-18 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121581/#review72258 --- In general +1 to the idea. I think it makes more sense to

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-18 Thread Ralf Habacker
On Dez. 12, 2014, 3:08 nachm., Alex Merry wrote: modules/ECMAddAppIcon.cmake, line 15 https://git.reviewboard.kde.org/r/121448/diff/1/?file=332663#file332663line15 Would this actually work? The code looks to me like pattern_rx would just be the filename again, so fn would be

Re: Review Request 121575: FindEpoxy.cmake

2014-12-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121575/ --- (Updated Dec. 18, 2014, 3:37 p.m.) Review request for KDE Frameworks,

Change in kio[master]: Add ark's Extract Here option to the context menu even whe...

2014-12-18 Thread Arjun AK (Code Review)
Arjun AK has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/250 Change subject: Add ark's Extract Here option to the context menu even when files are of different types .. Add ark's Extract Here option

Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-18 Thread Martin Klapetek
On Wed, Dec 17, 2014 at 9:11 PM, šumski hrvoje.sen...@gmail.com wrote: Hi, i've checked your clone, and what new requirements will that bring, and if the CMakeLists there are accurate, that will create a problem. We will have a dependency circle between kglobalaccel, kinit, kio and

Re: Review Request 121575: FindEpoxy.cmake

2014-12-18 Thread Fredrik Höglund
On Dec. 18, 2014, 8:47 a.m., Martin Gräßlin wrote: find-modules/Findepoxy.cmake, line 14 https://git.reviewboard.kde.org/r/121575/diff/1/?file=333638#file333638line14 I just need to point out that I consider epoxy as a bad dependency for usage in a cross platform library (like

OSX/CI: kde-baseapps fails to build on branch frameworks

2014-12-18 Thread Marko Käning
/Users/marko/WC/KDECI-builds/kde-baseapps/dolphin/src/tests/kfileitemlistviewtest.cpp:91:16: error: no matching constructor for initialization of 'QSignalSpy' QSignalSpy itemsRemovedSpy(m_model, KFileItemModel::itemsRemoved); ^

Re: Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-18 Thread Martin Gräßlin
On Thursday 18 December 2014 20:15:52 Martin Klapetek wrote: On Wed, Dec 17, 2014 at 9:11 PM, šumski hrvoje.sen...@gmail.com wrote: Hi, i've checked your clone, and what new requirements will that bring, and if the CMakeLists there are accurate, that will create a problem. We will have