Re: Review Request 121317: Add JSON metadata to the kded modules

2015-02-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121317/#review76698 --- Oops, what happened here? Did I forget to review this? Having

Re: Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave

2015-02-26 Thread Vishesh Handa
On Feb. 25, 2015, 10:24 a.m., Vishesh Handa wrote: sftp/kio_sftp.cpp, line 247 https://git.reviewboard.kde.org/r/122621/diff/1/?file=350141#file350141line247 The code indentation seems wrong. Emmanuel Pescosta wrote: Just followed the coding style (1 tab - 2 spaces) from

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #1031

2015-02-26 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #1032

2015-02-26 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KDE Telepathy has an unreleased dependency

2015-02-26 Thread Martin Klapetek
On Thu, Feb 26, 2015 at 4:22 PM, Vishesh Handa m...@vhanda.in wrote: On Wed, Feb 25, 2015 at 6:39 PM, Martin Klapetek martin.klape...@gmail.com wrote: As I said it's not even being used right now, so imho would be fine if it got removed/disabled altogether. Also, it will never work.

Re: KDE Telepathy has an unreleased dependency

2015-02-26 Thread Vishesh Handa
On Wed, Feb 25, 2015 at 6:39 PM, Martin Klapetek martin.klape...@gmail.com wrote: As I said it's not even being used right now, so imho would be fine if it got removed/disabled altogether. Also, it will never work. Baloo KF5, has no knowledge about emails. That code also uses Akonadi APIs.

Re: Review Request 122732: Add std::function overloads for KServiceTypeTrader

2015-02-26 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122732/#review76685 --- src/services/kservicetypetrader.h

Review Request 122733: Fix path traversal checks in KPackage

2015-02-26 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122733/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository:

Review Request 122732: Add std::function overloads for KServiceTypeTrader

2015-02-26 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122732/ --- Review request for KDE Frameworks, Marco Martin and Sebastian Kügler.

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2015-02-26 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/#review76681 --- Ping? - Alex Richardson On Dez. 24, 2014, 1:23 nachm.,

Re: Review Request 121283: Allow using new style connect in KActionCollection::add[Action]()

2015-02-26 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121283/ --- (Updated Feb. 26, 2015, 6:49 nachm.) Review request for KDE Frameworks,

Re: Review Request 121317: Add JSON metadata to the kded modules

2015-02-26 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121317/ --- (Updated Feb. 26, 2015, 6:53 nachm.) Status -- This change has been

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-02-26 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/#review76686 --- Ping, Frameworks people? - Kai Uwe Broulik On Feb. 16,

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-02-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/#review76687 --- src/kglobalaccel.h

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-02-26 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/ --- (Updated Feb. 26, 2015, 9:39 nachm.) Review request for KDE Frameworks,

Re: KDE Telepathy has an unreleased dependency

2015-02-26 Thread Albert Astals Cid
El Dijous, 26 de febrer de 2015, a les 16:55:17, Martin Klapetek va escriure: On Thu, Feb 26, 2015 at 4:22 PM, Vishesh Handa m...@vhanda.in wrote: On Wed, Feb 25, 2015 at 6:39 PM, Martin Klapetek martin.klape...@gmail.com wrote: As I said it's not even being used right now, so imho