Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

2015-04-16 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/#review79085 --- Ship it! Ship It! - Jeremy Whiting On April 12, 2015, 3:20

Re: Review Request 122981: add new method KGlobalAccel::shortcut(componentName, actionId)

2015-04-16 Thread Thomas Lübking
> On April 16, 2015, 3:20 nachm., Martin Gräßlin wrote: > > src/kglobalaccel.h, line 276 > > > > > > I think it needs a different name, see: > > > > https://techbase.kde.org/Policies/Binary_Compatibility_Iss

Re: Review Request 123390: Reorder member variables to reduce memory usage.

2015-04-16 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123390/#review79078 --- Hi volker What did you use as program to detect it ? Thanks fo

Re: Review Request 123390: Reorder member variables to reduce memory usage.

2015-04-16 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123390/#review79075 --- Ship it! Every byte counts :) - Christoph Feck On April 16

Review Request 123390: Reorder member variables to reduce memory usage.

2015-04-16 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123390/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kwidget

Re: Review Request 122487: Reorder member variables to reduce memory usage.

2015-04-16 Thread Volker Krause
> On April 16, 2015, 4:53 p.m., Milian Wolff wrote: > > nice :) how did you find it - do you have a tool for that now or was this > > still requiring manual interpretation? The tool is getting better and now also exists in a single-purpose command line version, in the above mentioned repo. Res

Re: Review Request 122487: Reorder member variables to reduce memory usage.

2015-04-16 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122487/#review79066 --- nice :) how did you find it - do you have a tool for that now

Re: Review Request 122981: add new method KGlobalAccel::shortcut(componentName, actionId)

2015-04-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/#review79060 --- src/kglobalaccel.h (line 276)

Re: Review Request 123030: Let KHtml be useable w/o searching for private deps

2015-04-16 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123030/ --- (Updated April 16, 2015, 4:06 p.m.) Review request for KDE Frameworks and