Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-26 Thread Ashish Bansal
On April 6, 2015, 1:12 p.m., Martin Klapetek wrote: autotests/globaltest.cpp, line 96 https://git.reviewboard.kde.org/r/123224/diff/2/?file=359784#file359784line96 This should be (1).txt? Ashish Bansal wrote: imho if my any file starts with ., that's my dot file and I would

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-26 Thread Ashish Bansal
On April 25, 2015, 7:42 p.m., David Faure wrote: src/core/global.cpp, line 397 https://git.reviewboard.kde.org/r/123224/diff/2/?file=359785#file359785line397 Why do you assemble a list, and then only look at the last element? You just need an int and a QMimeType, if only the last

Review Request 123508: kxmlgui: Fix load of shortcuts when alternate set.

2015-04-26 Thread Lindsay Roberts
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123508/ --- Review request for KDE Frameworks. Bugs: 337131, 339243, 340803, and

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-26 Thread Ashish Bansal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 26, 2015, 12:19 p.m.) Review request for KDE Frameworks,

Re: Review Request 123443: Make it possible to call a put job from an IODevice

2015-04-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123443/ --- (Updated April 26, 2015, 11:43 p.m.) Status -- This change has been

Re: Review Request 123414: Duplicate RecentDocuments entry if two different files have the same name.

2015-04-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123414/#review79543 --- Ship it! You can apply this to kdelibs4 too, after

Re: Review Request 123414: Duplicate RecentDocuments entry if two different files have the same name.

2015-04-26 Thread Anthony Vital
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123414/ --- (Updated avr. 26, 2015, 7:12 après-midi) Review request for KDE

Re: Review Request 123414: Duplicate RecentDocuments entry if two different files have the same name.

2015-04-26 Thread Anthony Vital
On avr. 25, 2015, 8:06 après-midi, David Faure wrote: You're quite right about quite a long time. Looking at git log -p on the kdelibs4 file, it appears that I broke this in 2002 (commit 1e57eeccd7). Wow :-) I think the point about two different apps = two entries is so that you

Review Request 123514: Make it possible to treat non-sequential QIODevice asynchronously

2015-04-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123514/ --- Review request for KDE Frameworks. Repository: kio Description ---