Re: Review Request 123811: Use tcgetattr tcsetattr if available

2015-05-17 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123811/#review80499 --- Ship it! Ship It! - Oswald Buddenhagen On May 16, 2015,

Re: Review Request 123811: Use tcgetattr tcsetattr if available

2015-05-17 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123811/ --- (Updated May 17, 2015, 8:47 a.m.) Status -- This change has been

Re: Review Request 123803: Coding Style for k7zip.cpp kar.cpp karchive.cpp kbzip2filter.cpp kcompressiondevice.cpp kfilterdev.cpp kgzipfilter.cpp klimitediodevice.cpp knonefilter.cpp krcc.cpp ktar.cpp

2015-05-17 Thread Guy Maurel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123803/ --- (Updated May 17, 2015, 4:03 p.m.) Status -- This change has been

Review Request 123830: Coding Style for main.cpp

2015-05-17 Thread Guy Maurel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123830/ --- Review request for KDE Frameworks, Mario Bensi and David Faure.

Review Request 123831: Coding Style for main.cpp

2015-05-17 Thread Guy Maurel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123831/ --- Review request for KDE Frameworks, Mario Bensi and David Faure.

Re: Review Request 121471: Port KDirSelectDialog to QFileDialog

2015-05-17 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121471/ --- (Updated KvÄ›. 17, 2015, 5:04 odp.) Status -- This change has been

Re: Review Request 123803: Coding Style for k7zip.cpp kar.cpp karchive.cpp kbzip2filter.cpp kcompressiondevice.cpp kfilterdev.cpp kgzipfilter.cpp klimitediodevice.cpp knonefilter.cpp krcc.cpp ktar.cpp

2015-05-17 Thread Guy Maurel
On May 15, 2015, 9:49 p.m., David Faure wrote: About your commit log: we won't have a different coding style for karchive, all frameworks should follow https://techbase.kde.org/Policies/Kdelibs_Coding_Style and https://techbase.kde.org/Policies/Library_Code_Policy About the