Jaroslaw,
On Thu, Jun 18, 2015 at 3:20 AM, Jaroslaw Staniek stan...@kde.org wrote:
Hi
If you look at apps ported to KF5, KAboutData::setApplicationData() is
used but there are also redundant lines in main(), at least these:
app.setApplicationName(aboutData.componentName());
Check console output at
https://build.kde.org/job/kbookmarks%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/6/
to view the results.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
On 18 June 2015 at 14:50, Jeremy Whiting jpwhit...@kde.org wrote:
Jaroslaw,
On Thu, Jun 18, 2015 at 3:20 AM, Jaroslaw Staniek stan...@kde.org wrote:
Hi
If you look at apps ported to KF5, KAboutData::setApplicationData() is
used but there are also redundant lines in main(), at least these:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/36/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Fri, 19 Jun 2015 00:48:34 +
Build duration: 6 min 41 sec
CHANGE SET
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124121/#review81558
---
Ship it!
src/kplotwidget.h (line 188)
I just came back from a 3 week holiday and there's emails (with one dating
back from June 1) that have not been moderated.
So i guess we need more hands for the next time i decide to go on holiday :D
Cheers,
Albert
___
Kde-frameworks-devel mailing
Am Donnerstag, 11. Juni 2015, 09:28:40 schrieb Jaroslaw Staniek:
Thanks, please let me understand; first - regarding KPluginMetaData:
Why is a hint needed there if KPluginMetaData::readTranslatedString()
cust constructs a magic key with a [lang] sufffix?
You are right, no hint needed.
--
Am 01.06.2015 09:48 schrieb David Faure:
On Thursday 21 May 2015 14:41:27 Gregor Mi wrote:
private:
-// Note that this object must live long enough in case the user
opens
-// the Configure... dialog
-KMoreTools* m_kmt = nullptr;
-
-QMenu* m_menu = nullptr;
+
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123321/
---
(Updated June 18, 2015, 7:55 p.m.)
Status
--
This change has been
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/40/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Thu, 18 Jun 2015 19:14:49 +
Build duration: 6 min 45 sec
CHANGE SET
No
On Thu, Jun 18, 2015 at 9:44 PM, Albert Astals Cid aa...@kde.org wrote:
I just came back from a 3 week holiday and there's emails (with one dating
back from June 1) that have not been moderated.
So i guess we need more hands for the next time i decide to go on holiday :D
Oh, I see...
You can
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124121/
---
Review request for KDE Frameworks and Christoph Feck.
Repository:
(I am sorry, forgot to include kde-devel too)
On 18 June 2015 at 11:20, Jaroslaw Staniek stan...@kde.org wrote:
Hi
If you look at apps ported to KF5, KAboutData::setApplicationData() is
used but there are also redundant lines in main(), at least these:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124117/
---
Review request for KDE Frameworks and Christoph Feck.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124116/
---
(Updated June 18, 2015, 8:20 a.m.)
Status
--
This change has been
Hi
If you look at apps ported to KF5, KAboutData::setApplicationData() is
used but there are also redundant lines in main(), at least these:
app.setApplicationName(aboutData.componentName());
app.setApplicationDisplayName(aboutData.displayName());
16 matches
Mail list logo
